From patchwork Tue Apr 10 12:17:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 133077 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp1240384ljb; Tue, 10 Apr 2018 05:24:00 -0700 (PDT) X-Google-Smtp-Source: AIpwx49Dym784QPMjVce33XfoM0q6GbwDNeRDO3sLZVb9f2jOBeHDSJ0Wnn8H3Anwdwb++sc/kBl X-Received: by 10.55.155.138 with SMTP id d132mr209900qke.247.1523363040709; Tue, 10 Apr 2018 05:24:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523363040; cv=none; d=google.com; s=arc-20160816; b=OhS50JCYlIBETOipHm0GKgicQPlocqqNQSk1NHJ0Q9wBFuDVlvmGiqz/Sqsegbxz19 ceZMrWiBpKxv39m6OIgsZTMG8fDKd0MW7GihsdERZkeQgNuleYThVlBtyIlrpyCA8RA1 r71PWGJSDW4v2EnYT/S6xhBZLb4ergRIndYh+1TcfUYRvVtbUX2jtfv9IPRWO6jBe0n4 YDnQD0Jzn/5UuTJY1xBidXZSFpBohHEKu57TwlWUiwNOJSZfhgIu0vMre9mPPobjZmq2 W9YDCMhIfqdL8oub5GJVzdQjDQlsW9SuVqCOdWdbLbMiNSqawSiAT8yU3twYDPLKPAzU uPcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=/L1k1rOG5WP7uJvJHN/7/nB6MWjcL3+mSoa3GJBQ66c=; b=CMzIaaU1WGz10OSwN0b3LS0h60eRRjt72J2du74XjCZh8gjvZpdRQ1wjxWTh/deoP0 xu/jFmraMm50J8HetPRTl+izHMoID0i6fOX33rBixTGlHx6VdQRBlXYanmIKhkseOIcH a0gDI8lhbKB/71sYaAEhIGnf71HzTNga4yX9H75/ooDckZ8MCveplpjzu9LciSz1WH3H ffLpkdMy7eSzUSThxpDtyrBGqQel9F7uaryDHlbIjWkTXtRj5VAJ1W9f4RchaFg6HMxa 0oiRlY2xgPwJWsU5fDuXhZUG/f87qKxDJ/P+Ia3aGomMacddiQ4YPojOPMkFhYBq56EF UV+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id a130si1806924qkg.352.2018.04.10.05.24.00 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 10 Apr 2018 05:24:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40600 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5sJc-0003rn-3D for patch@linaro.org; Tue, 10 Apr 2018 08:24:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5sDT-0007v2-2G for qemu-devel@nongnu.org; Tue, 10 Apr 2018 08:17:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5sDR-0000jL-2H for qemu-devel@nongnu.org; Tue, 10 Apr 2018 08:17:39 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:40760) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f5sDQ-0000er-SF for qemu-devel@nongnu.org; Tue, 10 Apr 2018 08:17:37 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1f5sDM-0007cc-EO for qemu-devel@nongnu.org; Tue, 10 Apr 2018 13:17:32 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 10 Apr 2018 13:17:20 +0100 Message-Id: <20180410121724.8549-9-peter.maydell@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180410121724.8549-1-peter.maydell@linaro.org> References: <20180410121724.8549-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 08/12] target/arm: Report unsupported MPU region sizes more clearly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Currently our PMSAv7 and ARMv7M MPU implementation cannot handle MPU region sizes smaller than our TARGET_PAGE_SIZE. However we report that in a slightly confusing way: DRSR[3]: No support for MPU (sub)region alignment of 9 bits. Minimum is 10 The problem is not the alignment of the region, but its size; tweak the error message to say so: DRSR[3]: No support for MPU (sub)region size of 512 bytes. Minimum is 1024. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180405172554.27401-1-peter.maydell@linaro.org --- target/arm/helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.16.2 diff --git a/target/arm/helper.c b/target/arm/helper.c index dcb8476d9e..b14fdab140 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -9625,9 +9625,9 @@ static bool get_phys_addr_pmsav7(CPUARMState *env, uint32_t address, } if (rsize < TARGET_PAGE_BITS) { qemu_log_mask(LOG_UNIMP, - "DRSR[%d]: No support for MPU (sub)region " - "alignment of %" PRIu32 " bits. Minimum is %d\n", - n, rsize, TARGET_PAGE_BITS); + "DRSR[%d]: No support for MPU (sub)region size of" + " %" PRIu32 " bytes. Minimum is %d.\n", + n, (1 << rsize), TARGET_PAGE_SIZE); continue; } if (srdis) {