From patchwork Wed May 2 22:15:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 134868 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp1206138lji; Wed, 2 May 2018 15:23:46 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqIS9PBTSyC+4+8lnHW60q4Za7dYxP1qYUugHFIy574yghv8CMOLck0ySi7jxyU0NaZMogt X-Received: by 2002:ac8:70c3:: with SMTP id g3-v6mr16752470qtp.95.1525299826441; Wed, 02 May 2018 15:23:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525299826; cv=none; d=google.com; s=arc-20160816; b=Y+m9qprp//l9LT+fOfvXNig3YgYmHogl5tsv1JH+sQku1xhTQXaNOc8CDYi/iTh8Ui xK6B0WSZsFlwaJmJdQ6FcCmvfXtGtoljbSlK0osr4rnxCX2qLNTSYqBZwAKRHlWHhm1C kgZ39bVnwyuW+iJqBYMEH6Cw1ti2U+PTtXdxNX+9vNCnl8JqtNLSusdFxVbsRFowGsrL U5htv1w3mQSwKqscY+K2UXQ1N8Krl0qD2CwD4WtZ+cudgI8vuIFVvwgtA7XIs0Q3Rrjh pd9m3vPldxlR5hpECExCIu1mw29jnixk7igzW8vsjRf1lTx4RJCpioq70LBzCM1pmx3v NjvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=+NJcK2bxHsiTQWd1zChLZWnGl5un7Pg1c9+Vm3qmlP8=; b=T7PMTWqNZi46RBUjslhxad5BWr4tcAd9zi6htoM7jQ+lLlE+xSSdzbhjlil8Pn6d66 xvX5w73JwaB2erGFhRyk9U7X7I+aW5+YuGaPcXZOFhRz0BD5Akkt39eqQrg0Mtqm+54W EgKpmbajewIlmDt6LP03MB2slCJe+bq2mTiO8Yaqu1+tUmZVI+xEWRsZjRWucV7V4avQ QjLb+fWTYFNkW2Evdnt0iBYC2wx7LqwjZasRLWzQ0mOJcnPBNTm4mvbqO7QHE5cUvGhZ RVJC5PTTsiAcj6tjg1sUT1UTUQ4Vd5wksSgtxQTqlsJjxwxdZqlEmitrJpvOFIB0EUdL yWjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=edVsKRIH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id l187si4383454qkc.304.2018.05.02.15.23.46 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 02 May 2018 15:23:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=edVsKRIH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fE0A5-0006cr-QP for patch@linaro.org; Wed, 02 May 2018 18:23:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fE02k-0000ni-Fp for qemu-devel@nongnu.org; Wed, 02 May 2018 18:16:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fE02j-0007z5-CF for qemu-devel@nongnu.org; Wed, 02 May 2018 18:16:10 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:39710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fE02j-0007y3-5M for qemu-devel@nongnu.org; Wed, 02 May 2018 18:16:09 -0400 Received: by mail-pf0-x243.google.com with SMTP id z9so12955726pfe.6 for ; Wed, 02 May 2018 15:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+NJcK2bxHsiTQWd1zChLZWnGl5un7Pg1c9+Vm3qmlP8=; b=edVsKRIHqE6KZU26kmq98OIAhB0lnubunVMxNkN+pbFB13uCPnSn0QOcusDzb9G0r5 If2Nv1D8wA66/ztKkHo3+LI4NBTuzJ4Ae8LZBdKtp4pph4jTf93LKn4IyyQwj/SPsbwB luG9KUfcZQyIA9PJxyE4lZOMRzDRNebwKFK80= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+NJcK2bxHsiTQWd1zChLZWnGl5un7Pg1c9+Vm3qmlP8=; b=Zbw6w/DXWk1asSejS3r811UY3q1Qe0fbaRXAlVqIt5zImfMfIFaNlR+sRX3tKQKWsv wIuDm3L92sDxAMEb4WUiKohHCTwPyAO5+lDiuzbV5U4ssxqTmd6jx9UPAWGw9oPUFmLa ig4XTJ5XRdla3t3J21IYSFs+RI0f5nrtz8B+8Za4Yp2f0/bBHJLZVyB2o7kuErLvHtlj K66i82UHqik9u8Mdv7PBVAtOn6uqhk1iv2qY/XgDs/8HX8TOAIFBj0DOt1z+r9MUQDw0 5X8C/5ixp0JWkSFGRBm5DGUzJ0P33hr9e5t661SMr6vK3WyDjcq6JHh4Uah0TMx1/lle MsMA== X-Gm-Message-State: ALQs6tDNpWS3F7oj0iyy0uktsVBVyoWV/EUef1NUfsHsYRnDwMsKiR14 0hnFjV0gkp9Fi4xBu7M+aDOytlw5AyE= X-Received: by 10.98.19.151 with SMTP id 23mr21028182pft.222.1525299367890; Wed, 02 May 2018 15:16:07 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id 65sm26170145pft.74.2018.05.02.15.16.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 May 2018 15:16:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 2 May 2018 15:15:48 -0700 Message-Id: <20180502221552.3873-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180502221552.3873-1-richard.henderson@linaro.org> References: <20180502221552.3873-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH v2 10/14] target/arm: Implement FP data-processing (3 source) for fp16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We missed all of the scalar fp16 fma operations. Cc: qemu-stable@nongnu.org Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) -- 2.14.3 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index d7a49ef2e4..9322b0d896 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5240,6 +5240,44 @@ static void handle_fp_3src_double(DisasContext *s, bool o0, bool o1, tcg_temp_free_i64(tcg_res); } +/* Floating-point data-processing (3 source) - half precision */ +static void handle_fp_3src_half(DisasContext *s, bool o0, bool o1, + int rd, int rn, int rm, int ra) +{ + TCGv_i32 tcg_op1, tcg_op2, tcg_op3; + TCGv_i32 tcg_res = tcg_temp_new_i32(); + TCGv_ptr fpst = get_fpstatus_ptr(true); + + tcg_op1 = read_fp_hreg(s, rn); + tcg_op2 = read_fp_hreg(s, rm); + tcg_op3 = read_fp_hreg(s, ra); + + /* These are fused multiply-add, and must be done as one + * floating point operation with no rounding between the + * multiplication and addition steps. + * NB that doing the negations here as separate steps is + * correct : an input NaN should come out with its sign bit + * flipped if it is a negated-input. + */ + if (o1 == true) { + tcg_gen_xori_i32(tcg_op3, tcg_op3, 0x8000); + } + + if (o0 != o1) { + tcg_gen_xori_i32(tcg_op1, tcg_op1, 0x8000); + } + + gen_helper_advsimd_muladdh(tcg_res, tcg_op1, tcg_op2, tcg_op3, fpst); + + write_fp_sreg(s, rd, tcg_res); + + tcg_temp_free_ptr(fpst); + tcg_temp_free_i32(tcg_op1); + tcg_temp_free_i32(tcg_op2); + tcg_temp_free_i32(tcg_op3); + tcg_temp_free_i32(tcg_res); +} + /* Floating point data-processing (3 source) * 31 30 29 28 24 23 22 21 20 16 15 14 10 9 5 4 0 * +---+---+---+-----------+------+----+------+----+------+------+------+ @@ -5269,6 +5307,16 @@ static void disas_fp_3src(DisasContext *s, uint32_t insn) } handle_fp_3src_double(s, o0, o1, rd, rn, rm, ra); break; + case 3: + if (!arm_dc_feature(s, ARM_FEATURE_V8_FP16)) { + unallocated_encoding(s); + return; + } + if (!fp_access_check(s)) { + return; + } + handle_fp_3src_half(s, o0, o1, rd, rn, rm, ra); + break; default: unallocated_encoding(s); }