From patchwork Sat May 12 00:32:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 135581 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1560688lji; Fri, 11 May 2018 17:40:30 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpy/pz9ZsxzQmbJUwHNyTRfa0H93ycMaL/J+12KWvLIaykBLm2dntTI3F9w7WmymKSHMNv+ X-Received: by 2002:ac8:28f2:: with SMTP id j47-v6mr266814qtj.150.1526085630130; Fri, 11 May 2018 17:40:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526085630; cv=none; d=google.com; s=arc-20160816; b=Cmq5d5YovCaQewLg280fvHSroZNCv9CUZntPNpvOfVf6vzo6HkJbGSAtM7ZGl67UsQ 3iQHJmhCFape3cMjbTiyYxOHgq0G3pfVRlixzuSf4vMi++3TCkH3gFUg8ouzPY5ZNV1U pBVsZLCH4sFEHfM6x49hWjbGLbQEnP2CMWZvKwI/Fsm4iefaOeXFN08Nohvna8XB2Jx3 dY1X8BCKKuadpG941Yn7d5PxvlP9rx1MTUF5DX9IJVX98Y8U3okDS77CZajrrtJgD0Jw /aUwdCajn/a8qGvJvBYYUCp1lJFB7/cFr1fKiFztzmKieXXNBgLvFv5M7eKbZvIx7N5s 6ElQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=6bdRmNY9EBI86U7FdesDXir0dyAmVZgVaLPl9qWN0QM=; b=1D4O/Brt3cxY/XLsturUpq/Wdk9c0CaLaGaMAr8ssxmQsahSpkARQbRC0i4ZqFNWEG bZw6jKL0Eh4wu4Fz5r1GAJ61S7iLwvwGPjz6ewFpWx46TvzVKuiYYie49iXUTxNgHM+Z sSdgNsspmZ89YNipp2kWs8WaJObZGFVDD8/T4dO0v0A5BYgR6ZnKWfWWq9Zd1fquBqMY FxOroelqDwvgJVIScsFAqdJ15QxGbytWIErwSiUG81W3TNL6UkWII0TI/j+90ErOvXnC pNJpmW758y1gGzoug69IfpZLJ4TmgWTKIQSq/Kpr7LCoOPmWO8+UvJP7JWDIgMvts2QW Y20Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VlTrxvVu; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id i189-v6si4134086qkd.225.2018.05.11.17.40.29 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 May 2018 17:40:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VlTrxvVu; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHIaL-0000gi-I9 for patch@linaro.org; Fri, 11 May 2018 20:40:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHISZ-00066Q-VX for qemu-devel@nongnu.org; Fri, 11 May 2018 20:32:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHISZ-00088c-9Y for qemu-devel@nongnu.org; Fri, 11 May 2018 20:32:28 -0400 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]:34158) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHISZ-00088J-4c for qemu-devel@nongnu.org; Fri, 11 May 2018 20:32:27 -0400 Received: by mail-pl0-x244.google.com with SMTP id ay10-v6so4134316plb.1 for ; Fri, 11 May 2018 17:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6bdRmNY9EBI86U7FdesDXir0dyAmVZgVaLPl9qWN0QM=; b=VlTrxvVudNqG3dOcISEJaQjvvVcGBEH/0VQ5LQHMUIFyRIo+YEdStRlizxpJMy/dDx bAgZpkZ2O4I/qDLiAi31Ra/sPPIuzjaqqhU8u2Alp5eDmhbO5tDg3nfHa3mU0wD+UvQl DaepaRFu2qZgRDc5gGSkXnsIYhqAUItGsf+9w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6bdRmNY9EBI86U7FdesDXir0dyAmVZgVaLPl9qWN0QM=; b=go9GA3Dys93vHLERYglT8deuyfeEGIyT+uExMlnWwGhBGFQNtcnb4e2Nx2sVZfJMmh 7sjRtUK9fds6WCp9rXAyTmkvLhXza9CSSQTfHxlYC67Zhd3lf/UNWmZsRN6tk9HEJzPa 9sXEVrhAxvxVgWcBw7Vxln2iWgP6xb+lUr5qhwd0oRyBvSFNhMxtS8AO9LZBAaSzuKkf Aj31wLrlmMdnaNGRYtAopEDBpwQ5sKGGNAdWO37pMSHiC0SqXveSTFX13kD16GxutvN9 7yvhZUP2YeXHWVZq2AbrczxAtV6j+hCeJT23aBdxtxgDWsFecTtTsvKSo4s6g4J5rCgu BPVw== X-Gm-Message-State: ALKqPweWpilDAG9JWh83RkdC8vD4cJMZJGR63VuzeLNk+YAVIRRpCPhK 2HHrurO7mgJqF5YRCMbuQtB2qi+p/ik= X-Received: by 2002:a17:902:a60d:: with SMTP id u13-v6mr281185plq.40.1526085145971; Fri, 11 May 2018 17:32:25 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id v186-v6sm7599735pfb.45.2018.05.11.17.32.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 17:32:25 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 17:32:10 -0700 Message-Id: <20180512003217.9105-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180512003217.9105-1-richard.henderson@linaro.org> References: <20180512003217.9105-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::244 Subject: [Qemu-devel] [PATCH v4 04/11] target/arm: Implement FCVT (scalar, fixed-point) for fp16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Cc: qemu-stable@nongnu.org Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- 2.17.0 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 93fb15d185..d0ed125442 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5697,8 +5697,21 @@ static void disas_fp_fixed_conv(DisasContext *s, uint32_t insn) bool sf = extract32(insn, 31, 1); bool itof; - if (sbit || (type > 1) - || (!sf && scale < 32)) { + if (sbit || (!sf && scale < 32)) { + unallocated_encoding(s); + return; + } + + switch (type) { + case 0: /* float32 */ + case 1: /* float64 */ + break; + case 3: /* float16 */ + if (arm_dc_feature(s, ARM_FEATURE_V8_FP16)) { + break; + } + /* fallthru */ + default: unallocated_encoding(s); return; }