From patchwork Mon May 14 15:41:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cornelia Huck X-Patchwork-Id: 135739 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1946290lji; Mon, 14 May 2018 08:47:48 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrR6N1pUUjibngUBmdm9qxR0HtaaZZS83zTHMFbexCnC4cr/NH/8aUoWgJKh7yRCoBMy3LF X-Received: by 2002:a0c:c689:: with SMTP id d9-v6mr9323517qvj.6.1526312868629; Mon, 14 May 2018 08:47:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526312868; cv=none; d=google.com; s=arc-20160816; b=GB+R6kFSBRP3jqKX24jL2OGn79b/KDfHwXAVV9wFAA8Jm8cWOJZIo5o7H9jOh1p1hV WbhO/wPTITXBaYPBu/CBSmHSwsnkkgpI58VUyQxaIM4hekKrHtJIRaD4k2Eo+wl2UmIH rXby7aGyI0y32ZTfY7Rib4ZyfyhOtO9QFFvhtxa5YZkWnYx1HdDCYSRA+VtHBDvU7r0F rVVCMZ6nG+MxF+OhtRYnMPHsiu0IT28Tafr5Qvz92K5TPotoYdgvpccWEP0y4i3R6ug7 Ewqxi5/bXXl1s9tLDGh4t28yTezuQo10iZxCBEos2tqeX7Na/wW9fSUWkPsheaC2OXg1 c9Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=qf9iKcEICVOrZSEs6kJJ/mCCwxKa0jVjoUTZtKULI4M=; b=xoqdszJHnHDFwiMkzo8jm0nh2fvBVQ/yOTdxEPlosxoaqrEWYFRZfVcVNWQ9fya2uS QElt51RrEqCYAVZwSThFVLdzH4cwJ8wXdRdPAagy5tFhxWNbF/pLlWtLELLJJYs6UiXg A7d4MtA+F/6kPgy6WyE+iuFEFPo6bY3k71IO/wrsUeDVE0prhkfYS9yUTXUT0BWYLfgQ lmDgIWD1Lk9CjIcbv7VdVO6/NH7u+8qIyEzjpxMXD8SickFflCBenkGnOgZDNK+I5kaR uErnv6UBji0uPFnbiyTV+yosHU03haSniCtyk3+782IP3m0uQgko7CE9qvZ5hatyBvy4 2d0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id w10-v6si8186764qti.119.2018.05.14.08.47.48 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 14 May 2018 08:47:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:44043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIFhU-0003vn-3V for patch@linaro.org; Mon, 14 May 2018 11:47:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIFbU-0000QJ-5N for qemu-devel@nongnu.org; Mon, 14 May 2018 11:41:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIFbQ-0007Zk-2I for qemu-devel@nongnu.org; Mon, 14 May 2018 11:41:36 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53950 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fIFbP-0007ZX-Up; Mon, 14 May 2018 11:41:32 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74D3FEFF09; Mon, 14 May 2018 15:41:31 +0000 (UTC) Received: from localhost (ovpn-117-57.ams2.redhat.com [10.36.117.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C8862026980; Mon, 14 May 2018 15:41:31 +0000 (UTC) From: Cornelia Huck To: Peter Maydell Date: Mon, 14 May 2018 17:41:14 +0200 Message-Id: <20180514154114.2558-7-cohuck@redhat.com> In-Reply-To: <20180514154114.2558-1-cohuck@redhat.com> References: <20180514154114.2558-1-cohuck@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 14 May 2018 15:41:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 14 May 2018 15:41:31 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PULL 6/6] target/s390x: Fix brace Werror with clang 6.0.0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Cornelia Huck , Richard Henderson , Alexander Graf , qemu-devel@nongnu.org, Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson The warning is target/s390x/misc_helper.c:209:21: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] SysIB sysib = { 0 }; ^ {} While the original code is correct, and technically exactly correct as per ISO C89, both GCC and Clang support plain empty set of braces as an extension. Cc: Alexander Graf Cc: David Hildenbrand Cc: Cornelia Huck Signed-off-by: Richard Henderson Message-Id: <20180512045950.12386-5-richard.henderson@linaro.org> Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- target/s390x/misc_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.3 diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c index e0b23c1fd1..1f834f35ef 100644 --- a/target/s390x/misc_helper.c +++ b/target/s390x/misc_helper.c @@ -206,7 +206,7 @@ uint32_t HELPER(stsi)(CPUS390XState *env, uint64_t a0, uint64_t r0, uint64_t r1) const MachineState *ms = MACHINE(qdev_get_machine()); uint16_t total_cpus = 0, conf_cpus = 0, reserved_cpus = 0; S390CPU *cpu = s390_env_get_cpu(env); - SysIB sysib = { 0 }; + SysIB sysib = { }; int i, cc = 0; if ((r0 & STSI_R0_FC_MASK) > STSI_R0_FC_LEVEL_3) {