From patchwork Mon May 21 10:35:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 136452 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp142349lji; Mon, 21 May 2018 03:36:44 -0700 (PDT) X-Google-Smtp-Source: AB8JxZojDMe3T+Fpc85CO/lNnKsf3/A9AKJfSdaGNQ5iTV7PV9ZgPKfVft09883J3Gz+WjG/+BsE X-Received: by 2002:ae9:e609:: with SMTP id z9-v6mr16360708qkf.38.1526899004243; Mon, 21 May 2018 03:36:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526899004; cv=none; d=google.com; s=arc-20160816; b=u5AqcCeNV5/YrF19HXelob1ho78qNKpaaBow1NpgrfKu+Li4SJg6OYClB0Bk+cEWzZ NtHFb/jksZfZELej2vzX1nWP0CYYqU+g6KS03P4VoMtY2GXZKPhzQy1PCPzI2ndPsj/8 CHrQFTgxxAs1u9Cj7ycd8EFlnRit3rEoeCNN4cBYDhDSq+gH88V6InEBiuzrzn8DqkGP u8F3WcTDiJnGeLE5xIJQJh+Z5/xwfW4bewyn3dJu/S1aZq+AIb8PGwoz5QrEudlzPVqj kw+CapXodQSc6YJuSnFcjWHDFPF0vRhuCOD8e0ze1xaLJEDGCymNC18yeanbiTP0TA2L FLiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=CIwTKMK4qchus228T/2oMGk0w0PzooyIQONrteB6LCg=; b=hvYJxQqqJPJ/WO70hYACMwjS5JxAV4FTXbvmrycwZFpx1VJ6Ty8Q6QdD99q2RmFXSF 4eWmS3FPImDYva2KJelifHAcQy1Zl51MemxtQDErW+CXcOS1cOH873hmKv2KfvEoeCfY BZ9bLiHeI/ZC15cuSdUIiwtIrmP+P4S344fmVRqXFRr0hhKRuriowhU4aRBU+yOvgOYZ ROp4d1woMBaFK0NahdMYfdlSLp7LYg+SUwiHNtlr9tY9YDDIpcMwM0PbvPfmMeHNqUWo 3lC1e34zHmNCteEQNezE/AGi9xCXWA3A2x8GANp5KMYWq32cuUMd6j7wfBtRApKF6Cob 5uhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=dbpW5ETl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id s35-v6si3020917qtc.382.2018.05.21.03.36.44 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 21 May 2018 03:36:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=dbpW5ETl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKiBH-0001pK-RF for patch@linaro.org; Mon, 21 May 2018 06:36:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKi9s-0001QH-R9 for qemu-devel@nongnu.org; Mon, 21 May 2018 06:35:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKi9o-0004cT-Th for qemu-devel@nongnu.org; Mon, 21 May 2018 06:35:16 -0400 Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:46782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKi9o-0004bJ-MQ for qemu-devel@nongnu.org; Mon, 21 May 2018 06:35:12 -0400 Received: by mail-wr0-x22c.google.com with SMTP id x9-v6so12623712wrl.13 for ; Mon, 21 May 2018 03:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CIwTKMK4qchus228T/2oMGk0w0PzooyIQONrteB6LCg=; b=dbpW5ETlgDb7lmChMZedRzSjZR7ey6hb7SK30qETEHnjQd69QE0rBq6c2ucB3XElHr r+QJg5c0fdhxuZizxN7mKMM9v1Rw59A0PCtI+zVfRflLpK5qct+O1LRBJjd5VsXTqCU/ tbP910qCRB//YX/wuoxRUKCcJjq4LVDo1ODKc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CIwTKMK4qchus228T/2oMGk0w0PzooyIQONrteB6LCg=; b=XP6Ynl+gNN8A4/JQxbjipTXJfIlzwRc/E1Yg0weDYZUq/MxbCAZNTtkg12IwhrcPps yvRkGxc1NLTHSVZeC23PVE3/+oPuDVjrfeg8xgHLBAUDW7ZBX4WLkx77NRPDjPoTTXBg eJuJ4uxj3moZbpBj3iDtg2jxUexqbKXsnZFKLy7U4/fCDLHmwKBUmFIuOr/JTRcVNxmQ LY4bs4EqHRhVa5wYh7lPNTCEB8awYuvkoKYOOvJq4W3F+76NoWAR3J/BRl6xHkLTnHIz Iuoy1KYOrCg6siOF/MibPZabAlYur0WxRWnxcdLxfKaDrS1cDHeuEucRbey1XSl4imUj 7CXg== X-Gm-Message-State: ALKqPwcCwSaeFtpiDuPt1xM86UjLXjjB7kbQja5TEkJm9T9ZLaJwATvI onFoN29nFzBtKERiSf+TaIyQvw== X-Received: by 2002:adf:ad61:: with SMTP id p88-v6mr14364931wrc.24.1526898911217; Mon, 21 May 2018 03:35:11 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id z66-v6sm13616750wme.13.2018.05.21.03.35.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 May 2018 03:35:10 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id DC9B13E01D7; Mon, 21 May 2018 11:35:09 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: famz@redhat.com Date: Mon, 21 May 2018 11:35:04 +0100 Message-Id: <20180521103504.26432-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22c Subject: [Qemu-devel] [PATCH v2] tests/docker/Makefile.include: handle empty TARGET_LIST X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" If the user doesn't specify a TARGET_LIST they get the current configuration but with spaces and hilarity ensues. This adds some make magic to turn the TARGET_LIST back into a comma separated list. Signed-off-by: Alex Bennée --- v2 - use common $(SPACE) and $(COMMA) in rules.mak --- rules.mak | 3 +++ tests/docker/Makefile.include | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) -- 2.17.0 diff --git a/rules.mak b/rules.mak index 04c7f74d07..bbb2667928 100644 --- a/rules.mak +++ b/rules.mak @@ -1,4 +1,7 @@ +# These are used when we want to do substitutions without confusing Make +NULL := +SPACE := $(NULL) # COMMA := , # Don't use implicit rules or variables diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index d00887bdf1..e911d44d9f 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -148,7 +148,7 @@ docker-run: docker-qemu-src $(if $V,,--rm) \ $(if $(DEBUG),-ti,) \ $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \ - -e TARGET_LIST=$(TARGET_LIST) \ + -e TARGET_LIST=$(subst $(SPACE),$(COMMA),$(TARGET_LIST)) \ -e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \ -e V=$V -e J=$J -e DEBUG=$(DEBUG) \ -e SHOW_ENV=$(SHOW_ENV) \