From patchwork Mon Jun 4 14:51:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 137639 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1615237lji; Mon, 4 Jun 2018 07:53:58 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ3F03JjytSJq3KvBPuYZh2gp5SDa1FKT7RPeupQHT2DkagEeImb+B6BXv7vSdQ981gxD/y X-Received: by 2002:a0c:93a2:: with SMTP id f31-v6mr20218686qvf.151.1528124038437; Mon, 04 Jun 2018 07:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528124038; cv=none; d=google.com; s=arc-20160816; b=M1iJ6NBchJ99ymPBa5mbrf2inT8nxVpy9Mo1VGIxO4x+AKx7+nxUqwv97D7/Ryfrvk oV/yV/3WTLS65w74vRFOwBN35H0KSTtGXA2lsXmMVUdEWrv86Lyf0ihx+XXBe7GPKocj 308C01tVsgOb2iaewRHfpL1Qxe6pFKobO0Wm69n56/8TrmhspZYBic2EXcyDJAU8qNva ICVgg0XoDaTNycQlqqqwA+X++qhpbeWNujSdwFW5dIHwf9X/N+5NplDgIyQ6k457/UBc nqsMjKYsWFkP2nhA6pUk03HX+Tz32FW1H7OMJElCf7a36UxtfTbSKp4YtT7FPPnhNYvT MDSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=Wwv3VN57lL4aOOZfsEtfIcl0N6vovaJBPj94KOwsJFQ=; b=YnKRnVO0T7HovJobEEpZSjoRpiXvXECsedSAKj9HfuS1YzSYmOiI5xogI63a2KE/cL JO4iXLfPLhLPhINJPbzoAO+Q0ZDGJxWEScy6qx/YbPI7S44cnvrVZflRxRo64CYPJBpQ VuWHOYsqPpJJ+8KY40qpsy1DGS1Bqc0Pc2X/1knBv7Eekc/Vgpdhk2hIIC3MZ0qv6RTo r+7uleJ9SvN7I8YbHFL4zmpQ8J89ObFjlUiKCIOoXl9zeUxZI89U4hNOaZH1qpUezEZh xyVe2mBjv3J+8YL1+J0rT68fUbyEPCCkB01YQcy7p95JxfmCwaq5FNvqcXz5rP4Gi7Qv Ygfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Y13ArJdZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id u186-v6si363768qkf.355.2018.06.04.07.53.58 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 04 Jun 2018 07:53:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Y13ArJdZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPqrt-0004bZ-Ty for patch@linaro.org; Mon, 04 Jun 2018 10:53:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPqpJ-0002nr-I1 for qemu-devel@nongnu.org; Mon, 04 Jun 2018 10:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPqpI-00040U-7g for qemu-devel@nongnu.org; Mon, 04 Jun 2018 10:51:17 -0400 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]:46379) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPqpH-0003zc-TM for qemu-devel@nongnu.org; Mon, 04 Jun 2018 10:51:16 -0400 Received: by mail-wr0-x230.google.com with SMTP id v13-v6so32615289wrp.13 for ; Mon, 04 Jun 2018 07:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wwv3VN57lL4aOOZfsEtfIcl0N6vovaJBPj94KOwsJFQ=; b=Y13ArJdZ5xcex/LK4Y2aozmvRS3T22y00BmCgBVahFJEsIzDhR9xqeLu0yHxSSnaL0 uVlu9RNdA4ilToK0jjhDtZ/iSsmaZrtmcjR81tmxEycoi/U+M1v73P4YgR9fqgJfVGdk u7Icva3j4pIpDHBqUFY6aNH0SegzE/4tlO20U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wwv3VN57lL4aOOZfsEtfIcl0N6vovaJBPj94KOwsJFQ=; b=Pa1Kk/X3VZ9/MTpsKXUdHVaEGsKw4baRX02lAMs+5QmC0QIVl9e+uCcY8O8/f7eE3H H14iy3fenc+YSF3sGDEB803jrgn7FnMvxsgIyi8gBwAtsv8CbRglSfmCXJhCWN/L9A0v 4IVttIXMlDVbQ+RYjbXO7ibN1/xahEvPJySmaDOEkkPEgUQ1/6zY5TTuf8u0d79OcbWq U+ZUsx4ywVK1B9/MQofy1+DM2sCm5Xe9oQex9Wg53KRsFk6W1Xewb2GLIj6igwfU0/di B75RcKHCBCGoQa8r4NrtQSIweLNUIgg2MVTr0DC2Sus6RsQvYurITrTqYeVwPb0seCf3 nYpQ== X-Gm-Message-State: ALKqPweEqQ3UQ9SvBImEkWbYT0mK1caG+WSMzI5ITZHyqbCzMky20j7L TfT7zQgAbDqWNcvKbii+X0oxQA== X-Received: by 2002:adf:be09:: with SMTP id n9-v6mr17419530wrh.267.1528123874725; Mon, 04 Jun 2018 07:51:14 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id e14-v6sm409965wmh.17.2018.06.04.07.51.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 07:51:11 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 5C7E53E09FC; Mon, 4 Jun 2018 15:51:09 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de, pbonzini@redhat.com, stefanha@redhat.com, stefanb@linux.vnet.ibm.com, marcandre.lureau@redhat.com Date: Mon, 4 Jun 2018 15:51:05 +0100 Message-Id: <20180604145109.30498-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180604145109.30498-1-alex.bennee@linaro.org> References: <20180604145109.30498-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::230 Subject: [Qemu-devel] [PATCH v1 3/7] Makefile: Rename TARGET_DIRS to TARGET_LIST X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Fam Zheng To be more accurate on its purpose and make code that looks for a certain target out of this variable more readable. Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- Makefile | 20 ++++++++++---------- configure | 2 +- scripts/create_config | 2 +- tests/Makefile.include | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-) -- 2.17.0 diff --git a/Makefile b/Makefile index 6d588d1f71..023b3437ec 100644 --- a/Makefile +++ b/Makefile @@ -62,8 +62,8 @@ seems to have been used for an in-tree build. You can fix this by running \ endif endif -CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_DIRS)),y) -CONFIG_USER_ONLY := $(if $(filter %-user,$(TARGET_DIRS)),y) +CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_LIST)),y) +CONFIG_USER_ONLY := $(if $(filter %-user,$(TARGET_LIST)),y) CONFIG_XEN := $(CONFIG_XEN_BACKEND) CONFIG_ALL=y -include config-all-devices.mak @@ -366,8 +366,8 @@ DOCS= endif SUBDIR_MAKEFLAGS=$(if $(V),,--no-print-directory --quiet) BUILD_DIR=$(BUILD_DIR) -SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS)) -SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %-config-devices.mak.d, $(TARGET_DIRS)) +SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_LIST)) +SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %-config-devices.mak.d, $(TARGET_LIST)) ifeq ($(SUBDIR_DEVICES_MAK),) config-all-devices.mak: @@ -470,7 +470,7 @@ config-host.h-timestamp: config-host.mak qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$@") -SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) +SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_LIST)) SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES)) $(SOFTMMU_SUBDIR_RULES): $(block-obj-y) @@ -514,7 +514,7 @@ ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS)) romsubdir-%: $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pc-bios/$* V="$(V)" TARGET_DIR="$*/" CFLAGS="$(filter -O% -g%,$(CFLAGS))",) -ALL_SUBDIRS=$(TARGET_DIRS) $(patsubst %,pc-bios/%, $(ROMS)) +ALL_SUBDIRS=$(TARGET_LIST) $(patsubst %,pc-bios/%, $(ROMS)) recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES) @@ -772,7 +772,7 @@ distclean: clean rm -f docs/interop/qemu-qmp-ref.pdf docs/interop/qemu-ga-ref.pdf rm -f docs/interop/qemu-qmp-ref.html docs/interop/qemu-ga-ref.html rm -f docs/qemu-block-drivers.7 - for d in $(TARGET_DIRS); do \ + for d in $(TARGET_LIST); do \ rm -rf $$d || exit 1 ; \ done rm -Rf .sdk @@ -873,7 +873,7 @@ endif $(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \ done $(INSTALL_DATA) $(BUILD_DIR)/trace-events-all "$(DESTDIR)$(qemu_datadir)/trace-events-all" - for d in $(TARGET_DIRS); do \ + for d in $(TARGET_LIST); do \ $(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \ done @@ -1071,9 +1071,9 @@ endif @echo ' ctags/TAGS - Generate tags file for editors' @echo ' cscope - Generate cscope index' @echo '' - @$(if $(TARGET_DIRS), \ + @$(if $(TARGET_LIST), \ echo 'Architecture specific targets:'; \ - $(foreach t, $(TARGET_DIRS), \ + $(foreach t, $(TARGET_LIST), \ printf " %-30s - Build for %s\\n" $(patsubst %,subdir-%,$(t)) $(t);) \ echo '') @echo 'Cleaning targets:' diff --git a/configure b/configure index 2e10956cfc..a08544dd6e 100755 --- a/configure +++ b/configure @@ -6122,7 +6122,7 @@ qemu_version=$(head $source_path/VERSION) echo "VERSION=$qemu_version" >>$config_host_mak echo "PKGVERSION=$pkgversion" >>$config_host_mak echo "SRC_PATH=$source_path" >> $config_host_mak -echo "TARGET_DIRS=$target_list" >> $config_host_mak +echo "TARGET_LIST=$target_list" >> $config_host_mak if [ "$docs" = "yes" ] ; then echo "BUILD_DOCS=yes" >> $config_host_mak fi diff --git a/scripts/create_config b/scripts/create_config index d727e5e36e..58948a67a4 100755 --- a/scripts/create_config +++ b/scripts/create_config @@ -107,7 +107,7 @@ case $line in target_name=${line#*=} echo "#define TARGET_NAME \"$target_name\"" ;; - TARGET_DIRS=*) + TARGET_LIST=*) # do nothing ;; TARGET_*=y) # configuration diff --git a/tests/Makefile.include b/tests/Makefile.include index 3b9a5e31a2..3d2f0458ab 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -854,7 +854,7 @@ endif # QTest rules -TARGETS=$(patsubst %-softmmu,%, $(filter %-softmmu,$(TARGET_DIRS))) +TARGETS=$(patsubst %-softmmu,%, $(filter %-softmmu,$(TARGET_LIST))) ifeq ($(CONFIG_POSIX),y) QTEST_TARGETS = $(TARGETS) check-qtest-y=$(foreach TARGET,$(TARGETS), $(check-qtest-$(TARGET)-y))