From patchwork Mon Jul 2 13:57:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stafford Horne X-Patchwork-Id: 140752 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp4029690ljj; Mon, 2 Jul 2018 06:58:42 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcbN5NBYG9SYg1m0EMXf2DFUsQIr95fgHGMYrGOEw6hq8yngZ/3T4txcb+wVlsdx1cbolnY X-Received: by 2002:a0c:86f3:: with SMTP id 48-v6mr22293322qvg.165.1530539921934; Mon, 02 Jul 2018 06:58:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530539921; cv=none; d=google.com; s=arc-20160816; b=NWQHkSzckoClDQi/iBYdHyZBsFV7fEhbzvNJlBeA2vJemJ1pv19djnuwen3V/toBW+ G2JfCkj1dX4VA30Mc86xCB2Gj5tbIKRS+zrwFgffmIZEuxhV+pdl0BJP72eYB5yOJfWk 6tJ1xu7fzyMTMZrypkB3pF7j2QVbi/ZRzeNrPY+6SaB+4flImSV7e82nSmvGxsqpFXX2 bGQy/iYdaJHsqWEFaZCQ+nUm+AQU+A4i0resu01Dqz7CJS5/E4z9Vc4aPDbKMqasEhlx nEEXBSnNgYnmr5zZhkKP/RO97VmPs77b5ma5cxUlNDilzSd49T+BfbK3uutupREQrzKx NRtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=4kKcrKeV9F/Qdu736T7k95sF9L6dvtl4xdV9jCWRIzA=; b=CsnSRtnSPLe9JqzUJywDVZNxpzJuePb7/sBjZpRepTNKTBujVRmlOhGgHUeG1IEs22 xeQPXClrsd8TnL4C7H0oUoxaNiz3a3S7Np86wDCVdkrRKIE5i43KMh/0GvLWDy3FLjTS 9jJGV73fm28l92legMsTWqBXnA/xV7WYwTEVoVuO9+U6yI/GWXkI9ThzOrP7dOP23/DY CjooM0sLrO3DFFQ2JtIvV/rEzWDt5Ll2HGOf8GKXm4TA6ZjQd0VuigOClH9IRm2dvA3s FlYdql0pr1gF2HnGAtikRLrIWqxmWOLI+Ay+0rbRi2xDzTz4h0882arSnp6iVPNi1m00 93mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=GVuIY9nF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id l1-v6si532807qkk.184.2018.07.02.06.58.41 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 02 Jul 2018 06:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=GVuIY9nF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1]:32935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZzLl-00027f-6Q for patch@linaro.org; Mon, 02 Jul 2018 09:58:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZzLN-00026O-Cw for qemu-devel@nongnu.org; Mon, 02 Jul 2018 09:58:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZzLM-0007nJ-G7 for qemu-devel@nongnu.org; Mon, 02 Jul 2018 09:58:17 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:46152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZzLM-0007mu-9y for qemu-devel@nongnu.org; Mon, 02 Jul 2018 09:58:16 -0400 Received: by mail-pg0-x244.google.com with SMTP id q14-v6so7184234pgt.13 for ; Mon, 02 Jul 2018 06:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4kKcrKeV9F/Qdu736T7k95sF9L6dvtl4xdV9jCWRIzA=; b=GVuIY9nFnjgt+PYqZRXdZM4SkeqhxyiF19y304CCy5XfKz6vjQEbBhp+iJXY+BNJtV RSeFPoVEBEYZWWsEkrQdX4E7mABVqyIpcNGucPM2sLkmzuVaP/Gl2Z6uX0C0A6MsQngs LSZvrV+JMeNKm3iY+A01wS5sEpHISnH7KIlfG1Medzsa16jGawRRVcru/E8woONT76rm dogaQM4dRyJMbonwC2y/Oyto6fAqWBFe6QANnVzJTc1JYYR/Fb0XzHk3dfnh3pFqXKe9 QU/a+vnoVBC4cJNBym3kfUavxbnCW+BR33razyv2QVCDailvAkaROJWlNNm4V7M594N+ 74LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4kKcrKeV9F/Qdu736T7k95sF9L6dvtl4xdV9jCWRIzA=; b=Y9ifKv+qTDduOWMOP/Nt9F8uWK+w7fQ3ycyvm3y3tu4/lX5hsPrJu1OTkT47hC+b6j Q7nexBCXPIOWv/J84WTS9OJci3Aew7yTlx4f4KqxnN+/HsEZ0PfkFCiMR1x/d6vM3cby 0HK7oNEvysgK6t2aro96bjFKKUrzqbJ040i88uJWjGN5n6lo5uy3LojzjWxjANKjHE7W Wwk2RRnZdrmUcf+S7aTPYClt5hM1DIQ5C9mUARFa8OkGh7akKsr05LwpX+C7NaFKISnR IYwoy8m/14KdXC9lfOgkerh4I0mIIwJ6qVw6gb629SZj1C+22whU9xsry26JvQ9yZ3vB qvWQ== X-Gm-Message-State: APt69E0dd4gnMUA50+N1cWvGmCwZZYdh5BnOYe/IpFLgIcCxPdsrjy2M o6ESa6zCrGN5t1gGKTW1lpU= X-Received: by 2002:aa7:8004:: with SMTP id j4-v6mr25343025pfi.174.1530539895309; Mon, 02 Jul 2018 06:58:15 -0700 (PDT) Received: from localhost (g90.124-44-6.ppp.wakwak.ne.jp. [124.44.6.90]) by smtp.gmail.com with ESMTPSA id q9-v6sm23098124pgv.84.2018.07.02.06.58.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jul 2018 06:58:14 -0700 (PDT) From: Stafford Horne To: Peter Maydell Date: Mon, 2 Jul 2018 22:57:42 +0900 Message-Id: <20180702135806.7087-2-shorne@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180702135806.7087-1-shorne@gmail.com> References: <20180702135806.7087-1-shorne@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PULL 01/25] target/openrisc: Fix mtspr shadow gprs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stafford Horne , Richard Henderson , QEMU Development Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Missing break when this feature was added in 89e71e873d ("target/openrisc: implement shadow registers"). This was causing strange issues as we get writes into the translation block jump cache and other bits of state. Fixes: 89e71e873d ("target/openrisc: implement shadow registers") Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Signed-off-by: Stafford Horne --- target/openrisc/sys_helper.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.0 diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c index b284064381..2f337363ec 100644 --- a/target/openrisc/sys_helper.c +++ b/target/openrisc/sys_helper.c @@ -98,6 +98,7 @@ void HELPER(mtspr)(CPUOpenRISCState *env, case TO_SPR(0, 1024) ... TO_SPR(0, 1024 + (16 * 32)): /* Shadow GPRs */ idx = (spr - 1024); env->shadow_gpr[idx / 32][idx % 32] = rb; + break; case TO_SPR(1, 512) ... TO_SPR(1, 512+DTLB_SIZE-1): /* DTLBW0MR 0-127 */ idx = spr - TO_SPR(1, 512);