From patchwork Tue Jul 24 10:51:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 142757 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp7118591ljj; Tue, 24 Jul 2018 03:57:17 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdZcZFtUyw3Wq2S2Oc1frfAqR/fW9D+xKNw4+4iZF+u6b5Gllw83r2XlG/oQE0XxLsf8rRC X-Received: by 2002:ac8:855:: with SMTP id x21-v6mr15730364qth.42.1532429837322; Tue, 24 Jul 2018 03:57:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532429837; cv=none; d=google.com; s=arc-20160816; b=a4LXKb3BvEHB6n/dAF2PBDNeclTQ7PE90gKiZahlhnN12RIlFIGLhbaXqpirQFBYw8 L3Gd0gSMQ+k+v59ISwO59fyAyi9Qi4ajSObe4BAygb2uSRcrPyDC3irTyb8Q+qLPtE76 2+CUkqasUBmxpYGAgG8k7tVYXhEa3DXZTzZyEz8qDSjcl1wLg1xbxsJt1WSNEvCqEIJB hmNtmJzcNSLQ38dxlG5nk5I0nl6DaSswhS6NPof2vJ/wT8OdCGdSlEQhzlk5xT+1Rtcb uZcqkp5xLTAP27J+AK5iquR89IBjaa2UwPXg51i6aCJIkpT3NkIzwdCZR/eKRtAb/Jqy XACQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=KhFmSjfE9J0zu8fVzdh85dmgmRF8QtVjlHDWe9pssY4=; b=nm2knkIUCv5kAolCX2VoZxAn8KNQpJ9cUYGRKdqahQBAilnvN0laymgGDOnlA1+BUD 6c6K4WbqQEMDUDmf/pawQux40hiogcFm7LVlSfCbFCV+nAhM2F7zj04wP7sacEmDD/W8 TRktugI3GSVRVxZ/qU3wNpnuEGHg3FOxQwVLncqD2dg9hV9GcReJLltamrEhlJnx2AEC W7JpxWzfx2ivE1b+eDQQCFaZ8X6nqZdXkQCNFXwgnxLOIrIeihUcgb0UV2TxeMhYDE/m lW7a0Nvo8a9wC32sOBl/iE03B98QIkaCq+5I61rqY9/8TMJCNRsBA1j9rZuJ+KaWMRmY ba/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="C0/t3BMX"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y15-v6si6615447qto.192.2018.07.24.03.57.17 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 24 Jul 2018 03:57:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="C0/t3BMX"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhv0G-0005xr-R4 for patch@linaro.org; Tue, 24 Jul 2018 06:57:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhuua-0000wd-0W for qemu-devel@nongnu.org; Tue, 24 Jul 2018 06:51:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhuuZ-0006XR-7t for qemu-devel@nongnu.org; Tue, 24 Jul 2018 06:51:24 -0400 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:40559) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhuuZ-0006Wq-1Q for qemu-devel@nongnu.org; Tue, 24 Jul 2018 06:51:23 -0400 Received: by mail-wm0-x236.google.com with SMTP id y9-v6so1229788wma.5 for ; Tue, 24 Jul 2018 03:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KhFmSjfE9J0zu8fVzdh85dmgmRF8QtVjlHDWe9pssY4=; b=C0/t3BMX7hr36nVRKCwAoITJ7Cw2XSoavHmiHbaiR4hrU2A2nrlQkkF8/Iyu4W3nSd ad7jNcOfyKvtF8KkPMiOMrVvuYeS+sQqbQ40xPGhftIi9BRAcviLbl3yJMmXzvvOcvJU OOihb6M5brsIoI4jeY/kgi4csj/pCF0L489/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KhFmSjfE9J0zu8fVzdh85dmgmRF8QtVjlHDWe9pssY4=; b=PzPwGRtGvNcxkKFItZn8JkV09AFvyMz/1hoMcy8QBt//eoI4jz8wYP1xK0Fouxvz7p HztCHdugrq4Fkn1d08bWJNhEoRCy55YoVAoUKHYt7xDXHz+SvwzDV8xaawBG5VG8rane r0Cj2w59jz/nmdqKtezn7YoiK1pmddLSIli2B253XU+rnEcSmlNsxX6E03AlRONAGu6v j3+dJcQcxfiqndbbL1ruM5n6/xULyVRFw4W7e2vuOHDaTp16VUeSaMmpy9f5uLMqDkov TNa1GE4azTUmj6318md3ZhvyF8YxGbo0Jd8PjLZ0quIqX2kB/HFnLV746bCXCLEiHVXc C3YA== X-Gm-Message-State: AOUpUlGuGo58NWzTOui8WJX6xVkE8zcst9gklbf7sgN5wYHCH3i/B7km x2MLYAKiVEpdOqarGlLwa7mDng== X-Received: by 2002:a1c:af53:: with SMTP id y80-v6mr1526034wme.55.1532429481841; Tue, 24 Jul 2018 03:51:21 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id i205-v6sm2469165wmf.30.2018.07.24.03.51.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jul 2018 03:51:17 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id CA77B3E06D2; Tue, 24 Jul 2018 11:51:10 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Tue, 24 Jul 2018 11:51:04 +0100 Message-Id: <20180724105109.8392-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180724105109.8392-1-alex.bennee@linaro.org> References: <20180724105109.8392-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::236 Subject: [Qemu-devel] [PULL 12/17] docker: report hint when docker.py check fails X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" When a check fails we currently just report why we failed. This is not totally helpful to people who want to boot-strap a new image. Report a hint as to why it failed. Signed-off-by: Alex Bennée Suggested-by: Fam Zheng -- 2.17.1 diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 05afeb64a7..1aaa795743 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -73,7 +73,8 @@ docker-binfmt-image-debian-%: $(DOCKER_FILES_DIR)/debian-bootstrap.docker $(if $(EXECUTABLE),--include-executable=$(EXECUTABLE)), \ "BUILD","binfmt debian-$* (debootstrapped)"), \ $(call quiet-command, \ - $(DOCKER_SCRIPT) check --quiet qemu:debian-$* $<, \ + $(DOCKER_SCRIPT) check --quiet qemu:debian-$* $< || \ + { echo "You will need to build $(EXECUTABLE)"; exit 1;},\ "CHECK", "debian-$* exists")) endif