From patchwork Sat Aug 18 19:01:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 144498 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2202560ljj; Sat, 18 Aug 2018 12:04:53 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzelw6w9mizvM1xYswGmeFqHfZyTbSZ8GwSPUAVwW+kptMMajoJ5JgEI/eDCK0XyaxIi5Rq X-Received: by 2002:a0c:ae17:: with SMTP id y23-v6mr35920147qvc.157.1534619093806; Sat, 18 Aug 2018 12:04:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534619093; cv=none; d=google.com; s=arc-20160816; b=V4QChO6HbOI+u+5Z2t9W4qzHIqw8RZYHTWAxjAJFtl8gfmv8CYqk2BleET8UqT0AsH NaFArTfRQfabIb4h4Txt9Iuxm62uyLfnKe12YY+w6WH4TCJm9LJkhvzQ1DTuXfUdt36X aIjoH5hJcSmY18At/TaERkP9UUC6K7w7B2Mfkija08qj+bFmiHm4YDJMHTnBy/S2Tjgo sYZ6U8B/3ZD78WyISz+MK0DTMJaaF9AcerHIN0mlc0CBsxMPVSFJPMHSmis7aQgCP/16 qtHQI3ohg7T/yYSJaD118RMrXs0q/hhSrsgYfI4s0gXCpooF7emPeT3LVjS6kwgHpUDC NtIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=/z/eefPCgelx7VlOuM901aOQ7q13A+VhuXBDmblU9Gw=; b=y7clX50OaErWF9oW8JM0fzqYlwa0MZUrrOROg6oWb7FhnA8QFn9yix7rDcMEs/2V0w 0EhqayGafh49xB35GovUcZGv2mlhn/qXFeu89rlAzB9FjpQkjnXteKzWHZ5uYFh5eJ3v HTmhuKKLobxXfnBMl8LXQFcMUXNHFApJDnjD7HiKKY6oC3zIvuw6u01R9c9eL/pR9zxe DsdcDSsVE7PHMJO1YwU9fod40g+mRkOQdKLVC43CXmNFdZf4bIP2dgld2T5ISYLzYbX6 soW1fAMULPyKIX57pNQGZstMOp0qHggzWn/PXIPc+sfjXH0uQF1giBSDuf2i7l3fr437 F0nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hYfYItMr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id m67-v6si102567qkf.278.2018.08.18.12.04.53 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 18 Aug 2018 12:04:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hYfYItMr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40125 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fr6Wr-0006Pa-5v for patch@linaro.org; Sat, 18 Aug 2018 15:04:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fr6TX-0005Em-Re for qemu-devel@nongnu.org; Sat, 18 Aug 2018 15:01:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fr6TT-000746-GT for qemu-devel@nongnu.org; Sat, 18 Aug 2018 15:01:27 -0400 Received: from mail-pl0-x230.google.com ([2607:f8b0:400e:c01::230]:46170) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fr6TT-00073a-3l for qemu-devel@nongnu.org; Sat, 18 Aug 2018 15:01:23 -0400 Received: by mail-pl0-x230.google.com with SMTP id a4-v6so1668500plm.13 for ; Sat, 18 Aug 2018 12:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/z/eefPCgelx7VlOuM901aOQ7q13A+VhuXBDmblU9Gw=; b=hYfYItMr0QXzZqQNY76/gO5fJXaD+323D4iNkjWRo2wSMfPAp5EouckekVMqVRk72U +assA7W8LFNLlz54oS13eXQQJ3tZ3aymTkph87+uko1RQKGXAOY7TPFDiAdVBq+THAvo 0ipBydlHDwD20tg4d7iw72G+QKVzuqbnz5xC8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/z/eefPCgelx7VlOuM901aOQ7q13A+VhuXBDmblU9Gw=; b=pgML8n4oUSUtAPksp9Gy+WIeIVHUwTR88NlBhz3eYjGnZde3I6v0AR8wkGsVMuh9bY sfZLdudy6+Jbcvd/3CAQzUkgawzXTcShzapom4a5faqrGf/c+84gsHPU3LsmZ9KPk1r4 CqXOzpmvglQrNxwqS1SnW89I8o1la6NdBsB7B+YkBjuinfPqcdeN9gmf3o7oSbYekQhR p4us0+AkPAUdRbXNUYNkx41PffAFnt14TNSn4ahOUxSCwXmFKOQ6D2TjTSaz00b4ognX m2aki2SBxDGFeHp2W5dBcVebL7wWdKoC4vueWFbJXqAyF0mSjqaMAi5QF93YSCsdPOxo 8dpg== X-Gm-Message-State: AOUpUlHnUwwuX2oTdWYlk7wRJqSY4HX3PSAtAt4hAQFj9FzWHLSjam8f m6kcXN7nEHT8P7EcjS/TXGu5A1u2I2Q= X-Received: by 2002:a17:902:32a4:: with SMTP id z33-v6mr38862408plb.226.1534618881878; Sat, 18 Aug 2018 12:01:21 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-8-179.tukw.qwest.net. [97.113.8.179]) by smtp.gmail.com with ESMTPSA id q85-v6sm9362783pfa.151.2018.08.18.12.01.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Aug 2018 12:01:20 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sat, 18 Aug 2018 12:01:03 -0700 Message-Id: <20180818190118.12911-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180818190118.12911-1-richard.henderson@linaro.org> References: <20180818190118.12911-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::230 Subject: [Qemu-devel] [PATCH v4 01/16] linux-user: Remove DEBUG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This is redundant with both -strace and actual tracing. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/syscall.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.17.1 diff --git a/linux-user/syscall.c b/linux-user/syscall.c index bb42a225eb..6cd9b33a0d 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -163,7 +163,6 @@ * (The one remaining unallocated bit is 0x1000 which used to be CLONE_PID.) */ -//#define DEBUG /* Define DEBUG_ERESTARTSYS to force every syscall to be restarted * once. This exercises the codepaths for restart. */ @@ -5778,9 +5777,6 @@ static abi_long do_ioctl(int fd, int cmd, abi_long arg) ie++; } arg_type = ie->arg_type; -#if defined(DEBUG) - gemu_log("ioctl: cmd=0x%04lx (%s)\n", (long)cmd, ie->name); -#endif if (ie->do_ioctl) { return ie->do_ioctl(ie, buf_temp, fd, cmd, arg); } else if (!ie->host_cmd) { @@ -8026,9 +8022,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, } #endif -#ifdef DEBUG - gemu_log("syscall %d", num); -#endif trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8); if(do_strace) print_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6); @@ -12843,9 +12836,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, break; } fail: -#ifdef DEBUG - gemu_log(" = " TARGET_ABI_FMT_ld "\n", ret); -#endif if(do_strace) print_syscall_ret(num, ret); trace_guest_user_syscall_ret(cpu, num, ret);