From patchwork Wed Oct 31 12:21:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 149784 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp6720736ljp; Wed, 31 Oct 2018 05:22:20 -0700 (PDT) X-Google-Smtp-Source: AJdET5cIo/+VJbvAri38FlNhBoZxwyK1PsGA8sbHA2Oy19CsE1OwiruhVa3TWx6/l15b7csMpyY+ X-Received: by 2002:ac8:4787:: with SMTP id k7-v6mr2365861qtq.191.1540988540327; Wed, 31 Oct 2018 05:22:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540988540; cv=none; d=google.com; s=arc-20160816; b=icrXRn4Xbpk+PAm7hr+iKvtMdWl/sOGiOXdVRPJjro346Gzfu+fs2P66vRMk3Av+HR cyO6gbNvfN1NKGV6JlB6G37HVhNr1V69Lr/1gtMCVWhtuG2qFRbf6Hwq8SCGnzXiA34d p/TdYktboC8fBxeNHBDB+ZFV3PZR6BSAKyYJiWiu65sN3+zbxTp6xYKZWjqlgrggflAK ScgO3YDMkO+Ho8jTR6aYUPTlWbIuG1ANPVE1EGCpIXoBooO2yaXg0mHJm9eRCRQCaV+w S0N2yfopFVGxEtoovTgt6v5TvmW/yFEe4d/oJ8wzmXsJsZLv+grNUQbiQZ2oakvAzygQ I05g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=L+zxn4yIHHZ24UshW3jspOhWt1yPjQcT0llFQ6cVKMs=; b=ki7yWGZyWYk+Y9CxDHIroaJ5m3ocF4ZJ/QuQicjboz3IvY43iO5JX1bzBYFv33d1cc EbpLKWjrkFBpmrnBjmUl+cfDNl3DnyyKiYYnZoIoVEOsASK1WXMAxQ6hXAu9zF5UT7jn 8bG1bYDyAWg3Ttgai0oao6+7jYxb1Naa3cVgDofGbzWQFzhpl/V4Id/niFEnZQ8tf+Rf cvKZD2Z93pxTYKT2iPZTdw1uCBbVPJvKDczN1FfFOHfzTywXjvCSs9G3DRMuSqHIXWM1 PSo3L0TvNu0ljlAiRgBUv1OgwMLNXA8jhRDeoTCp+DK4UoEBmmERhuOIyxIg8ZefqDDq 9FSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VWAf+40l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id k190-v6si4971006qkd.243.2018.10.31.05.22.20 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 31 Oct 2018 05:22:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VWAf+40l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHpVr-0000i6-O0 for patch@linaro.org; Wed, 31 Oct 2018 08:22:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHpVT-0000gj-Hp for qemu-devel@nongnu.org; Wed, 31 Oct 2018 08:21:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHpVP-0001cd-IV for qemu-devel@nongnu.org; Wed, 31 Oct 2018 08:21:54 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:44959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHpVM-00018Z-HX for qemu-devel@nongnu.org; Wed, 31 Oct 2018 08:21:50 -0400 Received: by mail-wr1-x429.google.com with SMTP id d17-v6so15938843wre.11 for ; Wed, 31 Oct 2018 05:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=L+zxn4yIHHZ24UshW3jspOhWt1yPjQcT0llFQ6cVKMs=; b=VWAf+40lppjHftk5fD8ZzS44ok2ch0K5L0wMO/h11cDnP8ScvpMsYm51k+W9MdVzPD Hsctf/ppJjuOhD9wGZmKbj7Um+aR3dUCySUY+jYmw2Nh+IbTxXI7kgsIHhcEaNeOY3pq 3tTVfuPV3kBzbLsDr5nqNzL/2mBt/UtsvCQ5E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=L+zxn4yIHHZ24UshW3jspOhWt1yPjQcT0llFQ6cVKMs=; b=cPAOsxu9rnGhGuUlnB9gjJDkx99H8lvzkpUTYTXdZycFwh3MsTXHF/1Uk6IXhBC7eL TjvjzXU8M/kg1wQw0g0ZO3GXy9NPwnheuf8xtfWTFeYHC7KXQ2bwgG41cvdWQHAzFSXb fltBcuW4Qm+Yr69MncGolJ7nM1Xqadtkfxn++mFwU2t0kWfOqsqhZX4zU2NMtT81wBAR vyhgUxkbnegNJZi/rWkUdyf3rVX4B2hdbj2Rk5rUhOn5EZ48ZoQErYAbvuL5jOtAGj8B XZCcCpXUEyM6ZfxvHalMLb/WxznLqcPfRXtjFFWRFwyAidp3mUROTArvM2rrykq3+CnJ jodA== X-Gm-Message-State: AGRZ1gK9dnUUpocMtjBzz+z1PB6uxjTM2nukuc/NTBvCnffThsGXOhcH LQUvgV3IQ7/NycrgfqDK7y/AiUlE/24= X-Received: by 2002:a5d:47d2:: with SMTP id l18-v6mr2814470wrs.319.1540988482473; Wed, 31 Oct 2018 05:21:22 -0700 (PDT) Received: from cloudburst.twiddle.net.lan (79-69-241-110.dynamic.dsl.as9105.com. [79.69.241.110]) by smtp.gmail.com with ESMTPSA id v2-v6sm13450362wru.17.2018.10.31.05.21.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Oct 2018 05:21:21 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 31 Oct 2018 12:21:11 +0000 Message-Id: <20181031122119.1669-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181031122119.1669-1-richard.henderson@linaro.org> References: <20181031122119.1669-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::429 Subject: [Qemu-devel] [PULL 02/10] cputlb: Remove tcg_enabled hack from tlb_flush_nocheck X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The bugs this was working around were fixed with commits 022d6378c7fd target/unicore32: remove tlb_flush from uc32_init_fn 6e11beecfde0 target/alpha: remove tlb_flush from alpha_cpu_initfn Tested-by: Emilio G. Cota Reviewed-by: Emilio G. Cota Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 7 ------- 1 file changed, 7 deletions(-) -- 2.17.2 diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index d4e07056be..d080769c83 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -122,13 +122,6 @@ static void tlb_flush_nocheck(CPUState *cpu) { CPUArchState *env = cpu->env_ptr; - /* The QOM tests will trigger tlb_flushes without setting up TCG - * so we bug out here in that case. - */ - if (!tcg_enabled()) { - return; - } - assert_cpu_is_self(cpu); atomic_set(&env->tlb_flush_count, env->tlb_flush_count + 1); tlb_debug("(count: %zu)\n", tlb_flush_count());