diff mbox series

[v2,4/6] tests/guest-debug: fix scoping of failcount

Message ID 20181108163329.19940-5-alex.bennee@linaro.org
State Superseded
Headers show
Series KVM Guest Debug fixes (plus TCG EL2 debug tweaks) | expand

Commit Message

Alex Bennée Nov. 8, 2018, 4:33 p.m. UTC 
You should declare you are using a global version of a variable before
you attempt to modify it in a function.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

---
 tests/guest-debug/test-gdbstub.py | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

Comments

Richard Henderson Nov. 8, 2018, 5:14 p.m. UTC | #1 
On 11/8/18 5:33 PM, Alex Bennée wrote:
> @@ -16,6 +16,7 @@ def report(cond, msg):

>          print ("PASS: %s" % (msg))

>      else:

>          print ("FAIL: %s" % (msg))

> +        global failcount

>          failcount += 1


Do we usually prefer such declarations at the start of the function?
Anyway,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>



r~
diff mbox series

Patch

diff --git a/tests/guest-debug/test-gdbstub.py b/tests/guest-debug/test-gdbstub.py
index 0e4ac01426..c7e3986a24 100644
--- a/tests/guest-debug/test-gdbstub.py
+++ b/tests/guest-debug/test-gdbstub.py
@@ -16,6 +16,7 @@  def report(cond, msg):
         print ("PASS: %s" % (msg))
     else:
         print ("FAIL: %s" % (msg))
+        global failcount
         failcount += 1