From patchwork Fri Nov 23 14:45:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 151907 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2239194ljp; Fri, 23 Nov 2018 07:11:17 -0800 (PST) X-Google-Smtp-Source: AFSGD/Uhv3e+yfsF+n3IxzGUSPyS7kf8cRIRPXSqhBLHbG5TlvsKqWqDURoO8M5W4NOKMrPrSi2i X-Received: by 2002:a25:5e83:: with SMTP id s125-v6mr13498399ybb.368.1542985877095; Fri, 23 Nov 2018 07:11:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542985877; cv=none; d=google.com; s=arc-20160816; b=Dp1Jc6YodccEOMAbpJvWAMqtqIvQiq1zPaiE3QfD1EopAJnmH4JGyn3eDRFVhFTMsj Vso5RpNx5//VjOmMzN1oexYb3Ckr/qk2x/b2PC4Lj0tDhIfo7FytBOpqmyGQLxpj5Iq5 A3hY1f8mN0qieMJYPgEDCJpR+Lr/fVAN2mxmRKRhRwyvktQWMmVmI8LFQRukf8TwFkAC uAoEdxN24BiUZtAOigbHhDoM6lqRGl0YZOUazRd60acI/ANioCMZgsyEBgI4A6xyb46f KT2fzQH/PZLNstHiwVKDUURR1si0OkwNkwFNr7IqNCnP8YTB0KF9+xBlfrk3n5W/vy62 qVAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=ZdFhnUufyrFc19z7ViZt8Wb0ZHqiPUdjffxN+QTai+8=; b=edwgF71ncNsnvEI6obzXYVfRDYjnbyBZcPhu6ff/AS48jEbiTemHoZ+0/GHTknCoIr WKJxRvfTTZk5MC/b9UbsYyDY0CpnxpsTGhgU6KnRwd5DxaPYyHYrp4TQvfipAtTP+B6K gDfZoC8xxHxN05vn7o0Pz/Gb77De4P9hZuDSWfD51Hv8o4ELJnxsaccZCvskCrYBxLjI q9iRkVsdXtcRA57ItSi4EGL7YIcFMH+bjdC/kvS4CinSB4NEyxEYlI6vcl/btvGN7Y3e ffloQB5S/o7VwVatjZ1CGLgYt8YR1p89/KrKUaU8/XEPfz2QmkmxwpjdocyQX2urtFuY elyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UgW6PcqB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id w13-v6si32503412ybq.295.2018.11.23.07.11.16 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 23 Nov 2018 07:11:17 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=UgW6PcqB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52898 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQD6y-0007qg-B1 for patch@linaro.org; Fri, 23 Nov 2018 10:11:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQCj1-0000EG-N4 for qemu-devel@nongnu.org; Fri, 23 Nov 2018 09:46:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQCiz-0003dI-LV for qemu-devel@nongnu.org; Fri, 23 Nov 2018 09:46:31 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:36617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQCix-0003Xv-Tq for qemu-devel@nongnu.org; Fri, 23 Nov 2018 09:46:28 -0500 Received: by mail-wr1-x444.google.com with SMTP id t3so12596316wrr.3 for ; Fri, 23 Nov 2018 06:46:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZdFhnUufyrFc19z7ViZt8Wb0ZHqiPUdjffxN+QTai+8=; b=UgW6PcqBB672fPuaTI6tXxmd0dUqN7wFdvzsTzeD4hgAipbxd9N7v4KGJIE12ERDZp Y1+9GqKT3ZTShbjgCNfFC1Wk5FW3TAaa9KQF3pqYVByhPvjbauCtAoab/7Tk76wcbzkz X3Z3o9Nsr9LLcwMM+wCxAICg49zxaN8OXd/5E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZdFhnUufyrFc19z7ViZt8Wb0ZHqiPUdjffxN+QTai+8=; b=fs8gjlyq3znBIJK5JVLZs1kbXfH3hz40qLEZNJ3hx5jyz/3BAoY0AWMDR2roUNcMYt kfqIVdj2F05+d3Y0sD6PM66FQ4tllo70FfDeX+C28pdBOGyQnKi1FKDecEQYcqHX4eJ9 CaJ4xQB9Yl+OHbTV7RnySEBzDtwj55BQKG3fGi9ZopdCjcdunTJx8Q5B8f1JdrP486ZB jXTOQ5XddqpAkLV3EGigw5uo8uIKJMfKN85KUqk1YHTZrvoKNa3uRPo3yqraa+DW5Jpc syLbjxDE7cr3lGtCfQiTmJycED+6ZBZfflMWZsN2Vh9vkpoljLeGfaGRneX6XEHpZYVB L8pw== X-Gm-Message-State: AA+aEWY5FO5G6vuDgDMbqug8QkMmvEPRPxDFuu/uIh2Zf6kTYDSAZBT1 9chCfRPluHEv5OuTfJQ6qDP6j+NNwaWnKA== X-Received: by 2002:adf:8421:: with SMTP id 30mr14626375wrf.153.1542984385551; Fri, 23 Nov 2018 06:46:25 -0800 (PST) Received: from cloudburst.twiddle.net ([195.77.246.50]) by smtp.gmail.com with ESMTPSA id p74sm10339630wmd.29.2018.11.23.06.46.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Nov 2018 06:46:25 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 23 Nov 2018 15:45:47 +0100 Message-Id: <20181123144558.5048-27-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181123144558.5048-1-richard.henderson@linaro.org> References: <20181123144558.5048-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH for-4.0 v2 26/37] tcg: Clean up generic bswap32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair.Francis@wdc.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Based on the only current user, Sparc: New code uses 1 constant that takes 2 insns to create, plus 8. Old code used 2 constants that took 2 insns to create, plus 9. The result is a new total of 10 vs an old total of 13. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 54 ++++++++++++++++++++++++++-------------------------- 1 file changed, 27 insertions(+), 27 deletions(-) -- 2.17.2 diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 7a8015c5a9..a956499e46 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -1012,22 +1012,22 @@ void tcg_gen_bswap32_i32(TCGv_i32 ret, TCGv_i32 arg) if (TCG_TARGET_HAS_bswap32_i32) { tcg_gen_op2_i32(INDEX_op_bswap32_i32, ret, arg); } else { - TCGv_i32 t0, t1; - t0 = tcg_temp_new_i32(); - t1 = tcg_temp_new_i32(); + TCGv_i32 t0 = tcg_temp_new_i32(); + TCGv_i32 t1 = tcg_temp_new_i32(); + TCGv_i32 t2 = tcg_const_i32(0x00ff00ff); - tcg_gen_shli_i32(t0, arg, 24); + /* arg = abcd */ + tcg_gen_shri_i32(t0, arg, 8); /* t0 = .abc */ + tcg_gen_and_i32(t1, arg, t2); /* t1 = .b.d */ + tcg_gen_and_i32(t0, t0, t2); /* t0 = .a.c */ + tcg_temp_free_i32(t2); + tcg_gen_shli_i32(t1, t1, 8); /* t1 = b.d. */ + tcg_gen_or_i32(ret, t0, t1); /* ret = badc */ - tcg_gen_andi_i32(t1, arg, 0x0000ff00); - tcg_gen_shli_i32(t1, t1, 8); - tcg_gen_or_i32(t0, t0, t1); + tcg_gen_shri_i32(t0, ret, 16); /* t0 = ..ba */ + tcg_gen_shli_i32(t1, ret, 16); /* t1 = dc.. */ + tcg_gen_or_i32(ret, t0, t1); /* ret = dcba */ - tcg_gen_shri_i32(t1, arg, 8); - tcg_gen_andi_i32(t1, t1, 0x0000ff00); - tcg_gen_or_i32(t0, t0, t1); - - tcg_gen_shri_i32(t1, arg, 24); - tcg_gen_or_i32(ret, t0, t1); tcg_temp_free_i32(t0); tcg_temp_free_i32(t1); } @@ -1638,23 +1638,23 @@ void tcg_gen_bswap32_i64(TCGv_i64 ret, TCGv_i64 arg) } else if (TCG_TARGET_HAS_bswap32_i64) { tcg_gen_op2_i64(INDEX_op_bswap32_i64, ret, arg); } else { - TCGv_i64 t0, t1; - t0 = tcg_temp_new_i64(); - t1 = tcg_temp_new_i64(); + TCGv_i64 t0 = tcg_temp_new_i64(); + TCGv_i64 t1 = tcg_temp_new_i64(); + TCGv_i64 t2 = tcg_const_i64(0x00ff00ff); - tcg_gen_shli_i64(t0, arg, 24); - tcg_gen_ext32u_i64(t0, t0); + /* arg = ....abcd */ + tcg_gen_shri_i64(t0, arg, 8); /* t0 = .....abc */ + tcg_gen_and_i64(t1, arg, t2); /* t1 = .....b.d */ + tcg_gen_and_i64(t0, t0, t2); /* t0 = .....a.c */ + tcg_temp_free_i64(t2); + tcg_gen_shli_i64(t1, t1, 8); /* t1 = ....b.d. */ + tcg_gen_or_i64(ret, t0, t1); /* ret = ....badc */ - tcg_gen_andi_i64(t1, arg, 0x0000ff00); - tcg_gen_shli_i64(t1, t1, 8); - tcg_gen_or_i64(t0, t0, t1); + tcg_gen_shli_i64(t1, ret, 48); /* t1 = dc...... */ + tcg_gen_shri_i64(t0, ret, 16); /* t0 = ......ba */ + tcg_gen_shri_i64(t1, ret, 32); /* t1 = ....dc.. */ + tcg_gen_or_i64(ret, t0, t1); /* ret = ....dcba */ - tcg_gen_shri_i64(t1, arg, 8); - tcg_gen_andi_i64(t1, t1, 0x0000ff00); - tcg_gen_or_i64(t0, t0, t1); - - tcg_gen_shri_i64(t1, arg, 24); - tcg_gen_or_i64(ret, t0, t1); tcg_temp_free_i64(t0); tcg_temp_free_i64(t1); }