From patchwork Fri Dec 14 03:19:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 153735 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1608362ljp; Thu, 13 Dec 2018 19:43:02 -0800 (PST) X-Google-Smtp-Source: AFSGD/W28tykikaLCUgS5V6lpb/cHqkv5AsxQERxgw6uWsSXqCnElbLo3d/skwdvocQ4+KUP+7UW X-Received: by 2002:ac8:5344:: with SMTP id d4mr1278583qto.372.1544758982247; Thu, 13 Dec 2018 19:43:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544758982; cv=none; d=google.com; s=arc-20160816; b=tOvF2UKNA5nMRdj3ai37DIRPafwPXmTWFEcMHhWfBrnnOT9RokOV1G09g6rmVw3IKI yDWZDxSYQcV9CqU9wlANFTNdLPrbaVxl5u2QGjUAOdf2sDUC6UgMNHWBkHCzR8g3sO6C lhu8/k0IHpt3WDqjexoUa1Vh0DnJdHmcD/6qmKEbGrnLoEuwJZhnMRnbDsjo/omYQOyf 0Szns70SWPbWBo0jnmuLwPwRPqdG3zZXn2w9nT5dhH+Umuf1eXXUVRIp9MMhf1+INiHd 2avPZLvHqTnncIqvFnWW84taYKcqx+hAsyRlMKcT04mAHrQaF3569SEWf+ymppu4bAC6 XVnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=JqFbH0qOpR2THtxNKT63TiFEtHZ/a0vfq2LRWkSUcCo=; b=tMo4RcRpxz62BhJxotx7d/2PxT2/Vh5TKZy2erGt4XcMmZ2Ia1pv8x6mLVGZITJvRw ql0OIU5X2e/xSKRAicCvaSxuE+ihuvWt2060ae6g7GPbSaLkXAY95xPSpt+YOgJ027qQ M++kCs3Fw093R3wE3M/brpYtAKhOxndHR/9I/wHp8Fyj6KrALf3jiaTDeSKcWo8CAgkU 1XwFQRatUIK5t6DFBm5MeIY5utxAhgcvHxKXELuqHqcvrOuV4mAj/IvdXnNy+zW03nw9 EiDLFX61Dfo/CdfbJhTFDnXQXj74hW1dJxVPnmIO6J0ph9oA4Ex0s+TP9fAiQ3UIJVtO 0PKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=DLtvfSo9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 98si1942420qky.119.2018.12.13.19.43.01 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 13 Dec 2018 19:43:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=DLtvfSo9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXeNR-0000qo-Dt for patch@linaro.org; Thu, 13 Dec 2018 22:43:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXe1D-0006I5-I7 for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:20:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXe1C-0007iH-12 for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:20:03 -0500 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:42986) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXe1A-0007Yf-5Y for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:20:01 -0500 Received: by mail-ot1-x32c.google.com with SMTP id v23so4096851otk.9 for ; Thu, 13 Dec 2018 19:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JqFbH0qOpR2THtxNKT63TiFEtHZ/a0vfq2LRWkSUcCo=; b=DLtvfSo98w7QHZR0A3afa8CBEK2//uEr9Cb5iag3svZw/3iezrMwMFn3C3rs6MUsdv S7/labZjFSg1R0V5gsGRhGsN+pZjBwXDGBppmuBVMTK1gr7YYuCwRMFPJJJw0SUIyW05 OFQ9wl2qM9t/3SDW8K8cPRLjfx8w0oVYKyAyU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JqFbH0qOpR2THtxNKT63TiFEtHZ/a0vfq2LRWkSUcCo=; b=kwy4P1RGyfXm8JgZ+n8XqnTspfU3rQ3JW9kSMdkpiVVO9DI3L0mAlVj2xVi8Z0fb/b dVOjTdsMl67elJb/BGHrEAEhPo0OWOqaZga31ADcNaHLCObcwm/uIaq2kewal7ahk7f4 XpZuKTKeMRoHBUnjm2WdhLRI6X6QZUyJZUNOOXmve9BA+ivKaSiQyzacy9XdmD7Q2s8P L8DX32XXmyc+KE+KaXg/AbfeuoActWJuQn7o3mmMClpE+6nVbJfRwJP0yvQzqfTiXKrZ uAXYrCNQnoBPG8mfFzi7JgMKAv5k2mgDkSLmn3zEoYL0GmLHDfhFbFQVW2zG6EzEFzSW qaRQ== X-Gm-Message-State: AA+aEWZ+36sQ/apz1TSDOikgKmS3CSAKdvEQ/gF3lw0a1ek881f60dCy FxSAl/TNnCv/m9QMspf1S1R5NreCfjZupg== X-Received: by 2002:a05:6830:1596:: with SMTP id i22mr998424otr.7.1544757597704; Thu, 13 Dec 2018 19:19:57 -0800 (PST) Received: from cloudburst.twiddle.net ([187.217.227.243]) by smtp.gmail.com with ESMTPSA id g138sm2367537oib.26.2018.12.13.19.19.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Dec 2018 19:19:57 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 13 Dec 2018 21:19:19 -0600 Message-Id: <20181214031923.29527-30-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181214031923.29527-1-richard.henderson@linaro.org> References: <20181214031923.29527-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32c Subject: [Qemu-devel] [PULL 28/32] tcg: Drop nargs from tcg_op_insert_{before, after} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, "Emilio G. Cota" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" It's unused since 75e8b9b7aa0b95a761b9add7e2f09248b101a392. Signed-off-by: Emilio G. Cota Message-Id: <20181209193749.12277-9-cota@braap.org> Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson --- tcg/tcg.h | 4 ++-- tcg/optimize.c | 4 ++-- tcg/tcg.c | 10 ++++------ 3 files changed, 8 insertions(+), 10 deletions(-) -- 2.17.2 diff --git a/tcg/tcg.h b/tcg/tcg.h index f4efbaa680..a745e926bb 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -1073,8 +1073,8 @@ void tcg_gen_callN(void *func, TCGTemp *ret, int nargs, TCGTemp **args); TCGOp *tcg_emit_op(TCGOpcode opc); void tcg_op_remove(TCGContext *s, TCGOp *op); -TCGOp *tcg_op_insert_before(TCGContext *s, TCGOp *op, TCGOpcode opc, int narg); -TCGOp *tcg_op_insert_after(TCGContext *s, TCGOp *op, TCGOpcode opc, int narg); +TCGOp *tcg_op_insert_before(TCGContext *s, TCGOp *op, TCGOpcode opc); +TCGOp *tcg_op_insert_after(TCGContext *s, TCGOp *op, TCGOpcode opc); void tcg_optimize(TCGContext *s); diff --git a/tcg/optimize.c b/tcg/optimize.c index 6b98ec13e6..01e80c3e46 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1261,7 +1261,7 @@ void tcg_optimize(TCGContext *s) uint64_t a = ((uint64_t)ah << 32) | al; uint64_t b = ((uint64_t)bh << 32) | bl; TCGArg rl, rh; - TCGOp *op2 = tcg_op_insert_before(s, op, INDEX_op_movi_i32, 2); + TCGOp *op2 = tcg_op_insert_before(s, op, INDEX_op_movi_i32); if (opc == INDEX_op_add2_i32) { a += b; @@ -1283,7 +1283,7 @@ void tcg_optimize(TCGContext *s) uint32_t b = arg_info(op->args[3])->val; uint64_t r = (uint64_t)a * b; TCGArg rl, rh; - TCGOp *op2 = tcg_op_insert_before(s, op, INDEX_op_movi_i32, 2); + TCGOp *op2 = tcg_op_insert_before(s, op, INDEX_op_movi_i32); rl = op->args[0]; rh = op->args[1]; diff --git a/tcg/tcg.c b/tcg/tcg.c index 54f1272187..963cb37892 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2205,16 +2205,14 @@ TCGOp *tcg_emit_op(TCGOpcode opc) return op; } -TCGOp *tcg_op_insert_before(TCGContext *s, TCGOp *old_op, - TCGOpcode opc, int nargs) +TCGOp *tcg_op_insert_before(TCGContext *s, TCGOp *old_op, TCGOpcode opc) { TCGOp *new_op = tcg_op_alloc(opc); QTAILQ_INSERT_BEFORE(old_op, new_op, link); return new_op; } -TCGOp *tcg_op_insert_after(TCGContext *s, TCGOp *old_op, - TCGOpcode opc, int nargs) +TCGOp *tcg_op_insert_after(TCGContext *s, TCGOp *old_op, TCGOpcode opc) { TCGOp *new_op = tcg_op_alloc(opc); QTAILQ_INSERT_AFTER(&s->ops, old_op, new_op, link); @@ -2552,7 +2550,7 @@ static bool liveness_pass_2(TCGContext *s) TCGOpcode lopc = (arg_ts->type == TCG_TYPE_I32 ? INDEX_op_ld_i32 : INDEX_op_ld_i64); - TCGOp *lop = tcg_op_insert_before(s, op, lopc, 3); + TCGOp *lop = tcg_op_insert_before(s, op, lopc); lop->args[0] = temp_arg(dir_ts); lop->args[1] = temp_arg(arg_ts->mem_base); @@ -2621,7 +2619,7 @@ static bool liveness_pass_2(TCGContext *s) TCGOpcode sopc = (arg_ts->type == TCG_TYPE_I32 ? INDEX_op_st_i32 : INDEX_op_st_i64); - TCGOp *sop = tcg_op_insert_after(s, op, sopc, 3); + TCGOp *sop = tcg_op_insert_after(s, op, sopc); sop->args[0] = temp_arg(dir_ts); sop->args[1] = temp_arg(arg_ts->mem_base);