From patchwork Fri Dec 14 05:23:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 153742 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1671461ljp; Thu, 13 Dec 2018 21:25:03 -0800 (PST) X-Google-Smtp-Source: AFSGD/XqfxXpZj/P/3FW/6513MgMrcpykb0SLBZPvemMg1upJ7JSuzd8xIuO8KzV1uYed7VTruBC X-Received: by 2002:aed:2803:: with SMTP id r3mr1455234qtd.316.1544765103210; Thu, 13 Dec 2018 21:25:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544765103; cv=none; d=google.com; s=arc-20160816; b=WvOpIt5AUrtnEDN8m7vvGSqYLajDnecuHeAnXZfx/m+b6kWmDtlmrHD8J8U4Ytdz3S XFBKONc79azSMDJg/CIlPDsgDuOAj19BTX3Q+KwXvU7vh03LTwu8yTEXoGnha4Kum3Dt EWS5Hd2vwhOCZpt7x3dqgoWvh0A/qrJIo1tKYn1MlLzjZduh32xOzUmHTJENp/kH0YFf N5i1DvrzX9Ft+xz7IRWUcHfpY4OG8NbowScKdHI2a9kBr8f02jTqER51wR6YM4nXV4Sr HNFGPma9a/NXI+BPXdryEECB0IgsNFQ9CTJQ9X/z3U9xUJlmbNQ+rKuKs2pNEJ8hVo2F RqEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=6OI+UPAp5FYiypogPPtR+ujzpAY2Etryh32yM0PnSA8=; b=vSoYgG5HgaWM9m0qB0fnacdnMe60jUG5vrslwq7RRwoqjGUgsU1WNznNRGmHuK/VXt bPbYScwrBjPn2789eIVkAyLjUTra6SIudASyT1wcYfzO1K4Rm7rToK6wvHt/bdEF/zNW yuvxYCcb32mAbVCO4Wfxk99qmsJqJjcsaSk04WPCz4ho0AV6ATHz6ImghSQRSaoNaQ74 7aHnBesvq2ohiy2CaEq2cKyyWxRVC99bFqlPm9o9QF087nQDMeDbH2EQWVEbgZKA3WQk iXSlkgORBtcz2kN/FxLZxW4/SkRe5g2KnMxEZsONA5URoCuf7kAR/XA2O0f3FeSac2MD uvUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LRBEBCsq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x24si2230969qkh.97.2018.12.13.21.25.03 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 13 Dec 2018 21:25:03 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=LRBEBCsq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXfyA-0004eS-MG for patch@linaro.org; Fri, 14 Dec 2018 00:25:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXfxi-0004TS-G9 for qemu-devel@nongnu.org; Fri, 14 Dec 2018 00:24:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXfxd-0005PX-Cs for qemu-devel@nongnu.org; Fri, 14 Dec 2018 00:24:32 -0500 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:33295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXfxd-0005Ot-7c for qemu-devel@nongnu.org; Fri, 14 Dec 2018 00:24:29 -0500 Received: by mail-oi1-x231.google.com with SMTP id c206so3659730oib.0 for ; Thu, 13 Dec 2018 21:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6OI+UPAp5FYiypogPPtR+ujzpAY2Etryh32yM0PnSA8=; b=LRBEBCsqDcD2qLOy5opoKDajZWn06n+J86t5+kf8en2QR/Rk3vhRXIPcyMITi5TXCT 4iQP2598Jqdh09sPPp6Y1esir7V/v/iAvxfBMc8TbWaRK+EKwP5xxjBBe/913QRjginq x5ns8v5DwptBibTX4FV4piagkRGJNeVP2y53s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6OI+UPAp5FYiypogPPtR+ujzpAY2Etryh32yM0PnSA8=; b=pC0SJ2eYYgfPxbf/WU1tVarWcqoIJbu77zQng21u3IbjulHPpATnkHMUqy840IG72h dd4JnKw/IVPHebvtOn+qU+LLf266dK0paWe21ANggQqV8/tKEvr8mVk4qoIAHj6dsMFl 6GBzrveE8kkx5HTtd0UN9BmP/aXIWJ5WTMMz1+iYGPSV3kbnuXgvbcF+ge78kgIgSfSL h4qbOAgDigiJLwKk59lfXavxN/r5JnVcI8rboB98Umq8LhcCdg7gHjA4T3pCXmlIe+qf G4Max1WQWZW6uGJeBXgAPrlWB4sf8sa/yqKhci/f62qUPe6b2nDF2Oeg2SvXQOOfO2+Q qRNQ== X-Gm-Message-State: AA+aEWZpZVerSk907N437Zoova+X497C/YZ8yWV3gl72E8QPzcLrTyHi 8XoxLsjToZzfFx0ZCeZ5k2VXHoQfT/xLcg== X-Received: by 2002:aca:2803:: with SMTP id 3mr1011816oix.85.1544765068221; Thu, 13 Dec 2018 21:24:28 -0800 (PST) Received: from cloudburst.twiddle.net ([187.217.227.243]) by smtp.gmail.com with ESMTPSA id r1sm1845379oti.44.2018.12.13.21.24.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Dec 2018 21:24:27 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 13 Dec 2018 23:23:56 -0600 Message-Id: <20181214052410.11863-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181214052410.11863-1-richard.henderson@linaro.org> References: <20181214052410.11863-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::231 Subject: [Qemu-devel] [PATCH v2 13/27] target/arm: Decode Load/store register (pac) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Not that there are any stores involved, but why argue with ARM's naming convention. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 62 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) -- 2.17.2 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e62d248894..c57c89d98a 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -3146,6 +3146,65 @@ static void disas_ldst_atomic(DisasContext *s, uint32_t insn, s->be_data | size | MO_ALIGN); } +/* PAC memory operations + * + * 31 30 27 26 24 22 21 12 11 10 5 0 + * +------+-------+---+-----+-----+---+--------+---+---+----+-----+ + * | size | 1 1 1 | V | 0 0 | M S | 1 | imm9 | W | 1 | Rn | Rt | + * +------+-------+---+-----+-----+------------+---+---+----+-----+ + * + * Rt: the result register + * Rn: base address or SP + * Rs: the source register for the operation + * V: vector flag (always 0 as of v8.3) + * M: clear for key DA, set for key DB + * W: pre-indexing flag + * S: sign for imm9. + */ +static void disas_ldst_pac(DisasContext *s, uint32_t insn, + int size, int rt, bool is_vector) +{ + int rn = extract32(insn, 5, 5); + bool is_wback = extract32(insn, 11, 1); + bool use_key_a = !extract32(insn, 23, 1); + int offset, memidx; + TCGv_i64 tcg_addr, tcg_rt; + + if (size != 3 || is_vector || !dc_isar_feature(aa64_pauth, s)) { + unallocated_encoding(s); + return; + } + + if (rn == 31) { + gen_check_sp_alignment(s); + } + tcg_addr = read_cpu_reg_sp(s, rn, 1); + + if (s->pauth_active) { + if (use_key_a) { + gen_helper_autda(tcg_addr, cpu_env, tcg_addr, cpu_X[31]); + } else { + gen_helper_autdb(tcg_addr, cpu_env, tcg_addr, cpu_X[31]); + } + } + + /* Form the 10-bit signed, scaled offset. */ + offset = (extract32(insn, 22, 1) << 9) | extract32(insn, 12, 9); + offset = sextract32(offset << size, 10 + size, 0); + tcg_gen_addi_i64(tcg_addr, tcg_addr, offset); + + tcg_rt = cpu_reg(s, rt); + memidx = get_mem_index(s); + do_gpr_ld_memidx(s, tcg_rt, tcg_addr, size, + /* is_signed */ false, /* extend */ false, memidx, + /* iss_valid */ true, /* iss_srt */ rt, + /* iss_sf */ true, /* iss_ar */ false); + + if (is_wback) { + tcg_gen_mov_i64(cpu_reg_sp(s, rn), tcg_addr); + } +} + /* Load/store register (all forms) */ static void disas_ldst_reg(DisasContext *s, uint32_t insn) { @@ -3171,6 +3230,9 @@ static void disas_ldst_reg(DisasContext *s, uint32_t insn) case 2: disas_ldst_reg_roffset(s, insn, opc, size, rt, is_vector); return; + default: + disas_ldst_pac(s, insn, size, rt, is_vector); + return; } break; case 1: