From patchwork Sun Jan 6 22:50:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 154846 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2899795ljp; Sun, 6 Jan 2019 14:53:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN4H+d1HEGFsQmWcUJ0KDDNZeynfeJQp6iL1nPXtOifZE8jQZoVY4C1LvzpTjcpgEKGw5g3q X-Received: by 2002:a1c:7eca:: with SMTP id z193mr7578523wmc.140.1546815195478; Sun, 06 Jan 2019 14:53:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546815195; cv=none; d=google.com; s=arc-20160816; b=I+fV2/qgstQSA587RDnVBZuVxFApW3mcJvCKZsgX0ju42YGfVGJH5+2ZDRQU1sjth0 Hf1bmWb78QYzodMyhx5tp2nZr9+R9Gi2MaeikoGPt/Ddig0/fumV+wMaKLuSBChyjJCX J6idUOvvSnVsNj6/j14mdjibI2WlddF33BTpUDADuIbAzHGy+yLa31xal+Kyu4VnNIab 0mCyfk5+Ia7NkONmcJ8ZWwHZ7ef6pT91YrBPxmbGhE8ADWpJgcpsGWPYpJ9oN/nlCns4 hrdDlyHHWkdgxjfDgy9YmTzQi5bt2xYEg+/N/OkZpLstGltF4gEpJOfedkHH++ixM2z4 0d0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=kn8TChn9a+pm0RN7mZwckgPE1JRDgQHcCQVRvVrkJ7Y=; b=iluwhtHBCxmUUddF8UMTL1ExVgCDJHguwohBdIjFNEpeUn2Q/oYCsDbVAQQCMif6g7 XLwfcQKnmDphs/d6pyiLClIGt9jKVE6hsaUmjEdkPe6fzyFIELDsd6vZbpUtzaoYFb5F 3e3e2h4K35X4D/jlMRLqAEXAVjxVMfl/9vq5XT9k8JWslI/ojMxHgG1n4uPLaJOtxDhj OpkWYsx00mrYdfmbxAFF6CGn/VD3C/Z6As6+EZavWTOuKTuoMxI1F60pDvsJ8YeNFA32 BGzDfVQPlicSqwazaymWG33tnIhXhGHUQkluXvbpzgly1+fHXCdBrBMQbKB4jB8XVpFs KJhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bHLGqdcH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from listsout.gnu.org (listsout.gnu.org. [208.118.235.17]) by mx.google.com with ESMTPS id w203si4298009wma.43.2019.01.06.14.53.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 06 Jan 2019 14:53:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bHLGqdcH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHI9-00054W-0v for patch@linaro.org; Sun, 06 Jan 2019 17:53:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHFo-0003mR-MP for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggHFn-0004gQ-Pg for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:48 -0500 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:40558) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggHFn-0004g4-KR for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:47 -0500 Received: by mail-pl1-x644.google.com with SMTP id u18so19931181plq.7 for ; Sun, 06 Jan 2019 14:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kn8TChn9a+pm0RN7mZwckgPE1JRDgQHcCQVRvVrkJ7Y=; b=bHLGqdcHZdEZOXs6S+jX0XGhwgSMIKO1PeZi6eVSo+9f3gVrKfuz3O3gPa6rooL9x1 xhMJDocZEpeKSf6f5ozxI2getqhOqxfC9nTd+Ucv18RfePA/cx9QHudDK96GYLnV8NkL x2mi3MhIhrgbgb7mF3kcx542fpjbO5y8WBUl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kn8TChn9a+pm0RN7mZwckgPE1JRDgQHcCQVRvVrkJ7Y=; b=nefR5CTJWroWq3fMsiagP5z7QJG2+UhR5Il3Mu3STHfZ/1xZSBKl4qripuNGauV9Lo eZukO5IZboNtRu0gXx002Oo/WCft/iuPfoQcmAv5Qga0vOew2oo+tTcUxs/rpaRIJpTV YJKxVSGlFrNDmUJhBYZPJbsO/0SpnuJ8HGhhxo6HpWtzEiRTMLtGS8VMyg/UoO4T/Qbz CfxgeW73l/1O6HqEMawN3EPPcDP50kGzAs4kz3F2ZqUZbKSCBKBMTQwx1+CAEYUaNxjR iqRy0WktL3qOiEVtcjf0R1zbcv5MgOOfliBmHRHd/9plL7KHS04FxVrBWrbQ+POoGpOs qAxQ== X-Gm-Message-State: AJcUukdBgYYl1nQRkFnBKmE5bQatljaRgatKM/7Pz6hNEX9BOTlC8TKS v2AVYQj5sPo+7xQSjuhMtV98eARO6UmJFw== X-Received: by 2002:a17:902:b090:: with SMTP id p16mr59152015plr.190.1546815046394; Sun, 06 Jan 2019 14:50:46 -0800 (PST) Received: from cloudburst.lan (2001-44b8-2176-c800-8cc6-2630-7d99-5ef1.static.ipv6.internode.on.net. [2001:44b8:2176:c800:8cc6:2630:7d99:5ef1]) by smtp.gmail.com with ESMTPSA id n78sm45905768pfk.19.2019.01.06.14.50.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Jan 2019 14:50:45 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2019 08:50:33 +1000 Message-Id: <20190106225035.5671-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190106225035.5671-1-richard.henderson@linaro.org> References: <20190106225035.5671-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::644 Subject: [Qemu-devel] [PATCH 1/3] target/arm: Rely on optimization within tcg_gen_gvec_or X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Since we're now handling a == b generically, we no longer need to do it by hand within target/arm/. Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +----- target/arm/translate-sve.c | 6 +----- target/arm/translate.c | 12 +++--------- 3 files changed, 5 insertions(+), 19 deletions(-) -- 2.17.2 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e1da1e4d6f..2d6f8c1b4f 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10152,11 +10152,7 @@ static void disas_simd_3same_logic(DisasContext *s, uint32_t insn) gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_andc, 0); return; case 2: /* ORR */ - if (rn == rm) { /* MOV */ - gen_gvec_fn2(s, is_q, rd, rn, tcg_gen_gvec_mov, 0); - } else { - gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); - } + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); return; case 3: /* ORN */ gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_orc, 0); diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index b15b615ceb..3a2eb51566 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -280,11 +280,7 @@ static bool trans_AND_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_ORR_zzz(DisasContext *s, arg_rrr_esz *a) { - if (a->rn == a->rm) { /* MOV */ - return do_mov_z(s, a->rd, a->rn); - } else { - return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); - } + return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); } static bool trans_EOR_zzz(DisasContext *s, arg_rrr_esz *a) diff --git a/target/arm/translate.c b/target/arm/translate.c index 7c4675ffd8..33b1860148 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6294,15 +6294,9 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) tcg_gen_gvec_andc(0, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); break; - case 2: - if (rn == rm) { - /* VMOV */ - tcg_gen_gvec_mov(0, rd_ofs, rn_ofs, vec_size, vec_size); - } else { - /* VORR */ - tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, - vec_size, vec_size); - } + case 2: /* VORR */ + tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); break; case 3: /* VORN */ tcg_gen_gvec_orc(0, rd_ofs, rn_ofs, rm_ofs,