From patchwork Mon Jan 7 22:31:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 154951 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp4196803jaa; Mon, 7 Jan 2019 14:40:34 -0800 (PST) X-Google-Smtp-Source: ALg8bN5f/Ne5LnHNxIFJm+cP0YxYPwZha+q+BGlPoBENj4cUKT08ZMJm1lTeDfbR6dGplKWS19WC X-Received: by 2002:a5d:4512:: with SMTP id s18mr56432967wrq.182.1546900834439; Mon, 07 Jan 2019 14:40:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546900834; cv=none; d=google.com; s=arc-20160816; b=D45OyGqcaOYEvohoiqEHzq1bsI1upTu6kacVdgxx44H/wgvgTLGq/oSmHVCaYh/9Yb Plqusl8zZWtxJsIfI/Q4rD85bODdqHpCzymZ8G0CtuTFvm8/kdilYTGeQyivr4wH4ftI iVPRs+d5pBwSTHUX6sBqvK+0Hsv220uJdtOiAxh25kjxc6bm7jCD4K4DFIqDGeHnzI/S 0KvRBHjuk0ht9YCHJjeFUfsgjTT43P+F/HLCI71s6Mx7w3Ti0p8nCjz3zATiEj/NgU/+ eNQ1s5iGazcF19cjIR8I1y3RI5nV+9ViG1LkS3mOBp36bzm17sbxJcxrzR1xaAWUxt8I 7gUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=3cUMG9xB1bEWZ7CVZF6Kd2WubE80ru5rXbyhmripx0Q=; b=0A6NHBjl1j40AmFGV2wAHBF5XrJihzTLc+vAlazYa7uC/gz5OIDcwivpbNru7guZVa XSXebjSu4kgYur9xvhP+UceaNzcYL16eGti2QY/vqEgSmsxv3c8iALth7XY6G+b5Y/CY xNwxk541Hzh8NrCpvoCsR3UnntX2L0Nr3GGMihelHyYvQV6fploLClDrkAxo30l4mKg9 5TKRfnDfHm1LyRqJJG522cb7XHGORorQBmPg7dEmabntHkJtrWQWChvQZa4jsqOiY9Bf hTlQpnoZRes85ke+lZkofpBCGrLbgr3OM3Ne4Zq2aD8LN3vuKmhhB+bDRMVP2igshvaP F8aQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s12si35635679wrw.100.2019.01.07.14.40.34 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 07 Jan 2019 14:40:34 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([127.0.0.1]:52741 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggdZR-0004Qz-DG for patch@linaro.org; Mon, 07 Jan 2019 17:40:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggdR4-0006OZ-2h for qemu-devel@nongnu.org; Mon, 07 Jan 2019 17:31:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggdR3-000884-5v for qemu-devel@nongnu.org; Mon, 07 Jan 2019 17:31:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34058) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ggdR3-00087I-0I for qemu-devel@nongnu.org; Mon, 07 Jan 2019 17:31:53 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 28608BDEA; Mon, 7 Jan 2019 22:31:52 +0000 (UTC) Received: from donizetti.redhat.com (unknown [10.36.112.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F672648DE; Mon, 7 Jan 2019 22:31:50 +0000 (UTC) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2019 23:31:46 +0100 Message-Id: <20190107223147.14269-2-pbonzini@redhat.com> In-Reply-To: <20190107223147.14269-1-pbonzini@redhat.com> References: <20190107223147.14269-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 07 Jan 2019 22:31:52 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 21/35] tests/hexloader-test: Don't pass -nographic to the QEMU under test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The hexloader test invokes QEMU with the -nographic argument. This is unnecessary, because the qtest_initf() function will pass it -display none, which suffices to disable the graphical window. It also means that the QEMU process will make the stdin/stdout O_NONBLOCK. Since O_NONBLOCK is not per-file descriptor but per "file description", this non-blocking behaviour is then shared with any other process that's using the stdin/stdout of the 'make check' run, including make itself. This can result in make falling over with "make: write error: stdout" because it got an unexpected EINTR trying to write output messages to the terminal. This is particularly noticable if running 'make check' in a loop with while make check; do true; done (It does not affect single make check runs so much because the shell will remove the O_NONBLOCK status before it reads the terminal for interactive input.) Remove the unwanted -nographic argument. Signed-off-by: Peter Maydell Message-Id: <20190104145018.16950-1-peter.maydell@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Paolo Bonzini --- tests/hexloader-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/tests/hexloader-test.c b/tests/hexloader-test.c index 834ed52c22..8b7aa2d72d 100644 --- a/tests/hexloader-test.c +++ b/tests/hexloader-test.c @@ -23,7 +23,7 @@ static void hex_loader_test(void) const unsigned int base_addr = 0x00010000; QTestState *s = qtest_initf( - "-M vexpress-a9 -nographic -device loader,file=tests/data/hex-loader/test.hex"); + "-M vexpress-a9 -device loader,file=tests/data/hex-loader/test.hex"); for (i = 0; i < 256; ++i) { uint8_t val = qtest_readb(s, base_addr + i);