diff mbox series

[v1,01/19] docker: Use stable git tag for virglrenderer

Message ID 20190110174516.21586-2-alex.bennee@linaro.org
State Superseded
Headers show
Series testing/next queue for travis and docker | expand

Commit Message

Alex Bennée Jan. 10, 2019, 5:44 p.m. UTC 
From: Philippe Mathieu-Daudé <philmd@redhat.com>


Use a stable tag instead of some random commit from mainstream
development, to avoid unexpected build failures.

This fixes:

    CC       virglrenderer.lo
  virglrenderer.c: In function 'virgl_has_gl_colorspace':
  virglrenderer.c:208:11: error: implicit declaration of function 'virgl_has_egl_khr_gl_colorspace' [-Werror=implicit-function-declaration]
             virgl_has_egl_khr_gl_colorspace(egl_info));
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  virglrenderer.c:208:43: error: 'egl_info' undeclared (first use in this function)
             virgl_has_egl_khr_gl_colorspace(egl_info));
                                             ^~~~~~~~
  virglrenderer.c:208:43: note: each undeclared identifier is reported only once for each function it appears in
  cc1: some warnings being treated as errors

As of this commit 'git virglrenderer-0.7.0' is the last stable tag.
(virglrenderer commit breaking: fb4f7577f7ef)

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/docker/dockerfiles/debian-amd64.docker | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.17.1

Comments

Philippe Mathieu-Daudé Jan. 10, 2019, 6:01 p.m. UTC | #1 
On 1/10/19 6:44 PM, Alex Bennée wrote:
> From: Philippe Mathieu-Daudé <philmd@redhat.com>

> 

> Use a stable tag instead of some random commit from mainstream

> development, to avoid unexpected build failures.

> 

> This fixes:

> 

>     CC       virglrenderer.lo

>   virglrenderer.c: In function 'virgl_has_gl_colorspace':

>   virglrenderer.c:208:11: error: implicit declaration of function 'virgl_has_egl_khr_gl_colorspace' [-Werror=implicit-function-declaration]

>              virgl_has_egl_khr_gl_colorspace(egl_info));

>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

>   virglrenderer.c:208:43: error: 'egl_info' undeclared (first use in this function)

>              virgl_has_egl_khr_gl_colorspace(egl_info));

>                                              ^~~~~~~~

>   virglrenderer.c:208:43: note: each undeclared identifier is reported only once for each function it appears in

>   cc1: some warnings being treated as errors

> 

> As of this commit 'git virglrenderer-0.7.0' is the last stable tag.

> (virglrenderer commit breaking: fb4f7577f7ef)

> 

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  tests/docker/dockerfiles/debian-amd64.docker | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker

> index 24b113b76f..47a30adbdb 100644

> --- a/tests/docker/dockerfiles/debian-amd64.docker

> +++ b/tests/docker/dockerfiles/debian-amd64.docker

> @@ -24,7 +24,8 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \

>          libegl1-mesa-dev \

>          libepoxy-dev \

>          libgbm-dev

> -RUN git clone https://anongit.freedesktop.org/git/virglrenderer.git /usr/src/virglrenderer

> +RUN git clone https://anongit.freedesktop.org/git/virglrenderer.git /usr/src/virglrenderer && \

> +    cd /usr/src/virglrenderer && git checkout virglrenderer-0.7.0

>  RUN cd /usr/src/virglrenderer && ./autogen.sh && ./configure --with-glx --disable-tests && make install

>  

>  # netmap

> 


I will prepare another patches for netmap and tricore-binutils.
diff mbox series

Patch

diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker
index 24b113b76f..47a30adbdb 100644
--- a/tests/docker/dockerfiles/debian-amd64.docker
+++ b/tests/docker/dockerfiles/debian-amd64.docker
@@ -24,7 +24,8 @@  RUN DEBIAN_FRONTEND=noninteractive eatmydata \
         libegl1-mesa-dev \
         libepoxy-dev \
         libgbm-dev
-RUN git clone https://anongit.freedesktop.org/git/virglrenderer.git /usr/src/virglrenderer
+RUN git clone https://anongit.freedesktop.org/git/virglrenderer.git /usr/src/virglrenderer && \
+    cd /usr/src/virglrenderer && git checkout virglrenderer-0.7.0
 RUN cd /usr/src/virglrenderer && ./autogen.sh && ./configure --with-glx --disable-tests && make install
 
 # netmap