From patchwork Tue Feb 5 17:42:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 157503 Delivered-To: patches@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5443635jaa; Tue, 5 Feb 2019 09:42:10 -0800 (PST) X-Received: by 2002:a1c:2c6:: with SMTP id 189mr4548678wmc.21.1549388530335; Tue, 05 Feb 2019 09:42:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549388530; cv=none; d=google.com; s=arc-20160816; b=suCwqsRYY3DIFyem0vRlxH04O+kSSWQNNiA++WNhkPogb/2wNyNe5DsLqZkNBxQB5t YlNPbPn1madLPYtnN/nix5gR8E3YfRlvl3F5J0amsnL5S/pYb4+BaDOlWEbZpUZ0YZFN uQqVmZA9xKFWy38plSa00w4B0RliXOhmmjjjHCpdkP+3kxFrHyzTR3VCLfkAEkPor6Gp 26auf5JG8po87cPQqIn3uuq9SHAKTI8K7iEzYBUgXuhJogm4R24vjs6cf5d64OleSvLM 1dyXAsHxZQ9BBg9VziTtzwRIv2m0+r2PszKtfOfDjoCxN1qh34d6vFLnV9WU9N3jW1bG wMTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=fDOf/+vRPBkCdSZK3fX1K7jtcq080jsXWxtMjTsKzuk=; b=PCOaZO0UbXJAv5FhU7EWCoblXM0bSqe1M6BJ1cHCmzoXhxiL01eNtg8CJdvSLsTmtt qnMK3iSZQ7C00DZs2TTjTYBg3On4YsGABPC/kK6OYpmZ28uqErkgAD8n5hjHLZVVyiVq Vhrq3ZuadbBpzu7ihA3/bO/XTrjpi+BsKdq7gFZmmjOjBwsx3RudIa1LTC0SOX+YIg8P h1LgSi/AqIb0DtN7gz4vtpQ8TmzXDYX8MbNbAmawaHzzSXRWEKOgs37/mfP8oTrA0/Ix ky2vg6HCI5FYBPy+k0PvZsbiSHWHYMkdKVFiVa1aQ7yL0DW3u3v1WlhSd7UTy4HcaE4f 5yVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PwH00UfX; spf=pass (google.com: domain of peter.maydell@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=peter.maydell@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id g13sor5909165wrq.7.2019.02.05.09.42.10 for (Google Transport Security); Tue, 05 Feb 2019 09:42:10 -0800 (PST) Received-SPF: pass (google.com: domain of peter.maydell@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PwH00UfX; spf=pass (google.com: domain of peter.maydell@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=peter.maydell@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fDOf/+vRPBkCdSZK3fX1K7jtcq080jsXWxtMjTsKzuk=; b=PwH00UfXKTC2vg5W8mOk9S2+kEkM5ufuD96oEyUTvbOtvx/UgR30WX57aTGIIBKNCs L8Ur+FumM9khSnY2ZhiQW4ctfeBt6KNJbel3jFv+gHCsRpbiAGCqZcMoMIz+/iQeAzej BQ4wx+JBdRxfcFCJoI8B/1rKeX/pGxRcIjnCrV7mar6dhaMaXGt5Vft9zoubzHwpZZx8 9zUuQaF8LvjFnTIjlcgKb3TJM4ZNDEGSwyG64i3+R2a1uBtAjJkAT1dhl/T6ZWccBbkZ l5fYIyFKAUb9Srl6IIL2oi01ptzzrnw2vE1BX3monjX3i65rb3YeEK+jglVUAP10Kd1o a1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fDOf/+vRPBkCdSZK3fX1K7jtcq080jsXWxtMjTsKzuk=; b=oGwmh8vxjQbJQfe1rocEYTOCtqd0WRj8HxHZsxv2hsmH8/o1S72O5UScJptwY46Qol cB6N/Ap15I/zG+pL2TmvmD2Loye16kESWU8t+RUuDdQOREJmPIuV+Q+8B23hadCKwMRJ PJ/oAoPiqp7uczulrigT9bxmwO/giYZf/kd+3JGZUtX2aTmPgq8fXbr43nj9/7EOtz/W xS6rTDQmSwiOyNiV5D0KUeNWWTocfzOwGxuuQJJObpKV5zTHdmUMcZ5iD70Vwb60Ulhq IWrPwvBsW6d07nVixPxeICVEvqFf/TmNPDgTjdTrr5YYbBO6oeItplht3DD/R46nWBqV +/Aw== X-Gm-Message-State: AHQUAuYo88bwR43Jc7dskn+JsGDpu6Ptppf5JSg//GalHfz0Sq8f9cpl eFmeCukE4McfLQjTWLoZdbLpcQHO X-Google-Smtp-Source: AHgI3IaNAMLiRAMzIOYSRij7STq5gHFnwE/NhXDVUafFplUXMnyG4cFLzzfQpxWtdM5ivGNCaySpkA== X-Received: by 2002:a5d:4843:: with SMTP id n3mr4316242wrs.212.1549388529834; Tue, 05 Feb 2019 09:42:09 -0800 (PST) Return-Path: Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id d2sm11756965wrs.97.2019.02.05.09.42.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Feb 2019 09:42:08 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Laurent Vivier , Riku Voipio Subject: [PATCH] linux-user: Check sscanf return value in open_net_route() Date: Tue, 5 Feb 2019 17:42:07 +0000 Message-Id: <20190205174207.9278-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Coverity warns (CID 1390634) that open_net_route() is not checking the return value from sscanf(), which means that it might then use values that aren't initialized. Errors here should in general not happen since we're passing an assumed-good /proc/net/route from the host kernel, but if we do fail to parse a line then just skip it in the output we pass to the guest. Signed-off-by: Peter Maydell --- linux-user/syscall.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) -- 2.20.1 Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefano Garzarella Reviewed-by: Laurent Vivier diff --git a/linux-user/syscall.c b/linux-user/syscall.c index b5786d4fc1f..894678aa8b4 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6762,9 +6762,15 @@ static int open_net_route(void *cpu_env, int fd) char iface[16]; uint32_t dest, gw, mask; unsigned int flags, refcnt, use, metric, mtu, window, irtt; - sscanf(line, "%s\t%08x\t%08x\t%04x\t%d\t%d\t%d\t%08x\t%d\t%u\t%u\n", - iface, &dest, &gw, &flags, &refcnt, &use, &metric, - &mask, &mtu, &window, &irtt); + int fields; + + fields = sscanf(line, + "%s\t%08x\t%08x\t%04x\t%d\t%d\t%d\t%08x\t%d\t%u\t%u\n", + iface, &dest, &gw, &flags, &refcnt, &use, &metric, + &mask, &mtu, &window, &irtt); + if (fields != 11) { + continue; + } dprintf(fd, "%s\t%08x\t%08x\t%04x\t%d\t%d\t%d\t%08x\t%d\t%u\t%u\n", iface, tswap32(dest), tswap32(gw), flags, refcnt, use, metric, tswap32(mask), mtu, window, irtt);