From patchwork Sat Feb 9 03:38:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 157908 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp240570jaa; Fri, 8 Feb 2019 19:44:58 -0800 (PST) X-Google-Smtp-Source: AHgI3IavWmd5IqKPn2Cff6xzjvJ8vh66wyvjo9I4yJFjdLEPisY+IVlgcxXlfMXIVTBmq0Ju9Pca X-Received: by 2002:a7b:cc99:: with SMTP id p25mr1187096wma.100.1549683898061; Fri, 08 Feb 2019 19:44:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549683898; cv=none; d=google.com; s=arc-20160816; b=qjd/inCv8aX94wF89yP3YlD5UNIm9WRf/5JNnoKzo3XacqOnszW9epbpSXROS3fGnS pmtGfQof5jdz6WbkKTHU6U0+OW7ixhgnoNA5gltZftbyfAk+By/ejCB9FfTSKzSZugAT DXrc3r4YPFnT6qx6Ff7tnhAftrudZqq8N8yFuC89VXOhba+MST0C+mF5tU0YumDCpFhv YJCXpBfHNhHmwlHYC8DZigesB4UMBs91+cignydBkaIZiE3EG0Ic3OEzVPvxhjcKzJMk jX8syobLNK35rHt6CfpvZp7OeUbxfT5fyTzaGxfcDwPAY7TM76PwBqElK/8z32ghHHD/ ejvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=84vmGP9Bty50VmJ29TzqnMG7INxyOeuGKn+/z1pdICA=; b=cchzY4yyphShB7kElsuXsrvZ28W43bPfWR2gWUpMJMUW+5ldNiec8lfW/j66FxJ9Mb 9pM62mNt56eDyZbacGc3MXfNDn1OKswC28/CR/I8ti+u7H0/NzjMGqRhX64jP+tpjYr9 J6k30Jr6JrGr+tUfvOBtgkrGeG2h35EaPARUc2cGElga4aHuaXRo9S6vU47ySsXDBgWW AVDmLZgeUTd5AN+/ZM8RJo1Qjfvfp55wNtfJO2RvgEPhUenSA7Ua4kb3d5mEYcTIZWT6 Z2YMzr3jslDMLEiyPF85iOHBuMXerFqUNxNt+7U7EcAqf6naek9wH14OHIiJS8tvOr1j e4sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=wu62oQBQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u62si3053167wme.199.2019.02.08.19.44.57 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 08 Feb 2019 19:44:58 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=wu62oQBQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:39102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsJZZ-00029f-0D for patch@linaro.org; Fri, 08 Feb 2019 22:44:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsJTk-0006gB-LA for qemu-devel@nongnu.org; Fri, 08 Feb 2019 22:38:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gsJTj-0000S4-SF for qemu-devel@nongnu.org; Fri, 08 Feb 2019 22:38:56 -0500 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:36884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gsJTj-0000Rm-MP for qemu-devel@nongnu.org; Fri, 08 Feb 2019 22:38:55 -0500 Received: by mail-pf1-x42b.google.com with SMTP id y126so2586330pfb.4 for ; Fri, 08 Feb 2019 19:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=84vmGP9Bty50VmJ29TzqnMG7INxyOeuGKn+/z1pdICA=; b=wu62oQBQY28AB91UYVCsO5eEqin4VqK88mxjIYyJX+dl3378t/R1/xckDllnbdTazM cOC/R9pJyo9OuItgKbJGPSDmk/xY8arci1q5M7wmxlHDMEPvlXN9NzBOE//u+97b+SpH ffm+DLXqYjFnbXgCS750n45P7rFPttmAii+MmLPv1xmXwsSFuUfhi1IuFpUhHtWTYoKE V6/TOAxcMM1QwmWTRjFeVtk5LFoujXF4x9ZbpRCZfQvZWw4ox7/VhUBQyavOlN4C9lEe Ogp3cSwU1b9U2CqLXvpc4a3QxIcaVqG/qiIE4g4HTcc53U+5dheXz7b0E9sNkWYALgDh 4atg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=84vmGP9Bty50VmJ29TzqnMG7INxyOeuGKn+/z1pdICA=; b=CE9Ch21BLm9y6XzAfPUraJTDKnXiSMucj+jFFAeX98dfzU8qV97j86MpbCuFejmawF lpDk+D1hVkh5d4axkvDi9skj93cH3b1m+ZSlCwZvMn75CcBFXYzPBdJJ5HmEfzkGuHIs 5lm+Ax8wUJM7vhQZfswnh//dH1rTBX68uS2OZM0hpTkE3mOskMoj00MZjN23KWbRBUzJ jYnKd+VjxUxIXM6miRaqNdyVObPjAe6FcKQ6yZZ/K+K8yQclvh3BnSpA82EE1IstZnM7 oNFtYTU2Yw1s5u+6Cux4wJn046wh6I9a6Y0DB+kRiP62KOi+se87WR6+pmRdh7n+9X9g 2wiQ== X-Gm-Message-State: AHQUAuaYYrRcgQbmRCFyl0MuHVw1e306fkI9t9KJuDHoFiWKlEDmdpjD XEoMKqPyhGmAMxvF+TIzlrSLNrnWL/o= X-Received: by 2002:a63:125a:: with SMTP id 26mr15247475pgs.314.1549683532258; Fri, 08 Feb 2019 19:38:52 -0800 (PST) Received: from cloudburst.twiddle.net (97-126-115-157.tukw.qwest.net. [97.126.115.157]) by smtp.gmail.com with ESMTPSA id s84sm6340737pfi.15.2019.02.08.19.38.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Feb 2019 19:38:51 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 8 Feb 2019 19:38:36 -0800 Message-Id: <20190209033847.9014-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190209033847.9014-1-richard.henderson@linaro.org> References: <20190209033847.9014-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42b Subject: [Qemu-devel] [PATCH v3 01/12] target/arm: Rely on optimization within tcg_gen_gvec_or X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Since we're now handling a == b generically, we no longer need to do it by hand within target/arm/. Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +----- target/arm/translate-sve.c | 6 +----- target/arm/translate.c | 12 +++--------- 3 files changed, 5 insertions(+), 19 deletions(-) -- 2.17.2 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e002251ac6..a12bfac719 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10648,11 +10648,7 @@ static void disas_simd_3same_logic(DisasContext *s, uint32_t insn) gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_andc, 0); return; case 2: /* ORR */ - if (rn == rm) { /* MOV */ - gen_gvec_fn2(s, is_q, rd, rn, tcg_gen_gvec_mov, 0); - } else { - gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); - } + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); return; case 3: /* ORN */ gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_orc, 0); diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index b15b615ceb..3a2eb51566 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -280,11 +280,7 @@ static bool trans_AND_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_ORR_zzz(DisasContext *s, arg_rrr_esz *a) { - if (a->rn == a->rm) { /* MOV */ - return do_mov_z(s, a->rd, a->rn); - } else { - return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); - } + return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); } static bool trans_EOR_zzz(DisasContext *s, arg_rrr_esz *a) diff --git a/target/arm/translate.c b/target/arm/translate.c index 66cf28c8cb..9d2dba7ed2 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6294,15 +6294,9 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) tcg_gen_gvec_andc(0, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); break; - case 2: - if (rn == rm) { - /* VMOV */ - tcg_gen_gvec_mov(0, rd_ofs, rn_ofs, vec_size, vec_size); - } else { - /* VORR */ - tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, - vec_size, vec_size); - } + case 2: /* VORR */ + tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); break; case 3: /* VORN */ tcg_gen_gvec_orc(0, rd_ofs, rn_ofs, rm_ofs,