From patchwork Mon Feb 11 23:52:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 158040 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3202906jaa; Mon, 11 Feb 2019 15:59:43 -0800 (PST) X-Google-Smtp-Source: AHgI3Iaz8m0P+r4pM1QG4Ec7tklk5xHpplRIUVJyFRWpr0L1ea+tlED3KhrnA9GIRkgRJIWRO5// X-Received: by 2002:a25:9881:: with SMTP id l1mr662129ybo.317.1549929583153; Mon, 11 Feb 2019 15:59:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549929583; cv=none; d=google.com; s=arc-20160816; b=XVNQ9rimYOUkrt/G/318CT8s3QfYzYAxbtfWubHkcJw/oQRYm4vqmJ71/7RxUuAZsD I+neb9T3F0TsgZwOinJ/Cwe2ADn7Y24+GdkkcZZnMR9CVawfU2ZFKq/jfXcuJV6/p97N F4t51o1nWb6l4C7VDxscxfeHJXZ6dfnuCc3s0pMUOQZTvGx9+mMjXQh3W5254Hhp9Hrg aY6Jyc1k6fUzBqFPENkXuxitM94dlUmi+vBKEejb0KVmBG37GlZS3P/zlXe0ZxEda2I+ SzpTJxRQCV1QLTkGyoP/zqKJ7hXHEUhGFIUe03buOuldxWoNBrRlk4mmNSi8QTrJasPK oyug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=MeANllhl1EJDV5sKJLIW0fjvttmmw3UOBcxKU9DzMxw=; b=Dp8qfz4xd4GN3Oco2V27s8wS0PfOImELkmvmQQYe1xUuYkV8uaKGq9naRRJsHA/iCZ RVK31GvQns1Ihg5fmdlLA19itoYSYKT9IV5rv8otNmKt+qgS9pFIlowS7iASLq7F0lED UNeBJ4JSomRoK3ETu+uHasNih9zeX0OjFTIOCVbMD3kTO1Zvb0YI4/ZPQTJv7pi4Ylt2 eHECmOhxtlynEsrmoV+E1JAhE8eVnWmCJ4Rgv1x9buoLsSxjE3+aN0k1uPOoJd73uV7N sIcSMa8jJmmz54E/IZF/h1G+P47i+BfYOHAqqj9djj7j7bmx5cq4+7yEuVlNIJxX40LR Xpig== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="TrSgiAL/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e189si6548113ybe.467.2019.02.11.15.59.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 11 Feb 2019 15:59:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="TrSgiAL/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:58210 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtLUE-000125-Jd for patch@linaro.org; Mon, 11 Feb 2019 18:59:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtLOE-0005Mj-H3 for qemu-devel@nongnu.org; Mon, 11 Feb 2019 18:53:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtLOC-0004Xm-0t for qemu-devel@nongnu.org; Mon, 11 Feb 2019 18:53:30 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:47054) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtLOB-0004Ph-Pl for qemu-devel@nongnu.org; Mon, 11 Feb 2019 18:53:27 -0500 Received: by mail-pl1-x62c.google.com with SMTP id o6so314943pls.13 for ; Mon, 11 Feb 2019 15:53:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MeANllhl1EJDV5sKJLIW0fjvttmmw3UOBcxKU9DzMxw=; b=TrSgiAL/MtIe9pzq+6kN0cRmyLVfcXswfXw6qGRgRQwtqtbTBMQCBAwEsmK9LOqJvD /aKUO9PrtqOOeZ2SDE8luouQaVSKfFjMvJzNhbONSWAooymwey1WlIrhdrQORQdhekvG tFhwV+hAOVmJ2GXWVEHfCIH/p7M8EOsKgyYONPw2kuM4Srwqm4KVlm7L62z9F1RmMA0G 1W3ak63PQQEsE5bqWrbGDEXyOhTzY3A1gWZZMntmy5eRpY6cxs8EeBGrEayD91eRnrsK j2aBlB1B/3gpsVuUpEo4vtoXCcWtlYKrPh3eWxce8pGtBrwN4OGU8P96TBtPhbdzl/7G wkXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MeANllhl1EJDV5sKJLIW0fjvttmmw3UOBcxKU9DzMxw=; b=J8U9Erse/AdNRXcL/NzG0j1IG3kDQe0zvoW+1PtOH1+1nZXnHCnGwZ36mjnnj6zOtR x5PbOr3clJvAKpxzKfPUJuTqADrAqMwQAo8Zh2IGD/jKTMCgJ+UDkpaSFZg1MmeTvtfG CRdPjnuC1U/UQlN6s0xsbEqs4yWI6SOpHCiY4D903BPN3alQ1R4CjRWO4G3r5heg2JdF w5nM9iTNuQSxkiJFqFa209PgkZWnXRAumSWULzC0zaGkUeChUTsQ4hKPbwIK9IPDCm3f qz5F5T4D7I1ERL/TEXFGvvVb+y9Q/xHFOdR9yE6MIsuTz4WlNAYAVJESg42RKBDJ7/Vj O4LQ== X-Gm-Message-State: AHQUAuYt6f0SO5crEi645+B6ET8xI4+hQyhkV6Lf4DsRrd70n+BOrqDu +CFqWKFasVmZ4iP+01QyVtaI3/hpgZc= X-Received: by 2002:a17:902:c5:: with SMTP id a63mr899856pla.267.1549929190749; Mon, 11 Feb 2019 15:53:10 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id c4sm11861031pgq.85.2019.02.11.15.53.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 15:53:10 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 11 Feb 2019 15:52:37 -0800 Message-Id: <20190211235258.542-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190211235258.542-1-richard.henderson@linaro.org> References: <20190211235258.542-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::62c Subject: [Qemu-devel] [PATCH v3 07/28] target/arm: Assert no manual change to CACHED_PSTATE_BITS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" These bits are stored elsewhere; changing env->pstate has no effect. Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.h | 4 ++++ 1 file changed, 4 insertions(+) -- 2.17.2 diff --git a/target/arm/translate.h b/target/arm/translate.h index a24757d3d7..296d1ac72c 100644 --- a/target/arm/translate.h +++ b/target/arm/translate.h @@ -209,6 +209,8 @@ static inline void set_pstate_bits(uint32_t bits) { TCGv_i32 p = tcg_temp_new_i32(); + tcg_debug_assert(!(bits & CACHED_PSTATE_BITS)); + tcg_gen_ld_i32(p, cpu_env, offsetof(CPUARMState, pstate)); tcg_gen_ori_i32(p, p, bits); tcg_gen_st_i32(p, cpu_env, offsetof(CPUARMState, pstate)); @@ -220,6 +222,8 @@ static inline void clear_pstate_bits(uint32_t bits) { TCGv_i32 p = tcg_temp_new_i32(); + tcg_debug_assert(!(bits & CACHED_PSTATE_BITS)); + tcg_gen_ld_i32(p, cpu_env, offsetof(CPUARMState, pstate)); tcg_gen_andi_i32(p, p, ~bits); tcg_gen_st_i32(p, cpu_env, offsetof(CPUARMState, pstate));