From patchwork Tue Feb 12 04:57:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 158082 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3421805jaa; Mon, 11 Feb 2019 21:12:41 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ8p94U28vjAVYunSKrpGrPRBnMFfXp+ZZ+C7NQnUl8zHhELjiEg4+3EkPusq6I/cb3OqiZ X-Received: by 2002:a81:274e:: with SMTP id n75mr1431163ywn.404.1549948361285; Mon, 11 Feb 2019 21:12:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549948361; cv=none; d=google.com; s=arc-20160816; b=zqA+XMJwY2wSomNijLJYIAMJLjEDTMGZVT7/wEnWLFU/EVVUykLcrOp8egDr3EW9GS wrJ6GXjT6Et6cIoFXYnaZKIJ5J5U3crvdH/UsWsK9IvRycHXjesvWmDs8agk9pb2x9Zh Bn+yJoer7QU5mZo6phCCNy7WRZkepwByrDzsRil1HpbL7mEAYkyXFsZkgi0TSDIsMHw9 MPorF7JyMmUT/+EmJl7XBtumgxAkjrp3sJ3uIpfD0tl3/FT1AAQXa8A+GJAtY60OjRic MejQZ4W2yZLkVcRqPlpjf2j1NU2adkshNwTldvCANBZIrY780v1wXlzq2e9dKIU1GDre oq2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=ify8An1F5oEc1E0d7PvrPQjhI7bRHnQasaxWD/TrazQ=; b=ZxS7Z98Jv+GZX7oCbr2tOo8vUNysqp5vlrAGaGNefcrXbdlq2LOYg7FOKcoB0CMZVG ghBafzdS6ky1V1qpKH17ZPCxg8wSnRMB3C3LhtdtLcEB3mgMQo18bRoexuztdfuz36M/ 0IW57Mup5xFEOOCUiKRHhq9FkAdcAWLrGhlA3qG7kchIGWkkBurh+HEwXDzjyo+FPPo6 vGtIyCnFehBfiHruRCKxxIHi7AC+lrr6HNv/GXcI2V+kNWvsDLzTY9klH/OshnAVJeRf 7w1HYhxSAJvb8brdoDJfZVu7nzz7wxuXOppthlW5IdJGpVKtb654jkk/aD0GsHf3zz8Y BibQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lzQCyZkM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h7si29240ywm.382.2019.02.11.21.12.41 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 11 Feb 2019 21:12:41 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=lzQCyZkM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:33289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtQN6-0004ze-LP for patch@linaro.org; Tue, 12 Feb 2019 00:12:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtQ8y-0002fL-91 for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:58:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtQ8n-0001sw-FI for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:57:56 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:33116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtQ8l-0001kS-UT for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:57:52 -0500 Received: by mail-pl1-x630.google.com with SMTP id y10so705862plp.0 for ; Mon, 11 Feb 2019 20:57:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ify8An1F5oEc1E0d7PvrPQjhI7bRHnQasaxWD/TrazQ=; b=lzQCyZkMukTDBiTt+02mJHjooTiWtMmuy2jN+2M2Uow+1eYXtafUlB8JWmZaw5mPRW N0OQQaPIBp0hpZHZHt8p3uMZXPYn7chLU/YnLknNxl+mkF+4QHZ1iscx1X07n7pYPzCA VLZnBrOChRxK9H/77RNQzni9/dORmPDlIUJUK9Pb+tFNvrcNyK7h5SEdL9KPCfhZ2hUg BSHA9oHB6eyksNlzgg1QiWlfR+ZfL6pYK8rA3iDwR8Qc2gXe49BHkJjfBDNISlU83lWZ 6dWnSWOMcJq/+ndzfS34oaeE3wQScpLvpzcc2WOpMvBeMpo7mg8gXYmncShpyW3l539Q EQdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ify8An1F5oEc1E0d7PvrPQjhI7bRHnQasaxWD/TrazQ=; b=SHUZaLXxY2labJS/dIwBNtSSiwRGEeF+yBFxDSBHYKDLKfOJ+l0gv9z9djvdQy1LLT 3GyCOAL+Gc/nFCYFvI58Bl7Q9BO39/LkLbR9dXGs1C3Z17Q/DXICGPNidGJOmPBn25WZ Augz1fkq8vhANIoafZ5ii5R88KYhUk5PiqDLalwW1l5DDmVGmXAgz+T0pBqD5FTbr6Jy 7mg5F4XyvQP+ZgrEbICiNfbJ/u/yXzJ0XrSHgr7thXJRnN59xaK1iiJkeUxJVzmoP/CM Fy7XR2iTgzHxlemt4gBToGe2sdlqpwrjaaCtWS2/FJdZw4Nn0GCbT+geBMPxNrwPvsBU Yr/g== X-Gm-Message-State: AHQUAub8lu9WTbxeMk0ID8SLcWhMftLsLqewx9dRQMSCg1PIk9f6Ud7t leCyVcZc9pxR908lfPlLFapqL+ypgcU= X-Received: by 2002:a17:902:2a66:: with SMTP id i93mr1756995plb.128.1549947468268; Mon, 11 Feb 2019 20:57:48 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id a90sm22088923pfj.109.2019.02.11.20.57.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 20:57:47 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 11 Feb 2019 20:57:17 -0800 Message-Id: <20190212045721.28041-21-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190212045721.28041-1-richard.henderson@linaro.org> References: <20190212045721.28041-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::630 Subject: [Qemu-devel] [PULL 20/24] target/hppa: move GETPC to HELPER() functions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Sven Schnelle When QEMU is compiled with -O0, these functions are inlined which will cause a wrong restart address generated for the TB. Signed-off-by: Sven Schnelle Message-Id: <20190211181907.2219-2-svens@stackframe.org> Signed-off-by: Richard Henderson --- target/hppa/op_helper.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) -- 2.17.2 diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index 6bf478e7b0..268caaaa20 100644 --- a/target/hppa/op_helper.c +++ b/target/hppa/op_helper.c @@ -81,10 +81,8 @@ static void atomic_store_3(CPUHPPAState *env, target_ulong addr, uint32_t val, } static void do_stby_b(CPUHPPAState *env, target_ulong addr, target_ureg val, - bool parallel) + bool parallel, uintptr_t ra) { - uintptr_t ra = GETPC(); - switch (addr & 3) { case 3: cpu_stb_data_ra(env, addr, val, ra); @@ -109,20 +107,18 @@ static void do_stby_b(CPUHPPAState *env, target_ulong addr, target_ureg val, void HELPER(stby_b)(CPUHPPAState *env, target_ulong addr, target_ureg val) { - do_stby_b(env, addr, val, false); + do_stby_b(env, addr, val, false, GETPC()); } void HELPER(stby_b_parallel)(CPUHPPAState *env, target_ulong addr, target_ureg val) { - do_stby_b(env, addr, val, true); + do_stby_b(env, addr, val, true, GETPC()); } static void do_stby_e(CPUHPPAState *env, target_ulong addr, target_ureg val, - bool parallel) + bool parallel, uintptr_t ra) { - uintptr_t ra = GETPC(); - switch (addr & 3) { case 3: /* The 3 byte store must appear atomic. */ @@ -151,13 +147,13 @@ static void do_stby_e(CPUHPPAState *env, target_ulong addr, target_ureg val, void HELPER(stby_e)(CPUHPPAState *env, target_ulong addr, target_ureg val) { - do_stby_e(env, addr, val, false); + do_stby_e(env, addr, val, false, GETPC()); } void HELPER(stby_e_parallel)(CPUHPPAState *env, target_ulong addr, target_ureg val) { - do_stby_e(env, addr, val, true); + do_stby_e(env, addr, val, true, GETPC()); } target_ureg HELPER(probe)(CPUHPPAState *env, target_ulong addr,