From patchwork Thu Feb 14 12:51:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 158372 Delivered-To: patches@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp1325842jaa; Thu, 14 Feb 2019 04:51:18 -0800 (PST) X-Received: by 2002:adf:efc8:: with SMTP id i8mr2939085wrp.164.1550148677974; Thu, 14 Feb 2019 04:51:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550148677; cv=none; d=google.com; s=arc-20160816; b=aM7MbeklipOhL9LmVMFbMDpxxIskfKTmLtuH8QlPmfFC7/PePLhoOCmjgNv2nrggCT bJXvbywnQo9pkXHzvdMOcvd5GXdPXXTgSsNJlfq5qa7GnrVEsCfaHU1eI8EWgUj36zUx Fjlao905CHTRIGQxZSjPi+nisKVmVkjKGGbACszpTJG3EZCN5seGnRSnPJRi5YiuM0KG SMe/afQOgq5vcfawGUOWICbUGJ3soMdGahcvBrOh5sHsKaxWdbMBnslbo2VuJJX0/qsB k00leJ4zFmwL8L3+9HCw6bf/xp98vSYhAYV+HSjqsx7Q9j2OjE0cL4So7I3Vp9yA3F/k SVxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=G2EhbTfL6RgiBoe8p2qGDsQHbXzW305CIfRgaTSzQks=; b=wOGMJgadHpgcTjG/Q/Z71EhCA7KAaYUkKFymBMLvi9kVXY42SlzvIvq+v8IPPNeZLO DPYiiVwL6gn9yweWiIKxCtOpCfkraRg7BWIkClmfXInyBGmlXsYzIyemtTW9E736+UoU jBAumE7dJ/3GwPH3l+D/vdez9Yi/CQn50UlJ0Dwm9XeLOB/SgSokBGJEG222v9fhcB// KM8fAYzqDd8H+LEzOV6juLoF7XYQxE1tlxfhsjQRq108zf+xG5qE9nj6lVNQoPRd4clM 24ZZxbUWJWFMBJ2lM9jXHELgOr4BhzazatRpK98otVvApBGuVxmczt/7+Zz2ExzGBQnW zOLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tpiiNAkR; spf=pass (google.com: domain of peter.maydell@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=peter.maydell@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id j5sor1517192wmh.3.2019.02.14.04.51.17 for (Google Transport Security); Thu, 14 Feb 2019 04:51:17 -0800 (PST) Received-SPF: pass (google.com: domain of peter.maydell@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tpiiNAkR; spf=pass (google.com: domain of peter.maydell@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=peter.maydell@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G2EhbTfL6RgiBoe8p2qGDsQHbXzW305CIfRgaTSzQks=; b=tpiiNAkRlt5Mq4oVeOBPjfNDjT7rd4+uEtR3yNh8IAy1r9JhNNpqaGyNA/Lmqzi5H5 UgmZ9cZxBCcYcWb1qX3LHxAsrKbiiQc0A2bKR4WIBGupsZJe4f5/mkkkKdZ4jv/ZBeam Vy+ch7yIi9BOPRwYHjfQwrNyK1rk/6nMb6N/uOEOncQTiUhdCxeLqh7ltCYX9ChyCQyl Kci99sFGR5WNrhixpiyvt1xmgTjHaaaiNRuydLEW7pA+e/uzCYwBItJDAOWJkzK7EeUS OfMKw6po7mOV0YsbcXfFqoDnsD7xIZwTLmd4xoj4EjpD6EX7E5rIxv3C3whAGwU2GJjj uQqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G2EhbTfL6RgiBoe8p2qGDsQHbXzW305CIfRgaTSzQks=; b=dFVPT6XE5mel+Gy+KlZt84C13wSUgHJcQCUae02Py94I/TsKSBaICK2TvFxBM21lmd 0ed7fbuIjHxUnXd3Pk+l3Z7Pu0EJyqVnbZC9dM4kxiAtD3Bf2qtmCHD4lFlOTL70EVkw d9FwlMu09T3W8HNhIWIOJfCNe12VYCXS1SkWbbiiGWAwuKnuo/kJim9ElqfZ7GN9Msam tUjaIHTTp4Amb1ep4pV4pjh6M9rVeu7A+khzZKG2dEqbG9bRVctIoeftYnRlXhRqN93d 4923XH9UsErLHzBe+pWyZUU1bt0GDjiWHyYLpfo3787HBTZAQ/s0Kg8It2DMCElCC+9m zZWQ== X-Gm-Message-State: AHQUAuY/ZGdbj8EcEwCtTFiBALNKIKp/cxpyEY0/wTgr/5oXIyun9ugG vnFhuWe0JKqntNhy0ebM8/4C4Ux/ZZeQWYaM X-Google-Smtp-Source: AHgI3IY1Uv3H5pTIkg0nRJwnQaPuouQY+kNSeZKZ4hYC7hJl/dWEypKbgTdAsHmbhI2Z2yPaKxKD4g== X-Received: by 2002:a7b:cf03:: with SMTP id l3mr2650197wmg.14.1550148677565; Thu, 14 Feb 2019 04:51:17 -0800 (PST) Return-Path: Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id j3sm1488073wmb.39.2019.02.14.04.51.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 04:51:16 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: patches@linaro.org Subject: [PATCH 07/14] hw/char/pl011: Use '0x' prefix when logging hex numbers Date: Thu, 14 Feb 2019 12:51:00 +0000 Message-Id: <20190214125107.22178-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190214125107.22178-1-peter.maydell@linaro.org> References: <20190214125107.22178-1-peter.maydell@linaro.org> MIME-Version: 1.0 The pl011 logs when the guest makes a bad access. It prints the address offset in hex but confusingly omits the '0x' prefix; add it. Signed-off-by: Peter Maydell --- hw/char/pl011.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1 Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 29f4e5eb224..e5dd448f854 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -143,7 +143,7 @@ static uint64_t pl011_read(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_GUEST_ERROR, - "pl011_read: Bad offset %x\n", (int)offset); + "pl011_read: Bad offset 0x%x\n", (int)offset); r = 0; break; } @@ -232,7 +232,7 @@ static void pl011_write(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_GUEST_ERROR, - "pl011_write: Bad offset %x\n", (int)offset); + "pl011_write: Bad offset 0x%x\n", (int)offset); } }