From patchwork Thu Feb 28 11:08:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 159340 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp511688jad; Thu, 28 Feb 2019 03:20:57 -0800 (PST) X-Google-Smtp-Source: AHgI3IaG278yO2/hWppOjVlScSlaNeQYLdChVDBy6tm0yEv7wUy6sSqufEmQ2Syb9Ukc59Wmg6pp X-Received: by 2002:a81:67c1:: with SMTP id b184mr5136755ywc.39.1551352857543; Thu, 28 Feb 2019 03:20:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551352857; cv=none; d=google.com; s=arc-20160816; b=ujpRzO20roaJv4CUkR4+qNoHlssy6iHvyLPkuRjpO/hDenJqMdv2ZoBqRMEuxzYuCt VeDWHLViGqIsyZUJ6b43mMCFDtYeTJdO35dG2TA/XjWpmOxQNqQCg3+kVw6gwU5zHpXv vK6joH0LFy6tUiNQuc/c/STCsKGk7MXejXTex1hBXsOv/uJYPmFtGV07IQvI0h2bD6/R +77BK8E3NExqFUw/NLFvIATr+8aJNtMlcWgt7iaRpUyYgdA63/jS1vsgtZP/GtMxwAIf 5MWab9VvCCTmXwcsCjEwlvqEn30F6bNq2VBsS91zAye9GV+ZzqXIXgVhOJX2KlAcdRDw xJ8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=ejoTTtAG3thNP/OE/0nhDpkNuDKj3vQqqst4nOMMRsg=; b=N1LYbe6H6oBReSX6WnpEJtH0K6BGBL3pjB6A8sTLfayYEZiovQCkleH4SzMv9wRHaz 8fVt/FiaWSTe6T4CUhwHHhiN9N8i3RxoXco7JwaenHF7XRYZC6BB7q1zGfNb+yOWYkV+ sRuK8HsZOuOG8GkIQiay5RC+peo6VaMtutEi43KwfJA9RxHb9XtUFN5lRO3a1uWqQBsX qFVzE7LyIVUWBly18HB39hqYUUOKwB3yFZPYRZR4aUcqwYyBXXaYeks56ArzmbkJvmT6 xbjKLvUua6CaMGzdPhBD1n9nFWa+oJNSxezPlIBw8vZ9JxL4Eh8TipYG9Y1/hYD5Prwr Zidg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eyFFMEFL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j11si10139020ywc.156.2019.02.28.03.20.57 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 28 Feb 2019 03:20:57 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eyFFMEFL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:36292 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzJkH-00010L-1e for patch@linaro.org; Thu, 28 Feb 2019 06:20:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzJZE-0001dL-Ox for qemu-devel@nongnu.org; Thu, 28 Feb 2019 06:09:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzJZA-0004Kv-VG for qemu-devel@nongnu.org; Thu, 28 Feb 2019 06:09:32 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:35364) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gzJZ7-0004DL-9G for qemu-devel@nongnu.org; Thu, 28 Feb 2019 06:09:25 -0500 Received: by mail-wm1-x336.google.com with SMTP id y15so8529936wma.0 for ; Thu, 28 Feb 2019 03:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=ejoTTtAG3thNP/OE/0nhDpkNuDKj3vQqqst4nOMMRsg=; b=eyFFMEFLHA7OCtRl5Gddh/da9BX0AKji4z3U2yCkX/hnjvTwtL9/bPMFqYxocBXbfY jykarqSjm4hlPQ2F22vq/Sb9CIIXc9EOM8HEfhz06DgOTV3nUIktd9gJ+KrK8LRl8T6o WKvhyhQGAjzxEpYHX1aB1bwXJy1kaTEYhAAPFrvzeDnek/u12es4/IyhAlrSbQl8LOi9 T6eWPlZcOLIXNS0GO718AzhzW23lPnPzk91exF9k/tBx1dEepL2DLxi5Gw/4Yf/ffLFF mQUNFfDau0lMFZhePcfPB0SuOHyRJovegDaLwSO9d1rIOHfW0nWboEh/CReTI5QAEn2Q y2CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ejoTTtAG3thNP/OE/0nhDpkNuDKj3vQqqst4nOMMRsg=; b=WG8Kdl+SsUC4b0QR542v5OeevX/Jh4hKxU81tUwH3xNEwUuoMLublqntbGfZcJqb+c y+o0FVEGKz0xw6mnECpfCvV9RZCCFD70bQj0TBLnGWS4hy4xlu54dD4MPDVhRNGaDL9E HxlHv5UkIyUqcHvNJtgVvk3c4v66QIzdx7Q22nHSnQ7JokE7hnKo2K95UHQmNwz9mZ27 4fIfiFCSbpSe53v6bsIs37P3c3qCGwAuxJ5d3d6yVxKWU2GknP7rCU5Z7HMtlNtqNnQ6 37M7TDmohKgqLuDNMRkO2QiDJjWU0+/e2e6A6yOSfVXo2dNCH9rfKATDLljkDaqWbter L9dQ== X-Gm-Message-State: AHQUAuZmDyTRaV0Kb79x8PSm41VNPhkIkogW9MV3FxSk47hBBF67muGg 5UykXz+qd6hJw4uPPM/wwAsmPBsPIYk= X-Received: by 2002:a1c:7a1a:: with SMTP id v26mr2422405wmc.129.1551352163831; Thu, 28 Feb 2019 03:09:23 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id c17sm13153241wrs.17.2019.02.28.03.09.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 03:09:23 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 28 Feb 2019 11:08:32 +0000 Message-Id: <20190228110835.16159-14-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190228110835.16159-1-peter.maydell@linaro.org> References: <20190228110835.16159-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::336 Subject: [Qemu-devel] [PULL 13/16] target/arm: Implement FMLAL and FMLSL for aarch64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20190219222952.22183-3-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/cpu.h | 5 ++++ target/arm/translate-a64.c | 49 +++++++++++++++++++++++++++++++++++++- 2 files changed, 53 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 3e545a2b146..8f52914649d 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -3404,6 +3404,11 @@ static inline bool isar_feature_aa64_dp(const ARMISARegisters *id) return FIELD_EX64(id->id_aa64isar0, ID_AA64ISAR0, DP) != 0; } +static inline bool isar_feature_aa64_fhm(const ARMISARegisters *id) +{ + return FIELD_EX64(id->id_aa64isar0, ID_AA64ISAR0, FHM) != 0; +} + static inline bool isar_feature_aa64_jscvt(const ARMISARegisters *id) { return FIELD_EX64(id->id_aa64isar1, ID_AA64ISAR1, JSCVT) != 0; diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index c56e878787c..d3c8eaf0893 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10917,9 +10917,29 @@ static void disas_simd_3same_float(DisasContext *s, uint32_t insn) if (!fp_access_check(s)) { return; } - handle_3same_float(s, size, elements, fpopcode, rd, rn, rm); return; + + case 0x1d: /* FMLAL */ + case 0x3d: /* FMLSL */ + case 0x59: /* FMLAL2 */ + case 0x79: /* FMLSL2 */ + if (size & 1 || !dc_isar_feature(aa64_fhm, s)) { + unallocated_encoding(s); + return; + } + if (fp_access_check(s)) { + int is_s = extract32(insn, 23, 1); + int is_2 = extract32(insn, 29, 1); + int data = (is_2 << 1) | is_s; + tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, rd), + vec_full_reg_offset(s, rn), + vec_full_reg_offset(s, rm), cpu_env, + is_q ? 16 : 8, vec_full_reg_size(s), + data, gen_helper_gvec_fmlal_a64); + } + return; + default: unallocated_encoding(s); return; @@ -12739,6 +12759,17 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn) } is_fp = 2; break; + case 0x00: /* FMLAL */ + case 0x04: /* FMLSL */ + case 0x18: /* FMLAL2 */ + case 0x1c: /* FMLSL2 */ + if (is_scalar || size != MO_32 || !dc_isar_feature(aa64_fhm, s)) { + unallocated_encoding(s); + return; + } + size = MO_16; + /* is_fp, but we pass cpu_env not fp_status. */ + break; default: unallocated_encoding(s); return; @@ -12849,6 +12880,22 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn) tcg_temp_free_ptr(fpst); } return; + + case 0x00: /* FMLAL */ + case 0x04: /* FMLSL */ + case 0x18: /* FMLAL2 */ + case 0x1c: /* FMLSL2 */ + { + int is_s = extract32(opcode, 2, 1); + int is_2 = u; + int data = (index << 2) | (is_2 << 1) | is_s; + tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, rd), + vec_full_reg_offset(s, rn), + vec_full_reg_offset(s, rm), cpu_env, + is_q ? 16 : 8, vec_full_reg_size(s), + data, gen_helper_gvec_fmlal_idx_a64); + } + return; } if (size == 3) {