From patchwork Thu Mar 7 14:41:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 159862 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp7557063jad; Thu, 7 Mar 2019 07:20:34 -0800 (PST) X-Google-Smtp-Source: APXvYqzF3CqHRTO4Zc3lLW9D/5OewCjqy6iFFfFa3pgqtaO+jXZ48qGE8D7a/T0ut724hyHjCJFs X-Received: by 2002:a25:61c8:: with SMTP id v191mr11489099ybb.489.1551972034887; Thu, 07 Mar 2019 07:20:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551972034; cv=none; d=google.com; s=arc-20160816; b=PRWwOCKFv89RtCrogW4lrjxjLn+FwquzuOt2bPPVmw/UlSi2IpExAY6IhI6KtkEBxo gknKZ8Q9rktY5xb+jTAL1AsT0mH2zLcrA6LSGRXW7dg8IpOOnG+0cT4uQOudB5aaL1Mp nH/lBiHVf3BQerKjrDjJD0cwfTIkmG5yWeMmKFGqofX4zFrnxqMnHxwFuc6VwBPz2pxF AMwKGqEtQARbQY8fqpd5Noeu2gn/NWgnVINpp++p5gVeEewhgg1GkP/IAG5NsiJyCYro FiAzpk3M4rSBw5DFYKR7UN8ufp7qbbmyRCNzxyFOve/A4QryZYYEbMZ5owREjDAJY041 NrmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=cUHnwenzYQtQY1IbWPFjUbKRuUhc078b1/cRTpEjyFA=; b=0GRn1Dgsm3ovOB7GKI/Nsv3aQr9B1NPmL8NwEdisv8zc4hRgGSIJFNwMp3V/xVhZ84 0p00NhNhNJNDSkPoV7alBmez///GqRqnITeEsZMTNkL9W3XqG9jxR7GK+gSGilE5aU7K 8ES/vunlMHWJ3ZbpZK/QBdtAnhhXrz/Lq1N4lr+PYFavxLV3haZR8dm33avkYLL5uLSn tHNcLNrT0eZV7eeju/R5XQ/1raYNpH4r/NVZwgVVMnhWCvxOy6xaO6Q00rYCAU6umHkJ aSdNSCSqy1fzaQUZ0YX3jgGe1vWyV2WIgUEbCysFR16IRjfaajW7y4OzhyrFOs0m4VGV 5ykg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=p7wsAO0k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x1si2945273ybf.441.2019.03.07.07.20.34 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 07 Mar 2019 07:20:34 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=p7wsAO0k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:53606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1up0-0005RN-9g for patch@linaro.org; Thu, 07 Mar 2019 10:20:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1uDG-0006ix-BH for qemu-devel@nongnu.org; Thu, 07 Mar 2019 09:41:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1uDF-0003T2-CE for qemu-devel@nongnu.org; Thu, 07 Mar 2019 09:41:34 -0500 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:36065) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1uDF-0003SU-5S for qemu-devel@nongnu.org; Thu, 07 Mar 2019 09:41:33 -0500 Received: by mail-pg1-x541.google.com with SMTP id r124so11423539pgr.3 for ; Thu, 07 Mar 2019 06:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cUHnwenzYQtQY1IbWPFjUbKRuUhc078b1/cRTpEjyFA=; b=p7wsAO0kTCgpXjAWbeacVRcEZC2oFE6Cmaqg7Nmb+ULH3efGYCUUBBKhM7egfIjc+b YReF5aKhMSBnYOHrzWjb8aEv7i4210CNa58ma6BNbpZN85voJfaPxfr8dDe7fJSLRFG5 7HybCf42tQTwfqiFrwI9TvoN8nPr3pkbO6jgmxzeVAzXAfMAdjEv9v0WtkYbnM8rD96L FvW31ejr2fwS98uD2B/lp8wH5fCX/gPYEp04JqQDLq8WiLjP1H04uPhky2t4YCWFyQMs N4lEZPI6Z38w2LwunhszxRMx/ddZeUGz2mr01Nb2ronAy5TU7Ra3YptASEjGFR/3IofG XI/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cUHnwenzYQtQY1IbWPFjUbKRuUhc078b1/cRTpEjyFA=; b=JLngBTTBoEkUrgEvogC/+SI0DKQSclnBDKG1ks66m4txLPBBf7M2ckkNj7xsWtzN5j vPdHDm1GTl+pGlbxSMLSeS/ERMIFMs3b8p54uUpOt3hF/Lg9GlMXvxFX8uk1jhp948MD 1qEGRFhOkQGyYNqWtoZVtXjmiNiVs8LByjnQiQIw2wrWe1x3Ku+mR4WbNxY8OQHGDJK6 S85mghPWF/A1ZwR2/tEjXl/M0PZ6PqTbF/RjBEBEvzX89Cjak+1asjUXgpeW6c5g8ft2 U0WSA5N+nKbM7oBTmx3Ci3cZYfQLDEQ5JiE9G229EdI2UVOHq62zRluGI5JRaqBtchPY t1aA== X-Gm-Message-State: APjAAAWOovAJIMe3di+ixt8fHM0/1T+78FqavaSoxw3i0aEyqDzt882q yVh5/ND1jU+qEu0aUtObmDKGP6q3/rI= X-Received: by 2002:a63:ed0b:: with SMTP id d11mr11637455pgi.435.1551969691953; Thu, 07 Mar 2019 06:41:31 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id p2sm6222838pgs.7.2019.03.07.06.41.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 06:41:31 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2019 06:41:20 -0800 Message-Id: <20190307144126.31847-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190307144126.31847-1-richard.henderson@linaro.org> References: <20190307144126.31847-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [PATCH 3/9] tcg: Use extract2 in tcg_gen_shifti_i64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 47 ++++++++++++++++++++++++----------------------- 1 file changed, 24 insertions(+), 23 deletions(-) -- 2.17.2 diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index deacc63e3b..34e0dbc6e0 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -1355,31 +1355,32 @@ static inline void tcg_gen_shifti_i64(TCGv_i64 ret, TCGv_i64 arg1, tcg_gen_shli_i32(TCGV_HIGH(ret), TCGV_LOW(arg1), c); tcg_gen_movi_i32(TCGV_LOW(ret), 0); } - } else { - TCGv_i32 t0, t1; - - t0 = tcg_temp_new_i32(); - t1 = tcg_temp_new_i32(); - if (right) { - tcg_gen_shli_i32(t0, TCGV_HIGH(arg1), 32 - c); - if (arith) { - tcg_gen_sari_i32(t1, TCGV_HIGH(arg1), c); - } else { - tcg_gen_shri_i32(t1, TCGV_HIGH(arg1), c); - } - tcg_gen_shri_i32(TCGV_LOW(ret), TCGV_LOW(arg1), c); - tcg_gen_or_i32(TCGV_LOW(ret), TCGV_LOW(ret), t0); - tcg_gen_mov_i32(TCGV_HIGH(ret), t1); + } else if (right) { + if (TCG_TARGET_HAS_extract2_i32) { + tcg_gen_extract2_i32(TCGV_LOW(ret), TCGV_LOW(arg1), + TCGV_HIGH(arg1), c); } else { - tcg_gen_shri_i32(t0, TCGV_LOW(arg1), 32 - c); - /* Note: ret can be the same as arg1, so we use t1 */ - tcg_gen_shli_i32(t1, TCGV_LOW(arg1), c); - tcg_gen_shli_i32(TCGV_HIGH(ret), TCGV_HIGH(arg1), c); - tcg_gen_or_i32(TCGV_HIGH(ret), TCGV_HIGH(ret), t0); - tcg_gen_mov_i32(TCGV_LOW(ret), t1); + tcg_gen_shri_i32(TCGV_LOW(ret), TCGV_LOW(arg1), c); + tcg_gen_deposit_i32(TCGV_LOW(ret), TCGV_LOW(ret), + TCGV_HIGH(arg1), 32 - c, c); } - tcg_temp_free_i32(t0); - tcg_temp_free_i32(t1); + if (arith) { + tcg_gen_sari_i32(TCGV_HIGH(ret), TCGV_HIGH(arg1), c); + } else { + tcg_gen_shri_i32(TCGV_HIGH(ret), TCGV_HIGH(arg1), c); + } + } else { + if (TCG_TARGET_HAS_extract2_i32) { + tcg_gen_extract2_i32(TCGV_HIGH(ret), TCGV_LOW(arg1), + TCGV_HIGH(arg1), 32 - c); + } else { + TCGv_i32 t0 = tcg_temp_new_i32(); + tcg_gen_shri_i32(t0, TCGV_LOW(arg1), 32 - c); + tcg_gen_deposit_i32(TCGV_HIGH(ret), t0, + TCGV_HIGH(arg1), c, 32 - c); + tcg_temp_free_i32(t0); + } + tcg_gen_shli_i32(TCGV_LOW(ret), TCGV_LOW(arg1), c); } }