From patchwork Sat Apr 20 07:34:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 162588 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp319673jan; Sat, 20 Apr 2019 01:07:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqwlLLv2MUr6aFEyA+Da01x2h7gCgp4obgGu/S52ZlAV2G7TqekFXGjaYyQuUs73n6PDmaID X-Received: by 2002:a1c:a70f:: with SMTP id q15mr5396632wme.28.1555747623488; Sat, 20 Apr 2019 01:07:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555747623; cv=none; d=google.com; s=arc-20160816; b=UqYV2HALcwEwufeY0/ycbHKHVype9ewsINR+cAAYxkVFJFHnJuSRNVNo7lHVIOj6oR UWfirXKhvNfoJdYB6RbmAVsSZ9itCpvGoPK5OVrklbSckJx+B2UHgP5jzAzKw2a2p61J qmp4epolxS5R0Gb7BzHOkTYzdspfUBZ/vcWG1Gjm0NJubcJUB/V2e5WvTvSGLS3/kLbF xvsIl70BHn40oPGKQfidRsnhKpLgoJJQMykrSmtoacVpyIJDUTrm0PSWZspue3kMPqUD RcrFRHBBoPnYqfrri7lUi4wl+JZoluYRQilY3qG45w0sjaB+lNYyjLexIMqQK/+kU792 3SUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=DFRXZD7NX2YzkScQMMhpfUbyNqz4uR3r+/iPuMUtZlg=; b=g2GVT5fzU/RxHde7sEqk7L1fVVcMYF8wMmPODVr9bQgjZB2QVEGPQN+6gqdU+RannQ tR5w/x6VNnp96BeGQwkrsqrqesY3U5Lr7BIA57KqqrnJQs6FmRF8yOnC7uBk++YCTWrC ZH5b39Hvh4Ca9teriwyOHTVihmcqm13CJ2P/y/0GoZzVe9O5WEVtyfhxTWLe11eTmYRX ZupzZm+/oYV9sE7jbFAAckp5s91vD+DhjhWtFkJxElaJyNMpxXtI5a4i7ST2uwE6MvA4 L6QEPItwtMbnBPsm/AqV5OZeiMuJFPEW5DXSpguBEouv2eMEYxBd5jm9md5RUXwmxtc4 Rtxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nZKcgEtq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i206si5161176wmi.133.2019.04.20.01.07.03 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 20 Apr 2019 01:07:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nZKcgEtq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:38523 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHl1a-0001ps-Ee for patch@linaro.org; Sat, 20 Apr 2019 04:07:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHkXY-00012z-Rb for qemu-devel@nongnu.org; Sat, 20 Apr 2019 03:36:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHkXW-0000nL-Ft for qemu-devel@nongnu.org; Sat, 20 Apr 2019 03:36:00 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:39176) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHkXW-0000Do-6g for qemu-devel@nongnu.org; Sat, 20 Apr 2019 03:35:58 -0400 Received: by mail-pf1-x442.google.com with SMTP id i17so3465924pfo.6 for ; Sat, 20 Apr 2019 00:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DFRXZD7NX2YzkScQMMhpfUbyNqz4uR3r+/iPuMUtZlg=; b=nZKcgEtqvIgJ6O+Fo0xRG00kc2v8zY51aZI/2Cjkhrs7zUZfhIcNnMDYUvG78zHPpS 6Aiddva4aNAKYnlcM2US7RYifgBCz8mDGjq4BTfZAL5Ed6r+supMHNwK9FesTN0I/5FJ 9g0uHQn7u6N8YD8uTm8whgK3rS2DADJqlGHRzBqs9tGPuZ85Nv1AQNqX1iA6OYkQAvUk 7c73Zer84KtBCmXAlFqxWpF8EsDIjzTn2IS2qzPQNr+tjlKzQKX2HlJb/8N9qSynZlNP 7R2b5YrwOVRCJQPJL2Rs2TNJQQzS1g65CGk944vhCov2n7sntJS6vBE/WzckO5XQQa4x X2KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DFRXZD7NX2YzkScQMMhpfUbyNqz4uR3r+/iPuMUtZlg=; b=OYJozarnIn+smp09jIOwljeaYXiI8UuWZ95IbFWRZb25D2mCnw2IEjUgZqZJd9hWmq Soa7TvX1qQPsR0YvNU7sRa3XZePm8DKCEqyKZBBfkZkv/Rz8IwsRotfQoXV2ceQW97PX K/hYfPuWlyLwJDVIwV+Et5UITcMB0pE5s1+31VcbozO/e4G+bwIlEMwkO8WW0ru2XeM5 Mvd0tZuJui6fzcV0FokHLsVW/RNdP5clCSlnaRYtTxPvy4tFKimPeatgNlHtWfBjHkLz b7QLtsiavp4Mk8iUe1E2BqKNsnG74tXmLqsNurSgk5H1qcr6k3PnxetJ/b9vHtEZGzd6 WtQg== X-Gm-Message-State: APjAAAU7Xv/QspYa8Ls3fHojCgso82FgTjcY5dp5liUfC2narpDFl+MO mPlK9La7i03hEZxoolZjIMUsFLNXldI= X-Received: by 2002:a65:5202:: with SMTP id o2mr8032976pgp.402.1555745733492; Sat, 20 Apr 2019 00:35:33 -0700 (PDT) Received: from localhost.localdomain (rrcs-66-91-136-155.west.biz.rr.com. [66.91.136.155]) by smtp.gmail.com with ESMTPSA id z22sm7025492pgv.23.2019.04.20.00.35.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Apr 2019 00:35:32 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 19 Apr 2019 21:34:34 -1000 Message-Id: <20190420073442.7488-31-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190420073442.7488-1-richard.henderson@linaro.org> References: <20190420073442.7488-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::442 Subject: [Qemu-devel] [PATCH 30/38] tcg/aarch64: Support vector comparison select value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The instruction set has 3 insns that perform the same operation, only varying in which operand must overlap the destination. We can represent the operation without overlap and choose based on the operands seen. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.inc.c | 24 +++++++++++++++++++++++- 2 files changed, 24 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h index e1135e930a..e030bf3c8f 100644 --- a/tcg/aarch64/tcg-target.h +++ b/tcg/aarch64/tcg-target.h @@ -140,7 +140,7 @@ typedef enum { #define TCG_TARGET_HAS_mul_vec 1 #define TCG_TARGET_HAS_sat_vec 1 #define TCG_TARGET_HAS_minmax_vec 1 -#define TCG_TARGET_HAS_cmpsel_vec 0 +#define TCG_TARGET_HAS_cmpsel_vec 1 #define TCG_TARGET_DEFAULT_MO (0) #define TCG_TARGET_HAS_MEMORY_BSWAP 1 diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index cf891defd4..84d402acd8 100644 --- a/tcg/aarch64/tcg-target.inc.c +++ b/tcg/aarch64/tcg-target.inc.c @@ -525,6 +525,9 @@ typedef enum { I3616_ADD = 0x0e208400, I3616_AND = 0x0e201c00, I3616_BIC = 0x0e601c00, + I3616_BIF = 0x2ee01c00, + I3616_BIT = 0x2ea01c00, + I3616_BSL = 0x2e601c00, I3616_EOR = 0x2e201c00, I3616_MUL = 0x0e209c00, I3616_ORR = 0x0ea01c00, @@ -2178,7 +2181,7 @@ static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc, TCGType type = vecl + TCG_TYPE_V64; unsigned is_q = vecl; - TCGArg a0, a1, a2; + TCGArg a0, a1, a2, a3; a0 = args[0]; a1 = args[1]; @@ -2301,6 +2304,20 @@ static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc, } break; + case INDEX_op_cmpsel_vec: + a3 = args[3]; + if (a0 == a3) { + tcg_out_insn(s, 3616, BIT, is_q, 0, a0, a2, a1); + } else if (a0 == a2) { + tcg_out_insn(s, 3616, BIF, is_q, 0, a0, a3, a1); + } else { + if (a0 != a1) { + tcg_out_mov(s, type, a0, a1); + } + tcg_out_insn(s, 3616, BSL, is_q, 0, a0, a2, a3); + } + break; + case INDEX_op_mov_vec: /* Always emitted via tcg_out_mov. */ case INDEX_op_dupi_vec: /* Always emitted via tcg_out_movi. */ case INDEX_op_dup_vec: /* Always emitted via tcg_out_dup_vec. */ @@ -2323,6 +2340,7 @@ int tcg_can_emit_vec_op(TCGOpcode opc, TCGType type, unsigned vece) case INDEX_op_abs_vec: case INDEX_op_not_vec: case INDEX_op_cmp_vec: + case INDEX_op_cmpsel_vec: case INDEX_op_shli_vec: case INDEX_op_shri_vec: case INDEX_op_sari_vec: @@ -2405,6 +2423,8 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpcode op) = { .args_ct_str = { "r", "r", "rA", "rZ", "rZ" } }; static const TCGTargetOpDef add2 = { .args_ct_str = { "r", "r", "rZ", "rZ", "rA", "rMZ" } }; + static const TCGTargetOpDef w_w_w_w + = { .args_ct_str = { "w", "w", "w", "w" } }; switch (op) { case INDEX_op_goto_ptr: @@ -2577,6 +2597,8 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpcode op) return &w_wr; case INDEX_op_cmp_vec: return &w_w_wZ; + case INDEX_op_cmpsel_vec: + return &w_w_w_w; default: return NULL;