From patchwork Mon Apr 29 17:00:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 163075 Delivered-To: patch@linaro.org Received: by 2002:a92:7e86:0:0:0:0:0 with SMTP id q6csp2161567ill; Mon, 29 Apr 2019 10:28:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDKaH76iUTcE/mZbW0oMHYkYFQSTA3bt3FL2VuewBzJYhAZDfdpuSmTjn3ZiDv5xPrYWTs X-Received: by 2002:a7b:ce85:: with SMTP id q5mr138385wmj.54.1556558923152; Mon, 29 Apr 2019 10:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556558923; cv=none; d=google.com; s=arc-20160816; b=Pz0fuKiubRE6VoxzyZ1YJG3BcQ5W/VYpWVYWo23rXxUepMWn5n0iyvWpKXE2GI7ZJP r34ZtVeldkBTn8nF8wWaos+dSPzwcNkOyZCZa2nFc0eb16Vkmy3Vmgm4xTSHPX38sgL4 +60E6BpKW05uEL+qIMoeqYA58oLuguCiUjS0FFaOjGl3x2Sfqq48KPlHJVXC/H2A1ECi uC0+vKfkc+RiNWMsEVjLt4F2qMy7nzKSwEPoZlkAqxNmN3rHlVdELMslvyvlDfR/ePRZ 8xccldPyYX81GcdV3POxEwvEHh2dP0qjn5SzUJqXcdHJ6KoOes9SyV2fBc/5WGWRoRsa Tw8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=Kg2YYRuF9GcEYqzRNytFiB3KVAriQjQeVWin+mjaTaQ=; b=FUTc1MXPUjvEduzFRPuEJHwx9zf0P7a1KTAtB/RSMmv+jerpPUrzvIplaa82Bsjfz8 AEZLZQH2f4twdGt/vwv/ZAhSilzrufTuLicB1qceT2u5rfA8C9JXe1hmxX3DSLF48z9V jq1aW1aMkbVmfqhTQx4Xx5AZjHuRH0MRV8gBNos/wxACddIytegUIyFSnEJTITCqlH28 W2nbFsE9EFGm6xLfC0dPZe7KsQC01wkvA8xVDhpgW+LqLDL4idXRBmwHUh0sGS+9s4uZ zbOpcO57urqG/7SIeNjTm7QVVZFNSWfzPBPMWnd5CxgWFAnAIsHL3SmIrbhmQsadjZG3 duWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=wi2nUQqh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u18si17269468wri.143.2019.04.29.10.28.42 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 29 Apr 2019 10:28:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=wi2nUQqh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:60993 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLA54-0003dX-3x for patch@linaro.org; Mon, 29 Apr 2019 13:28:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL9fM-0005Om-BP for qemu-devel@nongnu.org; Mon, 29 Apr 2019 13:02:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL9fH-0006zA-2a for qemu-devel@nongnu.org; Mon, 29 Apr 2019 13:02:06 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:40394) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hL9fD-0006bs-T7 for qemu-devel@nongnu.org; Mon, 29 Apr 2019 13:02:01 -0400 Received: by mail-wm1-x32b.google.com with SMTP id h11so155332wmb.5 for ; Mon, 29 Apr 2019 10:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=Kg2YYRuF9GcEYqzRNytFiB3KVAriQjQeVWin+mjaTaQ=; b=wi2nUQqhBBF7Z+/CwXHm3bcU+DnFRqapzYPNlhGB5jZZxHEM2ibbWhUlHnrDTjQH1l 8AijtCx4HSZFLvxo1OiVNHiQWd61EHV0Pb0MG9tbYwtJROArzguFzyxWzK5PwgqxTneb T0QvCm/6bvGqVQTOXvo26yqjd46ayG89y4gBpEX5iLi6jfUtw+JjsMA/ljt4zc3/difs NURRfGM0onxUCim55fC92gAfk0vTXcxWs45Ff58u/HZpfsyiXaytdmOIViBpcnKkw3s1 kh9cIA69hpnhNpoMiujZsLC6iNa6/3yhTnY0bv3orNomcyCPvecRMKrPnygLtbOlzZTE mZKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kg2YYRuF9GcEYqzRNytFiB3KVAriQjQeVWin+mjaTaQ=; b=WPu8ilGk7RMeBX+TvFEhc9OfS6m860THFtm10LrcKtVdiqZpDf3c1NfLLMiGBNS6oT l+4bm/RkMmcXTK1b2Hs+xyhJyHdpSbjt8q3m+mF079P1EFDWER2ymPX03596Vy5Usw94 lT3XLME5rI7HRqizBwNDgTt7Dx77cbWJT5IDfsNbB2TV7BzNTFrPnIrsYOlyrcyUICkv rA7uwGhxcvua9eztnoLwD6oWA6ZZiMaL3WWZkSR0a3baVaMlG3dRrwh2xauLVX3rcvro UWIXUb0pGI3Hm51TN12Yh/lECr5PxVIfuEs8VvQCi8VlSQrVtOFctFaFq2kAyEaQoIGY kfSA== X-Gm-Message-State: APjAAAUoZiJdPFrrqekb89qu9aE9My4Jgeltdpj7kL9VNT1k2jL/VG0R P9WK7oWDTjUck29mIfi1dzjLgRUKrrI= X-Received: by 2002:a1c:7512:: with SMTP id o18mr58806wmc.68.1556557274988; Mon, 29 Apr 2019 10:01:14 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a13sm36896wmj.39.2019.04.29.10.01.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Apr 2019 10:01:14 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 29 Apr 2019 18:00:21 +0100 Message-Id: <20190429170030.11323-34-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190429170030.11323-1-peter.maydell@linaro.org> References: <20190429170030.11323-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b Subject: [Qemu-devel] [PULL 33/42] hw/display/tc6393xb: Remove unused functions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé No code used the tc6393xb_gpio_in_get() and tc6393xb_gpio_out_set() functions since their introduction in commit 88d2c950b002. Time to remove them. Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé Message-id: 20190412165416.7977-4-philmd@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- include/hw/devices.h | 3 --- hw/display/tc6393xb.c | 16 ---------------- 2 files changed, 19 deletions(-) -- 2.20.1 diff --git a/include/hw/devices.h b/include/hw/devices.h index 1ed5be32967..0850f697451 100644 --- a/include/hw/devices.h +++ b/include/hw/devices.h @@ -54,9 +54,6 @@ void retu_key_event(void *retu, int state); typedef struct TC6393xbState TC6393xbState; TC6393xbState *tc6393xb_init(struct MemoryRegion *sysmem, uint32_t base, qemu_irq irq); -void tc6393xb_gpio_out_set(TC6393xbState *s, int line, - qemu_irq handler); -qemu_irq *tc6393xb_gpio_in_get(TC6393xbState *s); qemu_irq tc6393xb_l3v_get(TC6393xbState *s); #endif diff --git a/hw/display/tc6393xb.c b/hw/display/tc6393xb.c index e1b1e302f23..6d133d9a66c 100644 --- a/hw/display/tc6393xb.c +++ b/hw/display/tc6393xb.c @@ -137,11 +137,6 @@ struct TC6393xbState { blanked : 1; }; -qemu_irq *tc6393xb_gpio_in_get(TC6393xbState *s) -{ - return s->gpio_in; -} - static void tc6393xb_gpio_set(void *opaque, int line, int level) { // TC6393xbState *s = opaque; @@ -154,17 +149,6 @@ static void tc6393xb_gpio_set(void *opaque, int line, int level) // FIXME: how does the chip reflect the GPIO input level change? } -void tc6393xb_gpio_out_set(TC6393xbState *s, int line, - qemu_irq handler) -{ - if (line >= TC6393XB_GPIOS) { - fprintf(stderr, "TC6393xb: no GPIO pin %d\n", line); - return; - } - - s->handler[line] = handler; -} - static void tc6393xb_gpio_handler_update(TC6393xbState *s) { uint32_t level, diff;