From patchwork Tue Apr 30 16:52:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 163150 Delivered-To: patch@linaro.org Received: by 2002:a92:7e86:0:0:0:0:0 with SMTP id q6csp3497629ill; Tue, 30 Apr 2019 10:14:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqw4f6J1YM1IkcfbTHtEsSQ1sa7Q92UUDFV0z+yx7ulCSeTNOVVYRA/2DVtFQUCuFDBti4+L X-Received: by 2002:a5d:4690:: with SMTP id u16mr7897037wrq.198.1556644444963; Tue, 30 Apr 2019 10:14:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556644444; cv=none; d=google.com; s=arc-20160816; b=AP/sTqoT3+GhHEIYi5JpGRD1DG7AYR5EnT42Os9WzNss1O+t4ntcGBzvx4+OaRyXZZ iN4vRss8oLfaVDWiiz37spJ9aaDuDrx+uQDPcyVdLxKk9rlt8A/LsA1pPTdOQ87Kn4Vw QjS8Pr3RZdb0UtbCG018WIkSiAw5GxyCJKNnZ1Sl8O/lXbaDOYdjNPKLf7V9ejPNb1iU 7JyMEOMxTaZzsVFJx7GT9W5ZDZPZ7YPqdJjnx8qCT6yt/aa9jQUC5hvcCrtf46ZcuYEy PbAKwEkFUEEc9mQLFFUS/OAIY6UZgEsq5wpuxIaNgmk/m4NiEoGSvVpxyEqU6m05sJo9 t8zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=gmFGO18R6wc6UEhG3xXAtJADNbztJhPGG+6VZwVsHPk=; b=OKq5zNm0VplsXEqly1iiuM1TDB1svfpBP6uAuIY5/yAWlnYFPzMRsp38zUax7Qv6n5 tYANxzdxeP8GyTGBi5MNRJJ8q+pWwYBNdBEF6IhAMdoTftxVC+jH4CUyDNoekES/hdxj uB61JJW+wK5ZxEI0ScjtmQEMNzxAUUfX5zI8tzOWWBR9eO2vyosiczAJFmbS+ZCSnx5n TMEyYA/u+fByYPhV8Gr8CieRZ9hl6TpFc6XSM+4qG9pB7N5uAOtdyoxQ/AEouBSfWKv8 BWcNGjOxEc9rJh5O4DQCOdSxkRIFL8KK4PCilTJ8YtNGmyAbFDXEx7LxY0xcls8jbhf4 dVJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=YjeWPiwA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b74si1933055wmd.29.2019.04.30.10.14.04 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 30 Apr 2019 10:14:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=YjeWPiwA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLWKR-0003Ce-R8 for patch@linaro.org; Tue, 30 Apr 2019 13:14:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLW5U-0007Cl-Uu for qemu-devel@nongnu.org; Tue, 30 Apr 2019 12:58:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLW5T-0003mO-0A for qemu-devel@nongnu.org; Tue, 30 Apr 2019 12:58:36 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:39618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLW5S-0003lo-Pt for qemu-devel@nongnu.org; Tue, 30 Apr 2019 12:58:34 -0400 Received: by mail-wr1-x442.google.com with SMTP id a9so21866015wrp.6 for ; Tue, 30 Apr 2019 09:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gmFGO18R6wc6UEhG3xXAtJADNbztJhPGG+6VZwVsHPk=; b=YjeWPiwAXRvrcBmrLLYDDjlVMW5moWokvU97lMeQOX+3HCKRB89ZgJVXul9/mlsCf5 0C2OQyCZOgeTnQGN8n9d7gqkvYoIb0xYBExs6O+Hn7so22xk5qu1qgIW0RV+OpjCop92 DKRkxCEHQcLs91RIbVbkc6iP/fs3fDpMNuMAwUEHB6Z6/ZoSQujVKSIrw9D53WugfWI8 VciEi+lG8dRP/P/+dwoaRM3SgW/B+5YO+STK6sI35fHygUd72SN2bL/d5BPbcK4WdDAN B0iAiD/061jH9FRH6ySZOdCJJzweYIYcQqaYyeImdPtwxN8aAv2HnT4Yx+fi9fVkcjsf VB5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gmFGO18R6wc6UEhG3xXAtJADNbztJhPGG+6VZwVsHPk=; b=JpurGdDDDYSPntvMI/nMgSC9rDfuQCYVlF/etOKvtpSK+NGp7mKmU6Ae0oiFYlDWJK eUJIOyggBsqSL34ZgilYdLdOxdgRKDR3HSOXDEuo8BQRvx15l2SbJ8VzO59IiHD6RdK9 SIlkIzDBV3vOnRquGNK0WLP8ncqMrjddmwpfxrwYOBVfexo10p1SaEU51kg/rh8C214f od/8fXKSChcf14LbK9cThmuR/aOUlaZac4kwwOepmwMtHE83hJictmxHvKr38Jr/F/cv DoSFNmNIAQ1AO/skIPkv12QhfLb8ocLsXpmRbIbOfEtkrNRczj8r5Q1f6OK+sSJtmGX/ BKLw== X-Gm-Message-State: APjAAAXiEjfPwcRWNndfqsnRSMy67y5ltteXCeuQ6RN9W/hqE8kyzKE6 QpeCtWP2mAzhf88I4tjhZYtRBw== X-Received: by 2002:adf:a202:: with SMTP id p2mr11994920wra.166.1556643513135; Tue, 30 Apr 2019 09:58:33 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id w10sm3496524wrv.90.2019.04.30.09.58.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Apr 2019 09:58:32 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1B1311FF9C; Tue, 30 Apr 2019 17:52:35 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 30 Apr 2019 17:52:31 +0100 Message-Id: <20190430165234.32272-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190430165234.32272-1-alex.bennee@linaro.org> References: <20190430165234.32272-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v5 12/15] cputlb: Do unaligned store recursion to outermost function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson , qemu-arm@nongnu.org, mark.cave-ayland@ilande.co.uk, cota@braap.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson This is less tricky than for loads, because we always fall back to single byte stores to implement unaligned stores. Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée --- accel/tcg/cputlb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.20.1 diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index e4d0c94301..a083324768 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1413,9 +1413,9 @@ tcg_target_ulong helper_be_ldsl_mmu(CPUArchState *env, target_ulong addr, * Store Helpers */ -static void store_helper(CPUArchState *env, target_ulong addr, uint64_t val, - TCGMemOpIdx oi, uintptr_t retaddr, size_t size, - bool big_endian) +static inline void __attribute__((always_inline)) +store_helper(CPUArchState *env, target_ulong addr, uint64_t val, + TCGMemOpIdx oi, uintptr_t retaddr, size_t size, bool big_endian) { uintptr_t mmu_idx = get_mmuidx(oi); uintptr_t index = tlb_index(env, mmu_idx, addr); @@ -1514,7 +1514,7 @@ static void store_helper(CPUArchState *env, target_ulong addr, uint64_t val, /* Little-endian extract. */ val8 = val >> (i * 8); } - store_helper(env, addr + i, val8, oi, retaddr, 1, big_endian); + helper_ret_stb_mmu(env, addr + i, val8, oi, retaddr); } return; }