From patchwork Thu May 9 22:26:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 163764 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:142:0:0:0:0 with SMTP id j2csp1568747ilr; Thu, 9 May 2019 15:29:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNy/LN8oKLhNxvY5PGnWphK441dW2arSahhyb9htNDflJ0sDC1tlMkEI/NP/PnWPFMYXOM X-Received: by 2002:adf:ec42:: with SMTP id w2mr4747889wrn.77.1557440995752; Thu, 09 May 2019 15:29:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557440995; cv=none; d=google.com; s=arc-20160816; b=IILIFpKdgNwKTQZyDwFswnBs4mDmnqYxLRg3gYCg83wkpwiykTk5cPf1uLjKCfhU0W InVeQX2SgJZuANgQxno/Vf7aUKfJ1AKbotrOIPeY9PJ64C5fhBFqe/jdO7zBwEu7DYoZ ko1tVtJutFg3vEn0apPaJuwUtZ6CC6XSrx366n223aKKQJaHJHyQ1CArpBAJYenyY96n auzWnCgdSCbdc4mmvuPWzcd9vCpbGzPvrcUg+J0qAtjL0nNKd8nsPI5XWEMEExCjiTkI agVVsAidGaJYr06Byctc3odLpy9zW5aa3cekSMUKapb4QmsPlxU6WwajH3BMPWwfl1dJ ycXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=nXQKQmWv/YKHXQBl4iXWce1fvy4Q62aar83khsKjymg=; b=kh5pxOX7qxPIB9VuM4LlED4rn1mBGTGcYrZPV7rCrHer/NZfiSmZDgzN8wv6wjSxDY TGeiRHUJQHf7HgTIMdT7BG7wmHAiMOVEflC6ZdtPb/ePwGTCsVphCCPgV+AoDMLW3j/u eqlG+CPcFsB096ne3RhlapimmTjQKbWkkeQE2aYzZbV32w7d1Jk6PFF9s0L7JgeJYn4K KHKxXL7J1PurBorvJ1y/25uy6Bl40bdRHoAQu9Lffzt2xWy0wJqpm9CAnpNdF3nQmuKV gchl7Ep6LesmqXLALGr59awzyFfiUKAhkHd8bHdvZAT3Ib+c7Bs1KD7T2px3LTogaoBF Vzng== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QIufI29M; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a200si2439775wmd.77.2019.05.09.15.29.55 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 09 May 2019 15:29:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QIufI29M; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:33454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOrY2-0001T7-JX for patch@linaro.org; Thu, 09 May 2019 18:29:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOrUt-0007Vl-Bq for qemu-devel@nongnu.org; Thu, 09 May 2019 18:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOrUs-0005NK-7M for qemu-devel@nongnu.org; Thu, 09 May 2019 18:26:39 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:41913) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOrUs-0005N4-1M for qemu-devel@nongnu.org; Thu, 09 May 2019 18:26:38 -0400 Received: by mail-pg1-x541.google.com with SMTP id z3so1917845pgp.8 for ; Thu, 09 May 2019 15:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=nXQKQmWv/YKHXQBl4iXWce1fvy4Q62aar83khsKjymg=; b=QIufI29MTORtO+OHVlp9TjqlBuZZiKinoDQc/iLnX2ChP1xYp2lwQJPTOpI3N5NpGO tcqTBc7unyWtOiY5QNQ1469ryqPQzuNJ2Lw87pmw6NQYUFg2/j4w5TgVoSupJiCD1+cY 7lXb7EEP7SoqpNUTHEcsckqRqqiN/fLFxb4DepEK6d6EN436mx6qW58XZ00oanChQfqN kkDTPmDVZUtW/TCaMyspA8CwhB6K4YU5ycyvCVqlqFh1UyBOnO/S4SdRaHYjH9D4TcRG Qs+WN9bS7fgZEQwvS6RISQ8UX1SNO9fRCEocsE5gsxvCCgDZ82J1xQmvmUCcXRzjlT4s ZJBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nXQKQmWv/YKHXQBl4iXWce1fvy4Q62aar83khsKjymg=; b=C9SI0YnSj5BTZKe8qOL4lbESZ+DaDe5Q4UMR/PF+mhYCspeW3gV2Ktc16NUyIHNwq1 StkNKXrNCcIgoc0C8/Ss/p1TBnwj1UOFQcEBdQ7jgV0kcGufOrWHQ3nLg8OZS6l6Rn2N EKZPPDl/oxLh5Cg29H396Guh/xNtCeCv0QbHdMUVy/CKfAXTlE8zbOTr7cnC2haeD3fB TDHeTCwIwbpagAx/joJi5da0XwNjKoOvPopMj/dqcUilz6CS22OWUml3W7OiQgfsadm7 EK3Llk2uqfjxc+HZJwXXnGqMtmXlAU5qfgYHUxNpgz+5Ft+zh9KOXSu31jNnPMs2oN05 veUg== X-Gm-Message-State: APjAAAUokJ8+MXTcfFzxMRXlO+SbdM1NfPAYOtz7HROVPG2LX8vdOnDi P/vRV9KljqZOydTFh/fQpMEkWMzywuk= X-Received: by 2002:a63:5742:: with SMTP id h2mr9017998pgm.194.1557440796601; Thu, 09 May 2019 15:26:36 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id m2sm4490521pfi.24.2019.05.09.15.26.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 15:26:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 9 May 2019 15:26:06 -0700 Message-Id: <20190509222631.14271-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190509222631.14271-1-richard.henderson@linaro.org> References: <20190509222631.14271-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [PATCH v3 02/27] target/alpha: Convert to CPUClass::tlb_fill X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Keep user-only and system tlb_fill separate. --- target/alpha/cpu.h | 5 +++-- target/alpha/cpu.c | 5 ++--- target/alpha/helper.c | 30 +++++++++++++++++++++--------- target/alpha/mem_helper.c | 16 ---------------- 4 files changed, 26 insertions(+), 30 deletions(-) -- 2.17.1 diff --git a/target/alpha/cpu.h b/target/alpha/cpu.h index 63bf3618ff..cf09112b6a 100644 --- a/target/alpha/cpu.h +++ b/target/alpha/cpu.h @@ -475,8 +475,9 @@ void alpha_cpu_list(void); is returned if the signal was handled by the virtual CPU. */ int cpu_alpha_signal_handler(int host_signum, void *pinfo, void *puc); -int alpha_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int size, int rw, - int mmu_idx); +bool alpha_cpu_tlb_fill(CPUState *cs, vaddr address, int size, + MMUAccessType access_type, int mmu_idx, + bool probe, uintptr_t retaddr); void QEMU_NORETURN dynamic_excp(CPUAlphaState *, uintptr_t, int, int); void QEMU_NORETURN arith_excp(CPUAlphaState *, uintptr_t, int, uint64_t); diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index ad3588a44a..7c81be4111 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -225,9 +225,8 @@ static void alpha_cpu_class_init(ObjectClass *oc, void *data) cc->set_pc = alpha_cpu_set_pc; cc->gdb_read_register = alpha_cpu_gdb_read_register; cc->gdb_write_register = alpha_cpu_gdb_write_register; -#ifdef CONFIG_USER_ONLY - cc->handle_mmu_fault = alpha_cpu_handle_mmu_fault; -#else + cc->tlb_fill = alpha_cpu_tlb_fill; +#ifndef CONFIG_USER_ONLY cc->do_transaction_failed = alpha_cpu_do_transaction_failed; cc->do_unaligned_access = alpha_cpu_do_unaligned_access; cc->get_phys_page_debug = alpha_cpu_get_phys_page_debug; diff --git a/target/alpha/helper.c b/target/alpha/helper.c index 7201576aae..929a217455 100644 --- a/target/alpha/helper.c +++ b/target/alpha/helper.c @@ -104,14 +104,15 @@ void cpu_alpha_store_gr(CPUAlphaState *env, unsigned reg, uint64_t val) } #if defined(CONFIG_USER_ONLY) -int alpha_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size, - int rw, int mmu_idx) +bool alpha_cpu_tlb_fill(CPUState *cs, vaddr address, int size, + MMUAccessType access_type, int mmu_idx, + bool probe, uintptr_t retaddr) { AlphaCPU *cpu = ALPHA_CPU(cs); cs->exception_index = EXCP_MMFAULT; cpu->env.trap_arg0 = address; - return 1; + cpu_loop_exit_restore(cs, retaddr); } #else /* Returns the OSF/1 entMM failure indication, or -1 on success. */ @@ -248,26 +249,37 @@ hwaddr alpha_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) return (fail >= 0 ? -1 : phys); } -int alpha_cpu_handle_mmu_fault(CPUState *cs, vaddr addr, int size, int rw, - int mmu_idx) +bool alpha_cpu_tlb_fill(CPUState *cs, vaddr addr, int size, + MMUAccessType access_type, int mmu_idx, + bool probe, uintptr_t retaddr) { AlphaCPU *cpu = ALPHA_CPU(cs); CPUAlphaState *env = &cpu->env; target_ulong phys; int prot, fail; - fail = get_physical_address(env, addr, 1 << rw, mmu_idx, &phys, &prot); + fail = get_physical_address(env, addr, 1 << access_type, + mmu_idx, &phys, &prot); if (unlikely(fail >= 0)) { + if (probe) { + return false; + } cs->exception_index = EXCP_MMFAULT; env->trap_arg0 = addr; env->trap_arg1 = fail; - env->trap_arg2 = (rw == 2 ? -1 : rw); - return 1; + env->trap_arg2 = (access_type == MMU_INST_FETCH ? -1 : access_type); + cpu_loop_exit_restore(cs, retaddr); } tlb_set_page(cs, addr & TARGET_PAGE_MASK, phys & TARGET_PAGE_MASK, prot, mmu_idx, TARGET_PAGE_SIZE); - return 0; + return true; +} + +void tlb_fill(CPUState *cs, target_ulong addr, int size, + MMUAccessType access_type, int mmu_idx, uintptr_t retaddr) +{ + alpha_cpu_tlb_fill(cs, addr, size, access_type, mmu_idx, false, retaddr); } #endif /* USER_ONLY */ diff --git a/target/alpha/mem_helper.c b/target/alpha/mem_helper.c index 011bc73dca..934faa1d6f 100644 --- a/target/alpha/mem_helper.c +++ b/target/alpha/mem_helper.c @@ -62,20 +62,4 @@ void alpha_cpu_do_transaction_failed(CPUState *cs, hwaddr physaddr, env->error_code = 0; cpu_loop_exit_restore(cs, retaddr); } - -/* try to fill the TLB and return an exception if error. If retaddr is - NULL, it means that the function was called in C code (i.e. not - from generated code or from helper.c) */ -/* XXX: fix it to restore all registers */ -void tlb_fill(CPUState *cs, target_ulong addr, int size, - MMUAccessType access_type, int mmu_idx, uintptr_t retaddr) -{ - int ret; - - ret = alpha_cpu_handle_mmu_fault(cs, addr, size, access_type, mmu_idx); - if (unlikely(ret != 0)) { - /* Exception index and error code are already set */ - cpu_loop_exit_restore(cs, retaddr); - } -} #endif /* CONFIG_USER_ONLY */