From patchwork Tue May 28 09:49:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 165273 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp8248679ili; Tue, 28 May 2019 02:51:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqzrq/dsj+OHlFSJJfGF7ddqtW+xMOQPGES0r6Vw/fI3eoxO+TLCE7HBkpasYOqX5C5Dl4rm X-Received: by 2002:a05:620a:1641:: with SMTP id c1mr91720680qko.103.1559037114772; Tue, 28 May 2019 02:51:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559037114; cv=none; d=google.com; s=arc-20160816; b=J2IJ6TOFsgYZYlsZQGrZXXz+793NXzT62jpm3S2mvw5BE4r7Ab8rKM+mVU5J7gd04q 08z6iUZ4AJ9c/C2wqiLlNXuBnS3ftcM5C4yhe4zyYpL+2TSvxgbQWTJC7MQz2/sQzGrP /TwLBou5Nzp/HmYsQZeQTYedXVcZsPxRzUmBTQTgBUA5mxQmL/XjggdiEfTLComyLkap z8y5PcNq+DIoPH0COoCBM/rI6W8mqPt0BmKl89fAzV58ae2IqnJfvGl2jgCSkPtfECKx Hr6YDBnZtimVpTpm81k/Sls6latDwdMujoDd0nzBiCKVuI32fC8OQ8YkWZdeHcyQ9iWF L3zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=WaPXaKJ84KPnf9Vac7fR8yciWXTzgsdE11wI7irhktI=; b=oXRExwXk6YfYWNmK0qcn8AAsvUqyKufWD1VqlVLt6o202uTqFE2shsdA+lB2Fw7++L 0LmqtvsUJYlvz1cBazNoAQ3BUy284PuEqRjZY2tRlC5g06BGSGj84xbTjr6VZPxLge5o jDdP38UO5iQZ1fCHVdQHZOjWbmIjrdc9ao0SR5/yie+eXE/3IlXIGH9xRiiLAuNR8vxS xeQTIiqRg9s5jpHsnT5lmbr6TDcVMCqaYk65vNe2iYTne2jWZT7RinPAvy0t2oxKwBCr My0dVc4z6d7yJfnDjELYbMBQb0yUiepzFbFo0sa9vA5vpR/GEzXjl8Vosiq8CkhYoimS NWXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="WZmHeP/+"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q5si6413735qvf.198.2019.05.28.02.51.54 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 28 May 2019 02:51:54 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="WZmHeP/+"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:59953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVYlu-0007mG-5t for patch@linaro.org; Tue, 28 May 2019 05:51:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVYk7-0006EX-OU for qemu-devel@nongnu.org; Tue, 28 May 2019 05:50:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVYk5-00006e-PJ for qemu-devel@nongnu.org; Tue, 28 May 2019 05:50:02 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:39309) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVYk5-0008WM-2B for qemu-devel@nongnu.org; Tue, 28 May 2019 05:50:01 -0400 Received: by mail-wr1-x42b.google.com with SMTP id x4so357116wrt.6 for ; Tue, 28 May 2019 02:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WaPXaKJ84KPnf9Vac7fR8yciWXTzgsdE11wI7irhktI=; b=WZmHeP/+ejRZURE+yRjhCqwLn9ZB6wcW+5BLNBCUOsGmgoa6Iii0bvzPPxtqb5ECgu 8jGw0c3TVWU/4XKxtBL3Hy1myCe/oQ59r/glro1BSivgQQNb0g9P99U3AnaDHR9YaklU xiGR33uMLQzwPioJTACmFYLaQSl9iXS+WpcmE2i7XI9XB7BdfJ88wcN72yY09AHAgAHI C76nGKksMldgGoaJqBhNZaWF+bmwQ7Gtb3sBjAA0y3bw0tsaz7w0JHd0PpQkuXgmyVYq rkjLcCn/An3jFbBDxW7n2rJIrkkiiYjbaBiE8QyCkj/yq0V/rGNtDWU19dXPBUfab4eB skdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WaPXaKJ84KPnf9Vac7fR8yciWXTzgsdE11wI7irhktI=; b=MrIb5henlwN/6jt1pJt77NmZZYBfCcgTPFpzx0/Zhc9sASxfnbCFScrQ/1Xjs0VerK p354CP6Dyh+eKz/IqhJ9/r+bH3CdV1g0Q39WAJxGWv1d8C3pUtFWPFqpVXqyeIvLtPij 0MprEvx2D95ZT7xMT7uieWaM0wz7kAV7hk/7m3WJBtyvm8N8QSO8nSd3B+6AhCcmlUd/ UQQ7503CxrDIB1ntQPWb1lXvHBdls/HzLgKv5f5b3bZkMogN2+bhcoXJuiYhwqKOdAEe FU+Z2pYC7yjbDzb/LOsKBiQDupNV5a0RUmKzn4MHkFYUTeepBu9oOTLfg3ydJGf3j/h+ lIAQ== X-Gm-Message-State: APjAAAXo7QiMnKdY4NbBE54lOWmVOqh4IlEjBVBhuMJ7mQE5KMeR7uk8 JN3/xQAxVKts1ERn0fkWycLAeQ== X-Received: by 2002:adf:df87:: with SMTP id z7mr16559399wrl.8.1559036999970; Tue, 28 May 2019 02:49:59 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id w2sm7298995wru.16.2019.05.28.02.49.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 02:49:56 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 16BC41FF96; Tue, 28 May 2019 10:49:54 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Tue, 28 May 2019 10:49:32 +0100 Message-Id: <20190528094953.14898-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190528094953.14898-1-alex.bennee@linaro.org> References: <20190528094953.14898-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42b Subject: [Qemu-devel] [PULL 07/28] target/arm: add LOG_UNIMP messages to arm-semi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , qemu-devel@nongnu.org, "open list:ARM" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Clean-up our unimplemented bits with a proper message. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson -- 2.20.1 diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c index 384b01124e1..86e6ec48c2f 100644 --- a/target/arm/arm-semi.c +++ b/target/arm/arm-semi.c @@ -28,6 +28,7 @@ #include "cpu.h" #include "hw/semihosting/semihost.h" #include "hw/semihosting/console.h" +#include "qemu/log.h" #ifdef CONFIG_USER_ONLY #include "qemu.h" @@ -363,7 +364,7 @@ target_ulong do_arm_semihosting(CPUARMState *env) return len - ret; } case TARGET_SYS_READC: - /* XXX: Read from debug console. Not implemented. */ + qemu_log_mask(LOG_UNIMP, "%s: SYS_READC not implemented", __func__); return 0; case TARGET_SYS_ISTTY: GET_ARG(0); @@ -397,7 +398,7 @@ target_ulong do_arm_semihosting(CPUARMState *env) return buf.st_size; } case TARGET_SYS_TMPNAM: - /* XXX: Not implemented. */ + qemu_log_mask(LOG_UNIMP, "%s: SYS_TMPNAM not implemented", __func__); return -1; case TARGET_SYS_REMOVE: GET_ARG(0);