From patchwork Fri Jun 7 15:37:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 166176 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp888102ili; Fri, 7 Jun 2019 10:03:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqzIY5EMuTadu6EJ2BGVuxvSwtkMzSl5ix7C+uYiJ+pIhBsilVEzS8HE1c/KHCyAZ460wzKi X-Received: by 2002:ac8:2dcf:: with SMTP id q15mr46242505qta.170.1559927019541; Fri, 07 Jun 2019 10:03:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559927019; cv=none; d=google.com; s=arc-20160816; b=frzBF/o4bEG05qDACVfm0llskcT86B8ZpH5qeIF4HoY/PAZyC12Q9VjZgivxkMLjTI nYKX3nRVZJ+x09FQZqYEXcmMYLJc0bcz/iknG/K0EcjTbhTu1nvaODUbtIbgfIvtwL7I asODeyeaomQoPh9srI+wmTMHIJgMc+tzjuDeB8Vi/vmtTHH6Gqcuguj79JZKcqnnIoXu 5xQXjN/H1Sv1H0s9aUng/XGQvbzgkblan5uEzCmTUtyuGH4vQZo7cR6PqO9gEq/YER0f dmEFMfUWtFXTR2ygph5arRKDbfKZl4alpxrefUGTLhgHvce3uxhoE2kcT6oMHLoIBiAH 4yWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=vBgmqVV1HHXMsA9aXkS1dhyBW4HB0voCVVWuH7KTmpU=; b=V4YFJtU1E67kHnB6a0a8IoBWsdiBl+lhB9c0mntZs1jsGCm32mHyZhd6yF73om0Tpl BcV+9k6trsYmiBw8ZUnKhvcbtvcfSGCglqNsEGyfKoPnuu52q3m+VP6SFx3jwcKj5Crc R8/xjPt4PpGVFL1oFVFm9FcA92msWm+sF+wPUuAV6LA4nUAoIpuhHc5T5mQaQFO08lBe UOEg7f5K2Q0fINbU9D/C6WFKMDPLC7nRenfzmcAVkzEtxTRZlfBDUjVMGz8Oigkw26wK HBwtMSZz5x7PThUf0wP6VpZluMEX7TjlCRl+T00DzJjzVDQFvfKMlloXOYTPC4WLX8Um Feeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r21si387271qtp.149.2019.06.07.10.03.39 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jun 2019 10:03:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:49644 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZIHD-0001LW-4f for patch@linaro.org; Fri, 07 Jun 2019 13:03:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53427) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZGzu-0003ZC-Rc for qemu-devel@nongnu.org; Fri, 07 Jun 2019 11:41:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZGxl-0002qS-OY for qemu-devel@nongnu.org; Fri, 07 Jun 2019 11:39:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53734) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZGxj-0002iD-NU for qemu-devel@nongnu.org; Fri, 07 Jun 2019 11:39:29 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 44B87C057F30; Fri, 7 Jun 2019 15:39:20 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3249E7FE99; Fri, 7 Jun 2019 15:39:13 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Yoshinori Sato , qemu-devel@nongnu.org, Igor Mammedov , Richard Henderson Date: Fri, 7 Jun 2019 17:37:18 +0200 Message-Id: <20190607153725.18055-23-philmd@redhat.com> In-Reply-To: <20190607153725.18055-1-philmd@redhat.com> References: <20190607153725.18055-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 07 Jun 2019 15:39:20 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v18 22/29] target/rx: Use prt_ldmi for XCHG_mr disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Note that the ld == 3 case handled by prt_ldmi is decoded as XCHG_rr and cannot appear here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-21-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) -- 2.20.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 515b365528..db10385fd0 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a) /* xchg dsp[rs].,rd */ static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a) { - static const char msize[][4] = { - "b", "w", "l", "ub", "uw", - }; - char dsp[8]; - - rx_index_addr(ctx, dsp, a->ld, a->mi); - prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd); + prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd); return true; }