From patchwork Fri Jul 5 08:31:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 168516 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3275664ilk; Fri, 5 Jul 2019 01:41:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhkQsR26Y69q2TcC2488/J3p0DftfzN/WbpEQdAo6GthZQHWjO/qR82xk/S4P+Cf0ab/Jo X-Received: by 2002:a50:9646:: with SMTP id y64mr3117715eda.111.1562316065607; Fri, 05 Jul 2019 01:41:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562316065; cv=none; d=google.com; s=arc-20160816; b=SwOiJl+vX/bPuOqo3J54eE00IJgPIhu+FWbnaGEXgVS8oo8XwC18GNWaamme/gRdqi P/oCCmH5V3chhdf6BxoZRmHSNsdUMQwR7L45TK683ttjX1olN5ssnR8s5q2u3fcvxt1k 6hfNu8i0iKyQ+LXBrg+kwZRfJYR8PmfnqxSbH7OyLSsZFPnS0sIbAgK3Oiawvo5Jf8IK Gg2k4WEspk7rCZXUyu6vOL5UolZ1BhhzjR/zMZtSVTVl7ZxRbcCLc6pv7Q2eTRoFKg+v uYTwnUMzGV1RYp2YVDVIHA1ikjfte5cZSdKfbr85QpV5Cz/+3tBVl2A8HC20C5FmQ6Nu 3tpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=VNx9Ajp99J+k2CxoHG8xzhuyro4Mwnnw0aZqs91u9dM=; b=SwG9gBLdZE++u9xUrKGUrC1fPbwMEVoGiuVMfHlBu2KeoBczkGl18RluAAZvuGtIbD LK+xSJM3Z3vqNoKsgVOOuZpJ9y71hZ7aIjQ5QYb/LYLIlpU92atEOyTGaXVpVnK80zEJ ujLeX0IwOrCcpr7BjDCEl2nwpmYqDIEmLDS9F0DulWGFEA+05GWf+Q/Wsh7xXOaW0Lva JTyB9hmbqqHNOAt0N+QjxW9Kn5tZ3O5LspMznl/UG+acq3at+wND/aAcAjqutYEo3X+Y T3/CfDd0fctLPk3maTfrwUaC22qEjxMXLj0fk/qtm9jcasd6f3T4iDgq+QdPNX7OpHN8 Lzog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d21si5661622ejw.81.2019.07.05.01.41.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jul 2019 01:41:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:50574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjJmC-0006Qs-G7 for patch@linaro.org; Fri, 05 Jul 2019 04:41:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56980) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjJdi-0003Lg-U9 for qemu-devel@nongnu.org; Fri, 05 Jul 2019 04:32:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjJdf-000637-Vs for qemu-devel@nongnu.org; Fri, 05 Jul 2019 04:32:18 -0400 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:39715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjJdf-0005sb-Ji for qemu-devel@nongnu.org; Fri, 05 Jul 2019 04:32:15 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id 6B7274DE7B; Fri, 5 Jul 2019 17:32:04 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 24456240085; Fri, 5 Jul 2019 17:32:04 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Date: Fri, 5 Jul 2019 17:31:32 +0900 Message-Id: <20190705083141.106254-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190705083141.106254-1-ysato@users.sourceforge.jp> References: <20190705083141.106254-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.15 Subject: [Qemu-devel] [PATCH v22 13/22] target/rx: Dump bytes for each insn during disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, imammedo@redhat.com, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.11.0 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1