From patchwork Wed Jul 31 16:06:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 170197 Delivered-To: patch@linaro.org Received: by 2002:a92:512:0:0:0:0:0 with SMTP id q18csp4252375ile; Wed, 31 Jul 2019 09:45:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHwrmoJuDv5kKBQllgVhOaB34B6gug3VnW9BuFazfCMPiOkSbm1eYctZTzVDU1KY2oln42 X-Received: by 2002:a50:a943:: with SMTP id m3mr105808723edc.190.1564591530277; Wed, 31 Jul 2019 09:45:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564591530; cv=none; d=google.com; s=arc-20160816; b=OMV5u9shA6Yh5RCnhvuaeVrEh+MQIr/YjOnwzhyMc7kDtI0Q/nD03CrxMqiG2z4zax 0a+1tgDUZfH0KQU4yrsnicIkgQgdhA2TEeJFDzPkSH4LVPM85BCIi8AT4hF1IUZraf0C YIuz8hP6NvorRZ3GjdRZL9sEaS3cPPYEPOGjgaT7Tahb4vwuFsPhFzyn5ROd473jaC8F WchXDtP2wdkb1nzJUwVZUcr76hIoqberkcrn8+HebI/apEf3PNJrICrcNoDjWGYMvLqt Vv62uSQPUlCURaiUVDKV8kqTPbThB8CNybmAzVyP6qdjd6zm3xRz7qbrXEXF6/DXfqzs mYlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=VKH7CA7PvW2n45iUTxcQG9XbQH7DlhtsC6UTV58NGHI=; b=xYNlBHHWZPrRdr23EoHKs1QclKzA4M2codABRLiyUx/J3ccFWmi509ps1EAvyKYtfM hJPIS063io4DxdzDwtQWDfi0EDlzcNH0v5cR6Hq03EXKgtk0JhLqJttNcephjb8f7xwv DBGdrGZz+AgSfg4KBnYfBSKad9JdEmdAdoFUqdo/SvCEGbOz30ewb7xcfSYswE2og938 IxRWH/DASHfnh97IHV1F17Kv0uE8g5116OMYw51VlQixaD2oBe97GNSx92aZ/oecxC8I 3a55CUF1LIqGg9DMPzP8PigGFnLuJRthIB0vg84Db4+HSfKBlxBSmXlEr2NaYg0GVQBX cLTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QvmF5A8n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k6si21061678edd.325.2019.07.31.09.45.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Jul 2019 09:45:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QvmF5A8n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsrjF-0001jS-7P for patch@linaro.org; Wed, 31 Jul 2019 12:45:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51235) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsrj4-0001hJ-Pr for qemu-devel@nongnu.org; Wed, 31 Jul 2019 12:45:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsrj3-0000sW-Qv for qemu-devel@nongnu.org; Wed, 31 Jul 2019 12:45:18 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:45347) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hsrj3-0000rs-JG for qemu-devel@nongnu.org; Wed, 31 Jul 2019 12:45:17 -0400 Received: by mail-wr1-x442.google.com with SMTP id f9so70417107wre.12 for ; Wed, 31 Jul 2019 09:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VKH7CA7PvW2n45iUTxcQG9XbQH7DlhtsC6UTV58NGHI=; b=QvmF5A8nk+b7B8r2io9vc5yx9XNz7bu5ezc1cTjG86E9KJs2H4TnSJLPsFZ2Khn2Id x19PMcbMMn/nZmRy4Lm3rtwqmyfllTW910BgUrTx/ouRApFlO9b+4ji5weNjGhLQy5uf 1qGs4+p/9hLEIAAjQ2yyCmcTAvQNJMBLTnZFWo5hHkRFJSzXQ79H3rIbPcLnngMVfhAv J4UjjrL4oI14F0xVALOM0EAZm7vgDfQxm1PkoIL7AxnYapxwQ9KImbFrb90mkcGKTNOD paRDFylBxMVkuOuYnJGPRTq8Yx5FosZacR7NB1fqoeu9P9yw7b6/EcfIuY//WYskNqVY bgeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VKH7CA7PvW2n45iUTxcQG9XbQH7DlhtsC6UTV58NGHI=; b=jDDHUIqChl1Kz88t/YK+NZjSyLaPyJmBhYE2jBLdekRmWUVgNiWwk8v0ipiAReZ+u+ NFRKJIg/fPbfM4FrPZ9Ms7yEnTANNgNrvdtCl6iGEswRgkRR8DIk6qhVbf88nP50UqP3 nQe6RTVYc49DFDNDGIxxkOrNrMFCtPip0zLsOHDe5VPWXZVF8jnmwjJhc8hqZCvhdNd1 S4+NYk60uNbu7C9H332X3+b/KUM8elGzVwJDZXrWRrt+VCyncEO2lovY5IFBDNFO0cN9 kMxnhIT7b7gG8y7Ovz/KuyNb4Oj3UItZvqqBQQvISK+psb+90dp6UrGx3JXO/In3gG47 phJA== X-Gm-Message-State: APjAAAVw8b+yBy6Lv+n/mthynX/P5xctWs/aGn8r0qyoMNuPxzXaRf2g SF4GS4PPxZz9D5mKYHELfpxOag== X-Received: by 2002:a5d:630c:: with SMTP id i12mr47735850wru.312.1564591516472; Wed, 31 Jul 2019 09:45:16 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id q10sm70580250wrf.32.2019.07.31.09.45.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 09:45:13 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 82ED21FF90; Wed, 31 Jul 2019 17:07:22 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 31 Jul 2019 17:06:57 +0100 Message-Id: <20190731160719.11396-33-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190731160719.11396-1-alex.bennee@linaro.org> References: <20190731160719.11396-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v4 32/54] target/ppc: fetch code with translator_ld X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , aaron@os.amperecomputing.com, cota@braap.org, "open list:PowerPC TCG CPUs" , bobby.prani@gmail.com, =?utf-8?q?Alex_Be?= =?utf-8?b?bm7DqWU=?= , David Gibson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Alex Bennée --- target/ppc/translate.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) -- 2.20.1 diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 4a5de280365..a27b5659f46 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7864,11 +7864,9 @@ static void ppc_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) LOG_DISAS("nip=" TARGET_FMT_lx " super=%d ir=%d\n", ctx->base.pc_next, ctx->mem_idx, (int)msr_ir); - if (unlikely(need_byteswap(ctx))) { - ctx->opcode = bswap32(cpu_ldl_code(env, ctx->base.pc_next)); - } else { - ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next); - } + ctx->opcode = translator_ldl_swap(env, ctx->base.pc_next, + need_byteswap(ctx)); + LOG_DISAS("translate opcode %08x (%02x %02x %02x %02x) (%s)\n", ctx->opcode, opc1(ctx->opcode), opc2(ctx->opcode), opc3(ctx->opcode), opc4(ctx->opcode),