diff mbox series

[v1,3/7] fpu: make softfloat-macros "self-contained"

Message ID 20190808164117.23348-4-alex.bennee@linaro.org
State Superseded
Headers show
Series softfloat header cleanups | expand

Commit Message

Alex Bennée Aug. 8, 2019, 4:41 p.m. UTC
The macros use the "flags" type and to be consistent if anyone just
needs the macros we should bring in the header we need. There is an
outstanding TODO to audit the use of "flags" and replace with bool at
which point this include could be dropped.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 include/fpu/softfloat-macros.h | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.20.1

Comments

Richard Henderson Aug. 8, 2019, 5:49 p.m. UTC | #1
On 8/8/19 9:41 AM, Alex Bennée wrote:
> The macros use the "flags" type and to be consistent if anyone just

> needs the macros we should bring in the header we need. There is an

> outstanding TODO to audit the use of "flags" and replace with bool at

> which point this include could be dropped.


Indeed.

Acked-by: Richard Henderson <richard.henderson@linaro.org>



r~
diff mbox series

Patch

diff --git a/include/fpu/softfloat-macros.h b/include/fpu/softfloat-macros.h
index c55aa6d1742..e698bca4e1d 100644
--- a/include/fpu/softfloat-macros.h
+++ b/include/fpu/softfloat-macros.h
@@ -82,6 +82,8 @@  this code that are retained.
 #ifndef FPU_SOFTFLOAT_MACROS_H
 #define FPU_SOFTFLOAT_MACROS_H
 
+#include "fpu/softfloat-types.h"
+
 /*----------------------------------------------------------------------------
 | Shifts `a' right by the number of bits given in `count'.  If any nonzero
 | bits are shifted off, they are ``jammed'' into the least significant bit of