From patchwork Thu Sep 12 06:06:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 173667 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp1703354ilq; Wed, 11 Sep 2019 23:07:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwL7J9Ik3uYVMcmSU9pLo3tm9mGK/CTC2PPZHk2g55GJ1XtJX6VVRVWFXa6tn3rInv8GMvY X-Received: by 2002:ad4:5303:: with SMTP id y3mr25935040qvr.19.1568268475845; Wed, 11 Sep 2019 23:07:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568268475; cv=none; d=google.com; s=arc-20160816; b=GoGB+h1cp3UtYCM99hYUqSBie3aGZ7KzFXZ19aM5c+2bPlryIOgWGjtu3mO+a5o1Ul D7hQM4+RxriZjp2gjn4iyCoqZKoFHwuCBWDR/1Pz3d6BG2wHBeSsEOh+fXqjfENM9QFT 6jJmSDC4Cx0bq+3Bfxa21pIpDs1hUgHkS3XlyY0gU6QuBFFhWuFpBRdMz8Pp/VSL9xLV DyU83QIaGNkX1PwIOgb2owczz0B66y0Bp9sJPFZs0FVFeFEMx2psfU8And42C9o/czq2 NVGsjKZhF8TNgml+a+gyfcjRQU3nwiwPxUDE6JIQutymB7TFuXvstZ7F+fBhYope64Kl 4IuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=fjiHS9xytTkZ9fd06fQEBg4Kt9fDBI24+AHRH/hfj1M=; b=Zi61BZ0Oq4rHX2HqqmxYPxPBckNzajEm2nlkzkeEigNv2tEL6pdth5T1AI3QhmAc/k xVXL5Tb1rcsU33YGJoPNQrv/I8HSHPcavBR1QaTPrQreWx5Ki5tpXSji/9ExO67hZP2N DQe2qMYrEGfMtmuGJybqaMtatFL4MAXb7n5qnZwoKK4ET/v/B1dap3Mbepa/KIttb0GR wVw5H1glt4xtDdTTaAFvxDt39aNLR/3aWE7rWi3Kg14JkGxnvKiRnTYdVBnAl4s7XDSq EUiaxcFg2/71XoXOGjEtugLRYjHXaFqdsirJbV95YemO+hL07Cn7zXmNDVYvZZo900dy us1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e4si12802961qvd.2.2019.09.11.23.07.55 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Sep 2019 23:07:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:58350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8IGo-0002RO-Go for patch@linaro.org; Thu, 12 Sep 2019 02:07:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36936) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8IGB-0002M0-Av for qemu-devel@nongnu.org; Thu, 12 Sep 2019 02:07:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8IG9-0008A8-CJ for qemu-devel@nongnu.org; Thu, 12 Sep 2019 02:07:15 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:45499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i8IG8-00088Y-UW for qemu-devel@nongnu.org; Thu, 12 Sep 2019 02:07:13 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id 33D366AB99; Thu, 12 Sep 2019 15:07:10 +0900 (JST) Received: from yo-satoh-debian.localdomain (ae227063.dynamic.ppp.asahi-net.or.jp [14.3.227.63]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id EEB52240086; Thu, 12 Sep 2019 15:07:09 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Date: Thu, 12 Sep 2019 15:06:52 +0900 Message-Id: <20190912060701.4642-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190912060701.4642-1-ysato@users.sourceforge.jp> References: <20190912060701.4642-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.14 Subject: [Qemu-devel] [PATCH v24 13/22] target/rx: Dump bytes for each insn during disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, imammedo@redhat.com, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1