From patchwork Thu Oct 17 13:16:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 176638 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp961363ill; Thu, 17 Oct 2019 06:54:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYTyWElow/4Y3TAXeweeOG0hqycMcS/Zh10eIG4tpQBSKCpVLtdpdL130RVC9sTarGti+M X-Received: by 2002:a05:620a:1355:: with SMTP id c21mr3419070qkl.288.1571320481606; Thu, 17 Oct 2019 06:54:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571320481; cv=none; d=google.com; s=arc-20160816; b=KSVFyrr72mYMx/XzGQ4gutQneTFvtkL8Kkru39mXZXNZDAGDgezg5f/Y4DtiwqILbK VU2f9MpAOtKKmv6+yTQA6OAV8GFJ9HkU/Ii6+9U+vZcOK5qtUpRfQe1ANJbwW9voHWpA rGtmFQ4XZJ7u5XirxF0s+i/gyfvf8hLmCJg4heommQR03GzIdHy9mvqqq7CkRkSp2CoY zWQlrN9PvfIu9JGoQuHYbnwn/hgsF+jWDmi/2/TtwV/aY4OdlVLc07ky5mYlHR9lCdKo e2yQWA8wg4euAyorqfOG6cH5J61EoaDfLzqlTt9cyAK2aHBj+P4KywEYILN/IG1cFxDM 2A7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=5xyamaZcxYkKnEujCxiwYlmoCoUtUZYHxGEu/iYbDUk=; b=HhSZNOmiV/mHx6BGRDiAqAI2H7YsqP2XK6gfQ0j7xHCR17n4x76bWkmlP5LXHSkIGg DA7JJ5nNmrt5Ls59bznVesrJvYqpDiZlLOj8YDpnuvYM3MytTRhK0ARz6d+F8Z6WAnLZ o12BuMaSW3v79WY7bS2doWBJEHAeLCKcgeTH2KY1peShoZqJFXdsAamFmgvx2KK0c0BO PUvwcixns6wg2Qjid5SVQWvRrTmHxtBMkLlPxFCcKTATop+2UOoiI/tqHNU9xpsxqDbv I5NrXBI82JOZCsPPMgrpzWt+L/k6j41fhTpti9RlYc/Wvm3JVhCmE3ON1Zis+ubajFa+ FeDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VscMljlW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n187si2108563qke.161.2019.10.17.06.54.41 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Oct 2019 06:54:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=VscMljlW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL6Ei-0003cz-KQ for patch@linaro.org; Thu, 17 Oct 2019 09:54:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35470) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL5mQ-00029s-LQ for qemu-devel@nongnu.org; Thu, 17 Oct 2019 09:25:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iL5mP-0001FM-4o for qemu-devel@nongnu.org; Thu, 17 Oct 2019 09:25:26 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:43584) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iL5mO-0001F4-UP for qemu-devel@nongnu.org; Thu, 17 Oct 2019 09:25:25 -0400 Received: by mail-wr1-x442.google.com with SMTP id j18so2336580wrq.10 for ; Thu, 17 Oct 2019 06:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5xyamaZcxYkKnEujCxiwYlmoCoUtUZYHxGEu/iYbDUk=; b=VscMljlW+bhzWbx9KzUTxM0ngs+ResiQ/zEJce5koV92QX0yqrZU2HP7sW/gU46NvL nXmTBf6ZQ/Qr5KwY0qWM6jSiiw/TwpHjDlYSuxHrapOEXUG0GN/X/wJLUFsqOz9uUaIj RlXf7nVTm6IoQnrQcnPiThk6K2FO85e/sHdU79+fdu91u/mD9TFcuk0E7ddw6+sMqOWV CbULwVc4Ds96+vJYgxYhlQcF1IBGHRLN/5OXn0Ifm7+vV0UQzYF5c0GJ3Th0ya2R7dz2 M9UfWv+blllcRoxe+2vvIXw43+0hwn56IcCdz5cNZ0HgV+4j+sytIj8iGU4wdZKa3K20 gbug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5xyamaZcxYkKnEujCxiwYlmoCoUtUZYHxGEu/iYbDUk=; b=AcK4SqV9JaiDcrSrel1Gv9jVSd+c5LyHTJ6n/tOlfo/DOaj9E7YDtuTq/ZjHIDJukD Dn8rT+agvj7VDBlrIHIVocERjBAhpePEajVGaG0+qCB8ydr3YSRp7ygGgy+ewWgHaNVh j+anIUdJ04Rhl1ctIApCr7EOV4ESYTrQ+Fb37iOmaebcXzb0/0Pxp8wvXpLxo/clDEsD Kmeb7rF0HExq1ERH5wFSq2+IQvvmq46bx6F7PTMgFjlGMN/8aGOiKxGCKZBBOqqmYG/b WenElLj1FhzQWlSU+jAkADk3IX41wzqX+8qtOFK8g4ftC4xwoxbR7dhUHV0Fw1ud/C7g BRLg== X-Gm-Message-State: APjAAAU0KaKUZRXAqK4gSRTwzdbRUgmdtpNUccZ2S8e1BxFiCL9cAyAA KAXS5dZsVXSHQtsCju3CnkQA1g== X-Received: by 2002:adf:f30b:: with SMTP id i11mr2798512wro.377.1571318723722; Thu, 17 Oct 2019 06:25:23 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id x129sm2894016wmg.8.2019.10.17.06.25.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 06:25:22 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 9AF621FFC7; Thu, 17 Oct 2019 14:16:20 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v6 50/54] tests/plugin: add hotpages to analyse memory access patterns Date: Thu, 17 Oct 2019 14:16:11 +0100 Message-Id: <20191017131615.19660-51-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191017131615.19660-1-alex.bennee@linaro.org> References: <20191017131615.19660-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robert.foley@futurewei.com, Richard Henderson , peter.puhov@futurewei.com, aaron@os.amperecomputing.com, cota@braap.org, =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This plugin gives a summary of access patterns grouped by "pages" and showing read/write patterns by vCPUS. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v4 - tweaks for new hwaddr api - add sorting and pagesize selection args v6 - init api update - plugin_outs update - add sort by address option - add track_io option --- tests/plugin/Makefile | 1 + tests/plugin/hotpages.c | 191 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 192 insertions(+) create mode 100644 tests/plugin/hotpages.c -- 2.20.1 diff --git a/tests/plugin/Makefile b/tests/plugin/Makefile index 3656429d46..75467b6db8 100644 --- a/tests/plugin/Makefile +++ b/tests/plugin/Makefile @@ -12,6 +12,7 @@ NAMES += insn NAMES += mem NAMES += hotblocks NAMES += howvec +NAMES += hotpages SONAMES := $(addsuffix .so,$(addprefix lib,$(NAMES))) diff --git a/tests/plugin/hotpages.c b/tests/plugin/hotpages.c new file mode 100644 index 0000000000..77df07a3cc --- /dev/null +++ b/tests/plugin/hotpages.c @@ -0,0 +1,191 @@ +/* + * Copyright (C) 2019, Alex Bennée + * + * Hot Pages - show which pages saw the most memory accesses. + * + * License: GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) + +static uint64_t page_size = 4096; +static uint64_t page_mask; +static int limit = 50; +static enum qemu_plugin_mem_rw rw = QEMU_PLUGIN_MEM_RW; +static bool track_io; + +enum sort_type { + SORT_RW = 0, + SORT_R, + SORT_W, + SORT_A +}; + +static int sort_by = SORT_RW; + +typedef struct { + uint64_t page_address; + int cpu_read; + int cpu_write; + uint64_t reads; + uint64_t writes; +} PageCounters; + +static GMutex lock; +static GHashTable *pages; + +static gint cmp_access_count(gconstpointer a, gconstpointer b) +{ + PageCounters *ea = (PageCounters *) a; + PageCounters *eb = (PageCounters *) b; + int r; + switch (sort_by) { + case SORT_RW: + r = (ea->reads + ea->writes) > (eb->reads + eb->writes) ? -1 : 1; + break; + case SORT_R: + r = ea->reads > eb->reads ? -1 : 1; + break; + case SORT_W: + r = ea->writes > eb->writes ? -1 : 1; + break; + case SORT_A: + r = ea->page_address > eb->page_address ? -1 : 1; + break; + default: + g_assert_not_reached(); + } + return r; +} + + +static void plugin_exit(qemu_plugin_id_t id, void *p) +{ + g_autoptr(GString) report = g_string_new("Addr, RCPUs, Reads, WCPUs, Writes\n"); + int i; + GList *counts; + + counts = g_hash_table_get_values(pages); + if (counts && g_list_next(counts)) { + GList *it; + + it = g_list_sort(counts, cmp_access_count); + + for (i = 0; i < limit && it->next; i++, it = it->next) { + PageCounters *rec = (PageCounters *) it->data; + g_string_append_printf(report, + "%#016"PRIx64", 0x%04x, %"PRId64 + ", 0x%04x, %"PRId64"\n", + rec->page_address, + rec->cpu_read, rec->reads, + rec->cpu_write, rec->writes); + } + g_list_free(it); + } + + qemu_plugin_outs(report->str); +} + +static void plugin_init(void) +{ + page_mask = (page_size - 1); + pages = g_hash_table_new(NULL, g_direct_equal); +} + +static void vcpu_haddr(unsigned int cpu_index, qemu_plugin_meminfo_t meminfo, + uint64_t vaddr, void *udata) +{ + struct qemu_plugin_hwaddr *hwaddr = qemu_plugin_get_hwaddr(meminfo, vaddr); + uint64_t page; + PageCounters *count; + + /* We only get a hwaddr for system emulation */ + if (track_io) { + if (hwaddr && qemu_plugin_hwaddr_is_io(hwaddr)) { + page = vaddr; + } else { + return; + } + } else { + if (hwaddr && !qemu_plugin_hwaddr_is_io(hwaddr)) { + page = (uint64_t) qemu_plugin_hwaddr_device_offset(hwaddr); + } else { + page = vaddr; + } + } + page &= ~page_mask; + + g_mutex_lock(&lock); + count = (PageCounters *) g_hash_table_lookup(pages, GUINT_TO_POINTER(page)); + + if (!count) { + count = g_new0(PageCounters, 1); + count->page_address = page; + g_hash_table_insert(pages, GUINT_TO_POINTER(page), (gpointer) count); + } + if (qemu_plugin_mem_is_store(meminfo)) { + count->writes++; + count->cpu_write |= (1 << cpu_index); + } else { + count->reads++; + count->cpu_read |= (1 << cpu_index); + } + + g_mutex_unlock(&lock); +} + +static void vcpu_tb_trans(qemu_plugin_id_t id, struct qemu_plugin_tb *tb) +{ + size_t n = qemu_plugin_tb_n_insns(tb); + size_t i; + + for (i = 0; i < n; i++) { + struct qemu_plugin_insn *insn = qemu_plugin_tb_get_insn(tb, i); + qemu_plugin_register_vcpu_mem_cb(insn, vcpu_haddr, + QEMU_PLUGIN_CB_NO_REGS, + rw, NULL); + } +} + +QEMU_PLUGIN_EXPORT +int qemu_plugin_install(qemu_plugin_id_t id, const qemu_info_t *info, + int argc, char **argv) +{ + int i; + + for (i = 0; i < argc; i++) { + char *opt = argv[i]; + if (g_strcmp0(opt, "reads") == 0) { + sort_by = SORT_R; + } else if (g_strcmp0(opt, "writes") == 0) { + sort_by = SORT_W; + } else if (g_strcmp0(opt, "address") == 0) { + sort_by = SORT_A; + } else if (g_strcmp0(opt, "io") == 0) { + track_io = true; + } else if (g_str_has_prefix(opt, "pagesize=")) { + page_size = g_ascii_strtoull(opt + 9, NULL, 10); + } else { + fprintf(stderr, "option parsing failed: %s\n", opt); + return -1; + } + } + + plugin_init(); + + qemu_plugin_register_vcpu_tb_trans_cb(id, vcpu_tb_trans); + qemu_plugin_register_atexit_cb(id, plugin_exit, NULL); + return 0; +}