From patchwork Tue Nov 5 20:52:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 178557 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp1300598ilf; Tue, 5 Nov 2019 13:08:45 -0800 (PST) X-Google-Smtp-Source: APXvYqz/00ULIseILaJ1J9y3PLKzxI7E87R0eXwg7S8xq2RsirzaqTbEh9bFjwecnDDu2uImWqIw X-Received: by 2002:ac8:7186:: with SMTP id w6mr20071108qto.220.1572988125431; Tue, 05 Nov 2019 13:08:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572988125; cv=none; d=google.com; s=arc-20160816; b=wVoJKNvnKHqEqhD1yigUOzqGgYZyqcTITQcupCY3PpMWKNlZkvREcskusgrK1ausiG VD4D1KRhF0JEAAgNZEgsNTI6ykJCFXlNbp0lahKhmypdAuvYG1BUu1TmP/xePF4r9jQw M4orIatwopE4U8Ff0SF1HEh+LywOu7FJs5/MouYZujEVEvTDGefp+F1xLVowqij3HtC9 xidpTpuHG/PO3BsuIhQzHtkwvJbzfZ/uESm9+5iThZKDKqItJGaZEoXVsQ3x56ARW1Ts b+XxQbv14sq0KxxVVJTdLdeLRNda2serm1QQmv/5vJzj+croH21vV6W0fzFnT2rGJhrY I52w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=qZVdh0yL9CQgmaUVvOGHHGmeP+hu6oUlr115M5Ln3ms=; b=vnTuiht+Nuf6QfscbZTNeSaPDcrV2VhMdMd5R1Zc4WwJTGzpfR3c+Q17Ga42SBhY18 MublqucYT2PDm7cTG1iHwOYsXcVQpxhGOawx30hiITmZPL2A4dKf9WSfI6GNEqaRB0X5 FQA4a4N/FDevYO221/DuJNJDfHob69u1uw3MNvtWdrFxAvmO/zW7gXtWxsVtiKqYylPF 11bQTm2z4B60Vh0MTU3UV+KBx06iS1C1YpTlnWzSvNCa2a0UGEoP1dlaSnKpyo3cLYS+ MD+qJgE4C/BYYtdba5e79qZ222Xwhs+RV5EKYJrBtV86YNeqBe+tpCxJuIXt2U+hmw5O QyXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i5si16079669qkd.274.2019.11.05.13.08.45 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Nov 2019 13:08:45 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1]:50084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iS64C-00037U-En for patch@linaro.org; Tue, 05 Nov 2019 16:08:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58283) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iS5p4-0000O2-6K for qemu-devel@nongnu.org; Tue, 05 Nov 2019 15:53:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iS5p2-0001yh-NZ for qemu-devel@nongnu.org; Tue, 05 Nov 2019 15:53:06 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:49908) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iS5oz-0001vT-SF; Tue, 05 Nov 2019 15:53:02 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xA5KpYn0027559; Tue, 5 Nov 2019 15:53:00 -0500 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w3g6dgk4u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Nov 2019 15:52:59 -0500 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id xA5KnuZo000943; Tue, 5 Nov 2019 20:52:57 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma04dal.us.ibm.com with ESMTP id 2w11e79ffw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Nov 2019 20:52:57 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xA5KqvwF48693678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Nov 2019 20:52:57 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1BC5E124054; Tue, 5 Nov 2019 20:52:57 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A198124052; Tue, 5 Nov 2019 20:52:57 +0000 (GMT) Received: from localhost (unknown [9.53.179.218]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 5 Nov 2019 20:52:56 +0000 (GMT) From: Michael Roth To: qemu-devel@nongnu.org Subject: [PATCH 18/55] target/arm: Free TCG temps in trans_VMOV_64_sp() Date: Tue, 5 Nov 2019 14:52:06 -0600 Message-Id: <20191105205243.3766-19-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191105205243.3766-1-mdroth@linux.vnet.ibm.com> References: <20191105205243.3766-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-11-05_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911050170 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-001b2d01.pphosted.com id xA5KpYn0027559 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.156.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The function neon_store_reg32() doesn't free the TCG temp that it is passed, so the caller must do that. We got this right in most places but forgot to free the TCG temps in trans_VMOV_64_sp(). Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190827121931.26836-1-peter.maydell@linaro.org (cherry picked from commit 342d27581bd3ecdb995e4fc55fcd383cf3242888) Signed-off-by: Michael Roth --- target/arm/translate-vfp.inc.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.1 diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c index 092eb5ec53..ef45cecbea 100644 --- a/target/arm/translate-vfp.inc.c +++ b/target/arm/translate-vfp.inc.c @@ -881,8 +881,10 @@ static bool trans_VMOV_64_sp(DisasContext *s, arg_VMOV_64_sp *a) /* gpreg to fpreg */ tmp = load_reg(s, a->rt); neon_store_reg32(tmp, a->vm); + tcg_temp_free_i32(tmp); tmp = load_reg(s, a->rt2); neon_store_reg32(tmp, a->vm + 1); + tcg_temp_free_i32(tmp); } return true;