From patchwork Tue Nov 12 15:01:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Foley X-Patchwork-Id: 179213 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp8241859ilf; Tue, 12 Nov 2019 07:07:36 -0800 (PST) X-Google-Smtp-Source: APXvYqz7wPIpaolCaKZ/UyGpT2d9viE4eZXlc/XP6H2TlJm9UiAGIO9ZAFGZrAiZx/tBGB72rVBf X-Received: by 2002:ac8:6c5c:: with SMTP id z28mr32431825qtu.17.1573571256020; Tue, 12 Nov 2019 07:07:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573571256; cv=none; d=google.com; s=arc-20160816; b=pKGw5zIXGIpaPBsXBzOoA60uumX6/7Qq5yXGOvzJkACMrKQmpmOWEMIvQclNin2PRS /nT03yrBQq3JwJ92cGBYxZpDxqjDJsuz5zeAA1kjNppbfiObG3ssE98vt3skzBDWiWZ7 HjG9RSRjEbJOaPUeuSq6Iop8f3d+EhbPSECS3rZb1EYswNZLGEYpTefx0YkYVtBzD3Lm 67ofrHPkmprFNSV7BpomNSDXHSei96jeaZCkbWTiLKdXjWACfdqrqYYHfB8tda5Dfvi7 H4k217EqWDb9FbpH6YYcIVCKFD+skFbxwAykultR+bc7Cr+/WxOBsdfxPBc3AR+wRkxZ 2m9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=PT8V7FGR+uiq7NVQ+Sjew78XVlFsZNWfaPZAmYaVr1k=; b=yMdhGxzu5HcETbTPJrESufbAOK6CaUpfp+e2yXJ6nn6czzOcJZVqmuUt2zJzSdrLiF t2YWsHt6OZneAlaIkz8WXnPyCVmNJmj2VLGkw5JgVALZYzJWs1ek6CXOpsBMJgJltTbb BIVRYBzo2ILCKCtt988N12t8PS8TM4/kL4CCpyV8FBH5X2hOIvA4q9Z2dSuCoAHISpUM QqRAvWjFMg8HnlvSvsZAIhJ2I+ZEjwGURC+TNEEvCbFgK9/iJlpC0U5pOtB8n9ChdXEH FEisHWeblYmup7Gz4nTKfzQWW3GtUwuXidopUQNTc2hAJFxbLr1VXbCy1NIrNRcvAc2T 5p9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Q9idqCMz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v9si11025096qta.129.2019.11.12.07.07.35 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2019 07:07:36 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Q9idqCMz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:36234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUXlW-0003Cl-Mr for patch@linaro.org; Tue, 12 Nov 2019 10:07:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38078) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUXgf-0005yt-Jk for qemu-devel@nongnu.org; Tue, 12 Nov 2019 10:02:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUXge-0002MP-HV for qemu-devel@nongnu.org; Tue, 12 Nov 2019 10:02:33 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:37487) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUXge-0002LR-CR for qemu-devel@nongnu.org; Tue, 12 Nov 2019 10:02:32 -0500 Received: by mail-pg1-x544.google.com with SMTP id z24so12027673pgu.4 for ; Tue, 12 Nov 2019 07:02:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PT8V7FGR+uiq7NVQ+Sjew78XVlFsZNWfaPZAmYaVr1k=; b=Q9idqCMz9VimN1mMjs3zKKOgu3qH6ebvRMGUkdIvw/xpWGHSAvFdW0RRmKk4cbYfhK ZSu6sw1X8Nxrz0mzIg9luOOw0qjM+woe2NyjLoYXO/Rj3lx4uYKXIMCPNeUT3Mpkrau6 MsgJEIlRHL98krpYf1g1e0vvSZjPivYElyJhVZhaYXlM7DjgLFJBJF7WO3GivsNUuh0s jDy+/WegJGFa9AXNU/rsQswCjZ6B2/gIMMOOcJpQGkyn0GoU8j7t3FlL0dKiMqtX+IlU bRah0LBoS/jPrug038fn2IdSP5iR7bc1NcxuFMVWgEfAQYE/orTeYCR/Z2kd4zOgyD8i JTSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PT8V7FGR+uiq7NVQ+Sjew78XVlFsZNWfaPZAmYaVr1k=; b=mEi7pFTrHEgscKGXaH4q7H4Lrx3pgF6B4l+fNqE+DRz3i84htLS6u2zHFVhs/VTEk+ xtxV4M0vOiVe9vewdFxHTs74XJz/Wk1GpEo68RdTABwhQunhSpnh6bj6lHcFrsfJTWWy joXlh7bSUSdspK9WJq+vRSPp+9eu5JDnUYorlWMXbviOvm7+wH29cSqjkjGhnEoC+iPD H9zBWSZlN2BjXWirqnYfHLTJEGr5EhYP4w/tC+mIrg0KhSptagp1n+AsbJlTlEnGxs0V 8gcUhHOr5UFoPKdUDwvZrcNosJiKdFH73jIeqJ3OCJ9mrHD+4ky2zvO6mOXsdPXV0xDC YJZA== X-Gm-Message-State: APjAAAXUSHrSXvX6klO0Ny6kXL1sm71jwpxyu2oJbDf5+DrqGX99wXkJ 2JojW2eKZ97l+YpUoaXIZdhkxBJ6m38= X-Received: by 2002:a63:f501:: with SMTP id w1mr36813394pgh.307.1573570951144; Tue, 12 Nov 2019 07:02:31 -0800 (PST) Received: from Rfoley-MA01.usrd.futurewei.com ([12.111.81.71]) by smtp.gmail.com with ESMTPSA id a3sm8235511pfo.71.2019.11.12.07.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 07:02:30 -0800 (PST) From: Robert Foley To: qemu-devel@nongnu.org Subject: [PATCH v1 5/5] Fix double free issue in qemu_set_log_filename(). Date: Tue, 12 Nov 2019 10:01:05 -0500 Message-Id: <20191112150105.2498-6-robert.foley@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191112150105.2498-1-robert.foley@linaro.org> References: <20191112150105.2498-1-robert.foley@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.puhov@linaro.org, alex.bennee@linaro.org, robert.foley@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" After freeing the logfilename, we set logfilename to NULL, in case of an error which returns without setting logfilename. Signed-off-by: Robert Foley --- v1 - This is new in the patch v1. --- util/log.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 Reviewed-by: Alex Bennée diff --git a/util/log.c b/util/log.c index 802b8de42e..1eed74788c 100644 --- a/util/log.c +++ b/util/log.c @@ -148,6 +148,7 @@ void qemu_set_log_filename(const char *filename, Error **errp) char *pidstr; g_free(logfilename); + logfilename = NULL; pidstr = strstr(filename, "%"); if (pidstr) {