From patchwork Wed Nov 13 00:52:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 179243 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp8889816ilf; Tue, 12 Nov 2019 16:53:19 -0800 (PST) X-Google-Smtp-Source: APXvYqwrcU750irR5fZNsU5O2Hwmkluz8qtC85Vu0OpM8TusUVZegVA2w0hlgnwjP5sAI83iXk44 X-Received: by 2002:a37:6f07:: with SMTP id k7mr292222qkc.118.1573606398916; Tue, 12 Nov 2019 16:53:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573606398; cv=none; d=google.com; s=arc-20160816; b=BOs/x42yGL8MCGp6ib9jz3dyy4nHmLlVqTPGl7JASX8KNaMAoJitYhVi78bSvsYArh Z36qPSYPXYF+hOtYn8fQlMotshTthqPobJ97+ugqNLaZAPGEpkxPRivqysEFee7/BxpN HI1Uwz4Zqv2bniN9Ni5ITInhuN1+GNyShBg2i2GVAPy5izh+eH8zBrdPD09EKihk4zqk rXqOEuUnBsPEo/FnFGml4SSzdIhLGh8fPpdpPLrE2pSwyOFDYGeGUnN3IqgieatgtEcC Z6xHh4HGf3l/ijFiRJ+oWg47tgh0DM2Ei3uxj59JzGADTMf4/ndIYl3N7QltkFECBMr8 UItA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=aNfFczhM8NYMoBpUcEwP04hyJCPiYk7J/QnyzWmI2l8=; b=w8lPeoFNImokV5KaTzEXomjzZt4R7evraQAoWroIz2NFEKr27raEJtzQ9pNGdyqAmh lH997bmHgURScDnM3T7O5ErTH5QUrsDZ3KUoX4WDZse56CkOYZTovlWpu4NB5jrTjJa2 pD/pWwWIIfZR/TScNQ9Kl18TK2R04KLRJUZXjNAc/jnrvAeXO/51j731RvReJR8e/UmV klSaRDvXNKE+xq57ZfvcMwFThC525+3TxmBWgkFHIrwJAIhJMutcYmBXN2VLkk+gt32g PipcGfJeXocG7kMm8pPrpDNci4MjsWDAyK285DyXny5traySEggaiFTpCD6b38an4pKb F1YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=lePXLF7A; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b23si179394qvf.109.2019.11.12.16.53.18 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2019 16:53:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=lePXLF7A; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:40786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUguM-0001n5-C7 for patch@linaro.org; Tue, 12 Nov 2019 19:53:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54322) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUgtT-0001VD-Vq for qemu-devel@nongnu.org; Tue, 12 Nov 2019 19:52:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUgtT-0005K0-1P for qemu-devel@nongnu.org; Tue, 12 Nov 2019 19:52:23 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:43754) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUgtQ-0005JE-VB; Tue, 12 Nov 2019 19:52:21 -0500 Received: by mail-pg1-x544.google.com with SMTP id l24so150809pgh.10; Tue, 12 Nov 2019 16:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aNfFczhM8NYMoBpUcEwP04hyJCPiYk7J/QnyzWmI2l8=; b=lePXLF7AcSFkiDMl6Or4EyDx6Sa5+DayZIMfs8WYoO61KhqXFZdHA2BYG+jWj6t87l O/mtH/omXWKOtO2Ogig7yUxIj6Naq/nHLm1HmZGb4vCWyKrnE11m558QfaKmvdlTPey9 T8EHF42FPTUJRX/lPWYfuJbWyqTv672XJkC+elSQMZvGWJcy0yxl2VI0/SG+AJwB7ETH Ul+zQFBO0w0x4VcxpRkP5aYxLkFnj4TIlfS+XoANp1BlJK/NvKqgaiwPwdXMyp8js4Y0 WOUJb0UgJghKvEyJAOw5UfvMW0NfZzq1sNR+HHdux8V0J9/JGdLzajnO46uBoIPN/snP Na9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=aNfFczhM8NYMoBpUcEwP04hyJCPiYk7J/QnyzWmI2l8=; b=Q1vbK9lK/Ch28B2KwpOTurG6wEWTOWBIvDjotey71hDJqLa/hUkYAsrN2MmX8oxsXe bOXBgSo72TlRU/uAfk2XWXjw+McVtLMVabLymcex8/gtEugA7slz5Bk0sjMMxxBIuNYo yLRUMKSumM54JhSEWSuTko49BvB6k9oOXYjHsUBIaQskpLK1u8lLXBPGAJp85v7jsYO0 ptGKpqMh+pZJR7l7fy9xtyWszGxWhPauypZV88iXdROykva2C/GFJWlUME4+61gd+lq1 /hwXRx8XpM1brb8e50LKqXzkSMPO/Q21tdRGp/a4h2U6DkLApYOKiRD5BLeD9Tczg6s4 87Og== X-Gm-Message-State: APjAAAUBl5o/IzLpERqr5TXkryCdk4uJDQq4O1vfUqs/ec/sHSs8an9r EPdR15AyQXvCFnqdSNHgTF8= X-Received: by 2002:aa7:9314:: with SMTP id 20mr897065pfj.231.1573606339846; Tue, 12 Nov 2019 16:52:19 -0800 (PST) Received: from voyager.ozlabs.ibm.com ([36.255.48.244]) by smtp.gmail.com with ESMTPSA id i13sm169848pfo.39.2019.11.12.16.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 16:52:19 -0800 (PST) From: Joel Stanley To: Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goa?= =?utf-8?q?ter?= Subject: [PATCH v2 3/4] watchdog/aspeed: Improve watchdog timeout message Date: Wed, 13 Nov 2019 11:22:00 +1030 Message-Id: <20191113005201.19005-4-joel@jms.id.au> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191113005201.19005-1-joel@jms.id.au> References: <20191113005201.19005-1-joel@jms.id.au> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Users benefit from knowing which watchdog timer has expired. The address of the watchdog's registers unambiguously indicates which has expired, so log that. Reviewed-by: Cédric Le Goater Signed-off-by: Joel Stanley --- v2: Use HWADDR_PRIx --- hw/watchdog/wdt_aspeed.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.24.0 Reviewed-by: Alex Bennée diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c index 145be6f99ce2..8787c5ad0f97 100644 --- a/hw/watchdog/wdt_aspeed.c +++ b/hw/watchdog/wdt_aspeed.c @@ -219,7 +219,8 @@ static void aspeed_wdt_timer_expired(void *dev) return; } - qemu_log_mask(CPU_LOG_RESET, "Watchdog timer expired.\n"); + qemu_log_mask(CPU_LOG_RESET, "Watchdog timer %" HWADDR_PRIx " expired.\n", + s->iomem.addr); watchdog_perform_action(); timer_del(s->timer); }