From patchwork Thu Mar 26 19:30:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Foley X-Patchwork-Id: 184864 Delivered-To: patch@linaro.org Received: by 2002:a92:de47:0:0:0:0:0 with SMTP id e7csp449282ilr; Thu, 26 Mar 2020 12:41:15 -0700 (PDT) X-Google-Smtp-Source: ADFU+vu38hr5HtelfS6G//TbUFLywkUxqzOvaL+B8nQsSsGzLgEb5tJQj7lPO5mWwuHUp1iQPuCa X-Received: by 2002:ac8:f4a:: with SMTP id l10mr847764qtk.146.1585251675556; Thu, 26 Mar 2020 12:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585251675; cv=none; d=google.com; s=arc-20160816; b=kahFVK7B8Arj/j3TzCam4+w/SP26XB+BBOKiU+CaauH6oUqlv4AMkdg5/PxAz/pzto EXnZwjxu19kJX2bxetlkSL5VWCIP5i0w7lng1JompUc5AwrlEfkx6Yq7OCdu0sFxK6v/ 6B/oixUjDYKg6jqWG0Q9nx4eBhjRgHBnlcSdDQfFATZ2YHZkbgM/bvbWsy3lBaDN4guz U1Zv/IarQXWKfhubD+9uCnhZe+sMQfCIw4NdIZfTJQ2NhxDfpO9GBtjfFmWiWvnIg5Ph o+7/YHyXskM5UWiugeVrLN4nfk78wm7kvFoZSjrtFw74f/62dX9viejt7xGOobviiaer 3TSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=YU0MJsBdXP71+ASBscgMltueTCsYgt9Kz0FY+8TmezY=; b=r6B1dprQw1/CFM9TElV6phBQ4RkZL3RVbOCEWQEvRE1NJUklnhbCFwm/VcEPMee53K a+UMGYQrKsMlXTo+816GSqo1fL11DX53vQefPlpWihAXcL5cxthio7+A+Y4uymDkKN2N NamgRvmiGBuZBbMMHn4a8MymF+xOuKi7W2QjE53Urm9gpQW9sTjTf0CsaSij2JCOzmU6 R6y2g+CtVOM4Rgi73b3oBo/RXUZ9YmM4sHoQ/rZYL7mxVKwTWI9dZDNjXZlMMOuom+Ij l1vTF2ANwtqluPAf0/jSG5A8KifsMye+lKpHP3yFXAsbJP0JIFXrMAAmPfvOqEYqHrET 14pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="qRPUtv/a"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w128si1960116qkc.373.2020.03.26.12.41.15 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Mar 2020 12:41:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="qRPUtv/a"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHYNP-0003wJ-2P for patch@linaro.org; Thu, 26 Mar 2020 15:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58368) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHYJx-0005yc-6B for qemu-devel@nongnu.org; Thu, 26 Mar 2020 15:37:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHYJw-0001Lx-2v for qemu-devel@nongnu.org; Thu, 26 Mar 2020 15:37:41 -0400 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]:45601) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHYJv-0001Lo-V5 for qemu-devel@nongnu.org; Thu, 26 Mar 2020 15:37:40 -0400 Received: by mail-qk1-x742.google.com with SMTP id c145so8135247qke.12 for ; Thu, 26 Mar 2020 12:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YU0MJsBdXP71+ASBscgMltueTCsYgt9Kz0FY+8TmezY=; b=qRPUtv/akgVcHvO+hR1YAC0yYSKT2HKFgxWHIoayjmuKTmJnCgBp3r43j12XDdQzcS UiJ2Ej9GbopPedr4MMOM+JFIDTnlXG7rjwfOCQdZEK9x3RM9OIXEPBzA3mt6QFvK9aag 5wbmEnx35dNMQL/GaU8cYs5t+1hOCNmTudBV/7v5XtfpxyxQoHS1V0IMJ69toq4AmF8S To1JDqzasMS4juzMFKf2h6cFMlqJoFGReR692QhrSxbYEhkBDpWVG1aiNWpNuNbaUxEy 0TVO1vKO3R+hk+aDACh4Jltyr0rzQUX1DUB3D1TDBAC/m+vHoK6EOYdz4r6yJOpwHDI4 l9qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YU0MJsBdXP71+ASBscgMltueTCsYgt9Kz0FY+8TmezY=; b=lCy4rS6/1RgOznUjLUqyl7xytdLMtjJhQ9XOLeBWG6uPoQd/mS1TGbvys0pVqWF3Vx HbypAq8eBdG+uZycqYGzgWUVSMTC0k3NYhuR5HoN05G5SjVM1BnAzczfvyvGLYv9dBp0 AqsTsTIpr/pfoj8ySoIHN6jiU98zw3I16oZ2nzMrcEi8Sx4b+xBQCTk8iVc2AJOuoUxA vwmPCQgmd9Hka/1LZTR5V/J779VU13UOqqShpUppXBMNaYgFfgRrjScaniGLmj2OfCeU aRkksPPd36NTBWjNnIHX1iBPRq5Tj80TcDLXZ6MskfKgyLT+0Y9N5wBr2QoRmzIZawCU pBWg== X-Gm-Message-State: ANhLgQ1nLXyZ9WEK3lkBWGcCLGTmaQDZtoNCNOLL92zib5IJZreQqQdW gooXsdeoSHMN3XRAuVf9ix4RGTTP/FsEvQ== X-Received: by 2002:a37:a4d6:: with SMTP id n205mr10319510qke.352.1585251459236; Thu, 26 Mar 2020 12:37:39 -0700 (PDT) Received: from Rfoley-MA01.hsd1.ma.comcast.net ([2601:199:4480:60c0:fd55:4e67:1038:8302]) by smtp.gmail.com with ESMTPSA id u51sm2161916qth.46.2020.03.26.12.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2020 12:37:38 -0700 (PDT) From: Robert Foley To: qemu-devel@nongnu.org Subject: [PATCH v8 05/74] cpu: move run_on_cpu to cpus-common Date: Thu, 26 Mar 2020 15:30:47 -0400 Message-Id: <20200326193156.4322-6-robert.foley@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200326193156.4322-1-robert.foley@linaro.org> References: <20200326193156.4322-1-robert.foley@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::742 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard.henderson@linaro.org, "Emilio G. Cota" , alex.bennee@linaro.org, robert.foley@linaro.org, peter.puhov@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" We don't pass a pointer to qemu_global_mutex anymore. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 2 +- cpus.c | 5 ----- include/hw/core/cpu.h | 10 ---------- 3 files changed, 1 insertion(+), 16 deletions(-) -- 2.17.1 diff --git a/cpus-common.c b/cpus-common.c index 9031c31005..bf5794cc17 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -119,7 +119,7 @@ static void queue_work_on_cpu(CPUState *cpu, struct qemu_work_item *wi) cpu_mutex_unlock(cpu); } -void do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data) +void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data) { struct qemu_work_item wi; bool has_bql = qemu_mutex_iothread_locked(); diff --git a/cpus.c b/cpus.c index e1f3327bbc..ff8f37cf88 100644 --- a/cpus.c +++ b/cpus.c @@ -1189,11 +1189,6 @@ void qemu_init_cpu_loop(void) qemu_thread_get_self(&io_thread); } -void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data) -{ - do_run_on_cpu(cpu, func, data); -} - static void qemu_kvm_destroy_vcpu(CPUState *cpu) { if (kvm_destroy_vcpu(cpu) < 0) { diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 9c3ec715e2..9c6a426c35 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -766,16 +766,6 @@ void qemu_cpu_kick(CPUState *cpu); */ bool cpu_is_stopped(CPUState *cpu); -/** - * do_run_on_cpu: - * @cpu: The vCPU to run on. - * @func: The function to be executed. - * @data: Data to pass to the function. - * - * Used internally in the implementation of run_on_cpu. - */ -void do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data); - /** * run_on_cpu: * @cpu: The vCPU to run on.