From patchwork Fri Mar 27 18:13:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 185017 Delivered-To: patch@linaro.org Received: by 2002:a92:de47:0:0:0:0:0 with SMTP id e7csp1613937ilr; Fri, 27 Mar 2020 11:19:31 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuGtLGKM5ytqDMRVaCh2WcusdJRP0vG90EtHP5RBbH3WRRasQaZlpCPeD7wU7BnajXB7Dzb X-Received: by 2002:a37:9f42:: with SMTP id i63mr669468qke.192.1585333171583; Fri, 27 Mar 2020 11:19:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585333171; cv=none; d=google.com; s=arc-20160816; b=QvpB83Evzv59SIUDKRQ2qhy4jnGLGl72RdWrxjzh2WFN52v0MazqSjmydRFD+pciai LPCqYuYRlE2gH8RamDtR4Hmj9euhZ5DWlh8ZobKNRxLQ7+0oBMhTNMf3USa1Hh2qmo6f pOMhvrLeL59FeM2JnFy1My1tnm2he2zXXVFKFPeMEh7RtPVdbBBqWd3YJlUEocD+k9QE NyXLyzPW8J8AOOeClVCH5RiERUiYCwpoPqZ+sMPur1hlUWVgSqT1yQu2nWIpDZOFn9It dI4DlfT3m4g6dHdIbIfLykRp+QbfgXfR+a5THBaurP0RhuKuBDSaFRT5HYyCgDHwWHty rtPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=+VoMivlcvCf+pGhQz2DwJ+dxCP3nmc4/WScJnu17j8E=; b=gx16KTi50NgENNdRgPYnGCMnuyl/NvKH75+OkgVEeEaBYBISz62JDeP7P2YfkGLzrd xsWKUDppEdndD1HeT+GWTh2J6uB5fBqRj9omde8/N/bS+ppqnEgEa4ovGMcry/5WOwHm 12MBLQr9CO0gtL/3X3T7Yup0VU1Xf1kEJEDYSRnz/ReF+MgvGHl0Z3zFpetgXWe7gg4X ZKXhEwKaxhwOjanHvD94Dm0CLnwByaA6eSzYakSF9c8bwV41fxKiyQl6tjYyyw7FEswf MlLE5OXMBSNyt/2TYJ5t+HqLDnhwE3NInkojv35i0ZKHojFWNqPdkYveDmsIfI4x7qig F9VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=RNsp3J2l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d11si3972069qki.28.2020.03.27.11.19.31 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Mar 2020 11:19:31 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=RNsp3J2l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHtZr-0002wE-2w for patch@linaro.org; Fri, 27 Mar 2020 14:19:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40526) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHtU6-0001yA-Qp for qemu-devel@nongnu.org; Fri, 27 Mar 2020 14:13:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHtU5-0000qX-2v for qemu-devel@nongnu.org; Fri, 27 Mar 2020 14:13:34 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:34239) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHtU4-0000oZ-Pa for qemu-devel@nongnu.org; Fri, 27 Mar 2020 14:13:32 -0400 Received: by mail-wr1-x431.google.com with SMTP id 65so12596047wrl.1 for ; Fri, 27 Mar 2020 11:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+VoMivlcvCf+pGhQz2DwJ+dxCP3nmc4/WScJnu17j8E=; b=RNsp3J2lkNED/AQ/aRyUPH6eV6U6poLNNtSC0RC/YYs0d4NAhEUJdsFJ+qKWi26zgo 3LvKLYi9PiD2zQPVAnowAg7JyqGwbqYRnOKUQtIWyekJPVFmyoSeOgzAzLleATVx9MLT 023FdLj5Jzt4xgeH5eweSO0x3KEjWGzSQN6RohH+RSRONAJ3crfEGqxwdP71pyiiC1Je 1+FxQG1qj0YH2T9aMTKnzEiU9bczrqqS7iQLLc5p1cmZsP5ys2RYRv3GygIeK6Ik+MlR I7ZkCe4C8ulE1pBGlu/5yAlU4zT4H45n6nT/OWQOTS8bei0VL8TQQPk01JPpxD1gATDO zEqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+VoMivlcvCf+pGhQz2DwJ+dxCP3nmc4/WScJnu17j8E=; b=cXWgAsId/+b8wY87hApNg5d2PFAA3nc0yQD2YXmmzRd8P7El5Cocc1Eqkl4EnIt7ua fu2OXeXh9LufNSbUu9WsVwe6PoFJBp+J+ULuaSJxHneuqbbx00SYQRo9pzFsY3IHhDyh TzR9zTZ0X3HvPZWCkMQzcbFaBDc3MEy62I3LpJgfhGrPiUlMIpehQLgL8KTENzA2E7Yw +sicthKhOY35U3xOPWGJ8G2iyuQ0LyhQRJsnkWNilBmm9I4cxNeDjmtkREB7YtjM6OvO MXTEkoGYl6yJPvrvlfC2OWH3mvmsUDnXJ34Ya+wBba1mlSwgdZXQj/vq8tU9DwOKFyVR 0Zng== X-Gm-Message-State: ANhLgQ1wbQ9iPenxKQrGZIETgD7vVYf2vJ0O/4IqfnKbcqn1zOzIvGch Ve3gIFGOobfrOpV9kNt7wM53jA== X-Received: by 2002:adf:ec02:: with SMTP id x2mr646562wrn.365.1585332811715; Fri, 27 Mar 2020 11:13:31 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id v11sm9479752wrm.43.2020.03.27.11.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 11:13:28 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E499F1FF93; Fri, 27 Mar 2020 18:13:20 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL v2 07/12] configure: disable MTTCG for MIPS guests Date: Fri, 27 Mar 2020 18:13:15 +0000 Message-Id: <20200327181320.23329-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200327181320.23329-1-alex.bennee@linaro.org> References: <20200327181320.23329-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::431 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson , qemu-devel@nongnu.org, =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Aleksandar Markovic , Aleksandar Rikalo , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" While debugging check-acceptance failures I found an instability in the mips64el test case. Briefly the test case: retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ -display none -vga none -serial mon:stdio \ -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ -cpu I6400 -smp 8 -vga std \ -append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1" \ --no-reboot Reports about a 9% failure rate: Results summary: 0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation) -6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation) Ran command 100 times, 91 passes When re-run with "--accel tcg,thread=single" the instability goes away. Results summary: 0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation) Ran command 100 times, 100 passes Which seems to indicate there is some aspect of the MIPS MTTCG fixes that has been missed. Ideally we would fix that but I'm afraid I don't have time to investigate and am not super familiar with the architecture anyway. In lieu of someone tracking down the failure lets disable it for now. Signed-off-by: Alex Bennée Acked-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson Reviewed-by: Aleksandar Markovic Cc: Aurelien Jarno Cc: Aleksandar Rikalo Message-Id: <20200323161514.23952-7-alex.bennee@linaro.org> -- 2.20.1 diff --git a/configure b/configure index 89fe881dd46..e225a1e3ffe 100755 --- a/configure +++ b/configure @@ -7887,7 +7887,7 @@ case "$target_name" in TARGET_SYSTBL_ABI=n32 ;; mips64|mips64el) - mttcg="yes" + mttcg="no" TARGET_ARCH=mips64 TARGET_BASE_ARCH=mips echo "TARGET_ABI_MIPSN64=y" >> $config_target_mak