From patchwork Wed May 27 14:54:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 187282 Delivered-To: patch@linaro.org Received: by 2002:a92:5b0a:0:0:0:0:0 with SMTP id p10csp1198065ilb; Wed, 27 May 2020 08:03:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx88f9+mR5Blsx6w30DAN37p7Z+J4k6D9tpPy73JsVzKTc7A/c15IzMjh6qgUkvvFTqUgkO X-Received: by 2002:a37:9c91:: with SMTP id f139mr4630568qke.371.1590591783585; Wed, 27 May 2020 08:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590591783; cv=none; d=google.com; s=arc-20160816; b=xm7Rkg2LWayUWMupAjDfU4GayBYQa5K2ai1+h8huY8ez0HHuTo0hFTuO9tdv1/bn9I gqOXnDh0dV90pR9m6Gvqr+7W3tsTEkkurqi4CQM9G8MFoEkws4/uytrqY9miUFOHCA57 WjlxfD63AEK7zQ24EFeGT4FaVcelQbBYeyyDpKb9GKRHjl/LAn/ItgrkOv0W/OkCNy3u ndCf1vHSGri2JyaxLbaYs3R0mWpwUHjQ7CMdSJWkI/PBaL3kkmpJRuR8z3Iey6lYz0eu 3y51gIGrfZbbsa75VtGXZy425jVP0KujRjq+2wUFgtqA7arYafRpiUwXjT7cV8Qf/UEq 2vjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=kYq+Iqo+cKi5UFcKLWoiaFCpkMVAa+BEZNXisFwmIpA=; b=jH1En5geL+k8HsTJcbXXq6swTV7qNxv/reTXsQ/PJYAeiDLNTaL9TR1a4QwI4lWNFx 2ZQaoUOe+rmS/g4u9b2vN7tnR+Nosr2HRDRDmPc934u38ZP9bciocH183On7rtAXg4SK sloL4oE4tIBld6m9b1qQtybFtM3eLas4iiZFHwaZbxMcK6bZDO95hgkc8XwAMjcZ0JvH DGyUNZ76ir8teKLAKdcQ2PuygfnbGPctDb/LSZkBVgKEuROMAz5QQiKdS+ZkE0sMndRS SrLm1C/c6cGWognhy/sM24tbjbTB/Le8r0vh6Ay5cV+hK9h7H4Jn8gL9SsPLf0hhPhka z9vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FYeYzNCy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n17si1841950qkh.319.2020.05.27.08.03.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 May 2020 08:03:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FYeYzNCy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdxaB-0005jn-5t for patch@linaro.org; Wed, 27 May 2020 11:03:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdxSY-0001rZ-Hv for qemu-devel@nongnu.org; Wed, 27 May 2020 10:55:10 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:46233) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdxSV-0008B3-R4 for qemu-devel@nongnu.org; Wed, 27 May 2020 10:55:10 -0400 Received: by mail-wr1-x42a.google.com with SMTP id x6so10675012wrm.13 for ; Wed, 27 May 2020 07:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kYq+Iqo+cKi5UFcKLWoiaFCpkMVAa+BEZNXisFwmIpA=; b=FYeYzNCyCbTKOMRgCoghqQ7NbL+LGtxnqqP4nb2XQaThP37M1JgJTOcGjwxjXVXB3b +V9zTqkuipZ50eDBS7grJHTQaoGHAeqViIftxQD3+pjVu0BxdN9zabDgpJ+FGRIoPFXP xckGS4MschZeSWfFinyIIUD7BNztNCpXVCNtSv0VRFcuSXWFeeh/qwAwFmT7r5fQAWZb hxWO2z+nT7wJx5ksJ57qaK592TXhtV7Rl4ei1arBBtWBApn4oOGwuLtUm/GmD275WNuh LFg1fv7Jd84el5Kpy0ZRODGN5E27sCntkkBL0mV/KW0tBLSHXGSClVJzfLcD07oRq8lc FhbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kYq+Iqo+cKi5UFcKLWoiaFCpkMVAa+BEZNXisFwmIpA=; b=CB2B//8BfVyfyfT6BXZP+tLf64bqAQD3mcxAc/fFhREpfn+aQT+qhX7fHTVoaLtzkR oZiVuuB1jg5J1edqFPVORkgNhHiPSZBAv/9iw0fg1s0Bjj9NDPQd+TnG4bemoqQPo86D 2EU8TgPdi0Dt04RidMqbLdc0hTNJnP6EL64brrmIuFDHH6ViSFkBl1M45Vj1s0+ZbiVq SysEkZxORJE2TcKjXKl8O8XanD5/615WuKTYO5w83MO4YjrIL3gWm7NGLRrqlIP+6eED xHJS70ruHZBq5yYtElJyKYbROmGqy66XMEO+h+bR3RLmqg600VejHoYn/mMF/NJTlNfI Ny+A== X-Gm-Message-State: AOAM533Jbh8OZ4KbsxgyuyENKqiNMA58tWEf4uj43EW+UZZYsHFX2Z+W UQND5jQE5JSpwkS+WIqawJwewFq5QJg= X-Received: by 2002:adf:e381:: with SMTP id e1mr23933904wrm.320.1590591306344; Wed, 27 May 2020 07:55:06 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u74sm3027545wmu.13.2020.05.27.07.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 07:55:04 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id AB9B51FF93; Wed, 27 May 2020 15:54:56 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 07/12] tests/tcg: better detect confused gdb which can't connect Date: Wed, 27 May 2020 15:54:50 +0100 Message-Id: <20200527145455.2550-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200527145455.2550-1-alex.bennee@linaro.org> References: <20200527145455.2550-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" While we may gamely give the right information it can still confuse the wide range of GDBs out there. For example ppc64abi32-linux-user reports: warning: Selected architecture powerpc:common is not compatible with reported target architecture powerpc:common64 warning: Architecture rejected target-supplied description but still connects. Add a test for a 0 pc and exit early if that is the case. This may actually be a bug we need to fix? Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200520140541.30256-8-alex.bennee@linaro.org> -- 2.20.1 diff --git a/tests/tcg/multiarch/gdbstub/sha1.py b/tests/tcg/multiarch/gdbstub/sha1.py index 734553b98bb..2bfde49633c 100644 --- a/tests/tcg/multiarch/gdbstub/sha1.py +++ b/tests/tcg/multiarch/gdbstub/sha1.py @@ -65,6 +65,10 @@ except (gdb.error, AttributeError): print("SKIPPING (not connected)", file=sys.stderr) exit(0) +if gdb.parse_and_eval('$pc') == 0: + print("SKIP: PC not set") + exit(0) + try: # These are not very useful in scripts gdb.execute("set pagination off")