| Message ID | 20200701135652.1366-37-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing/next (vm, gitlab, fixes) | expand |
On 01/07/2020 15.56, Alex Bennée wrote: > As we run check-qtest in "SLOW" mode this can timeout so split into > two jobs. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Reviewed-by: Thomas Huth <thuth@redhat.com> Hi Alex, I think you can drop this patch and use "[PATCH v2] tests: improve performance of device-introspect-test" instead. Thanks, Thomas
Thomas Huth <thuth@redhat.com> writes: > On 01/07/2020 15.56, Alex Bennée wrote: >> As we run check-qtest in "SLOW" mode this can timeout so split into >> two jobs. >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> Reviewed-by: Thomas Huth <thuth@redhat.com> > > Hi Alex, > > I think you can drop this patch and use "[PATCH v2] tests: improve > performance of device-introspect-test" instead. As I'm re-rolling the PR sure... > > Thanks, > Thomas -- Alex Bennée
On 7/10/20 4:58 PM, Alex Bennée wrote: > > Thomas Huth <thuth@redhat.com> writes: > >> On 01/07/2020 15.56, Alex Bennée wrote: >>> As we run check-qtest in "SLOW" mode this can timeout so split into >>> two jobs. >>> >>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >>> Reviewed-by: Thomas Huth <thuth@redhat.com> >> >> Hi Alex, >> >> I think you can drop this patch and use "[PATCH v2] tests: improve >> performance of device-introspect-test" instead. > > As I'm re-rolling the PR sure... Also maybe: https://www.mail-archive.com/qemu-devel@nongnu.org/msg721458.html
Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > On 7/10/20 4:58 PM, Alex Bennée wrote: >> >> Thomas Huth <thuth@redhat.com> writes: >> >>> On 01/07/2020 15.56, Alex Bennée wrote: >>>> As we run check-qtest in "SLOW" mode this can timeout so split into >>>> two jobs. >>>> >>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >>>> Reviewed-by: Thomas Huth <thuth@redhat.com> >>> >>> Hi Alex, >>> >>> I think you can drop this patch and use "[PATCH v2] tests: improve >>> performance of device-introspect-test" instead. >> >> As I'm re-rolling the PR sure... > > Also maybe: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg721458.html I don't think it's directly related - can we just avoid pilling a bunch of stuff in on a re-roll please. -- Alex Bennée
On 7/10/20 6:26 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > >> On 7/10/20 4:58 PM, Alex Bennée wrote: >>> >>> Thomas Huth <thuth@redhat.com> writes: >>> >>>> On 01/07/2020 15.56, Alex Bennée wrote: >>>>> As we run check-qtest in "SLOW" mode this can timeout so split into >>>>> two jobs. >>>>> >>>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >>>>> Reviewed-by: Thomas Huth <thuth@redhat.com> >>>> >>>> Hi Alex, >>>> >>>> I think you can drop this patch and use "[PATCH v2] tests: improve >>>> performance of device-introspect-test" instead. >>> >>> As I'm re-rolling the PR sure... >> >> Also maybe: >> >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg721458.html > > I don't think it's directly related I thought it was. > - can we just avoid pilling a bunch > of stuff in on a re-roll please. Understood, sorry.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 13e9531724d..83e38ea19f3 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -113,7 +113,7 @@ acceptance-system-fedora-alt: MAKE_CHECK_ARGS: check-acceptance <<: *post_acceptance -build-disabled: +build-system-fedora-disabled: <<: *native_build_job_definition variables: IMAGE: fedora @@ -124,6 +124,17 @@ build-disabled: --disable-qom-cast-debug --disable-spice --disable-vhost-vsock --disable-vhost-net --disable-vhost-crypto --disable-vhost-user TARGETS: i386-softmmu ppc64-softmmu mips64-softmmu i386-linux-user + artifacts: + paths: + - build + +qtest-system-fedora-disabled: + <<: *native_test_job_definition + needs: + - job: build-system-fedora-disabled + artifacts: true + variables: + IMAGE: fedora MAKE_CHECK_ARGS: check-qtest SPEED=slow build-tcg-disabled: