From patchwork Fri Sep 18 15:06:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 305057 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995A9C43464 for ; Fri, 18 Sep 2020 15:19:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9925F2388B for ; Fri, 18 Sep 2020 15:19:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eYIK1SgI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9925F2388B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJIAz-0004yz-Mx for qemu-devel@archiver.kernel.org; Fri, 18 Sep 2020 11:19:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJHyA-0006ec-RB for qemu-devel@nongnu.org; Fri, 18 Sep 2020 11:06:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kJHy1-0000Zd-US for qemu-devel@nongnu.org; Fri, 18 Sep 2020 11:06:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600441587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TPDf+xbd6OSQVu/EfDuz5JDYKXxG48Jv4mpND68W+dk=; b=eYIK1SgITYlwGjIvB4svaDMedhdfA6V2l0b28gvLvgbW8Fsyyf0sIw4Zex/HWUgRH+FalU vcoyci00vSyjsWEBWbS4+mO6+vEpg1No/bsdiRZS93BQPsLcgTeI4Nt2uARNdEfpiiwsym zi0Fx8xI8CZ/VoUpNap6r8KkuEUYk6I= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-0nayQ8MTNqm4UDLQdj4rFg-1; Fri, 18 Sep 2020 11:06:25 -0400 X-MC-Unique: 0nayQ8MTNqm4UDLQdj4rFg-1 Received: by mail-wm1-f69.google.com with SMTP id m25so2173431wmi.0 for ; Fri, 18 Sep 2020 08:06:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TPDf+xbd6OSQVu/EfDuz5JDYKXxG48Jv4mpND68W+dk=; b=HFPxO6+6Kg7aXxpODiUlJh1ph/l9MtasKmaqNhw6h6zY7JN3Xj2a8bIf3GUJpIjcVf TirnjICHlIe93Gr6+INWFhYu8v+COcZJXTwytO5dVjXlKoeNfXrHczUF/uFsduQwKqLe 5sbsG6qeF38JAevn1Nfq9+vwWyMsq+lrzn4Ug5a3xiJ93yg7fDF7BZ1n09dEv63fpdxh 5zXR7cUHg/2Pf2H8BKPX4DDzLOeWtnYeylAiG5FNkije/Fb1ivJobC4fHKTAtETviDEg /6B9M+GbSiQYT+G69ySauzLMcz/svm5iqvhtohn9ncuwEuTiHgUb7bjn25rfATfQfQsm jDMA== X-Gm-Message-State: AOAM530jlXoWZoED7F+T/dEUXb+OMXjeGCiGeUSWxnbxdcUI88rrI0Qa WaIMiQe/pI5NpS2+MFgsqZ7Yje2m39FD6CaUHMnVg3onRlmmq0lUHyLlzWSD+2RA1oKsEDWKIet toaOPNzbxu78qYeM= X-Received: by 2002:a5d:404b:: with SMTP id w11mr15845961wrp.24.1600441583850; Fri, 18 Sep 2020 08:06:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwR5RK/JC+v+y/cP1WHwQC33eXCI3zHgGp7b+gvqZy0H7eM7RwD7Ah1QvqJJo1ic0mKu1c6uw== X-Received: by 2002:a5d:404b:: with SMTP id w11mr15845940wrp.24.1600441583694; Fri, 18 Sep 2020 08:06:23 -0700 (PDT) Received: from redhat.com (bzq-109-65-116-225.red.bezeqint.net. [109.65.116.225]) by smtp.gmail.com with ESMTPSA id a5sm5620789wrp.37.2020.09.18.08.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 08:06:23 -0700 (PDT) Date: Fri, 18 Sep 2020 11:06:21 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL 12/15] tests/qtest/vhost-user-test: enable the reconnect tests Message-ID: <20200918150506.286890-13-mst@redhat.com> References: <20200918150506.286890-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200918150506.286890-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 00:20:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Dima Stepanov , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Dima Stepanov For now a QTEST_VHOST_USER_FIXME environment variable is used to separate reconnect tests for the vhost-user-net device. Looks like the reconnect functionality is pretty stable, so this separation is deprecated. Remove it and enable these tests for the default run. Signed-off-by: Dima Stepanov Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/vhost-user-test.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c index f8c74285c1..d5293a4673 100644 --- a/tests/qtest/vhost-user-test.c +++ b/tests/qtest/vhost-user-test.c @@ -1139,20 +1139,17 @@ static void register_vhost_user_test(void) "virtio-net", test_migrate, &opts); - /* keeps failing on build-system since Aug 15 2017 */ - if (getenv("QTEST_VHOST_USER_FIXME")) { - opts.before = vhost_user_test_setup_reconnect; - qos_add_test("vhost-user/reconnect", "virtio-net", - test_reconnect, &opts); + opts.before = vhost_user_test_setup_reconnect; + qos_add_test("vhost-user/reconnect", "virtio-net", + test_reconnect, &opts); - opts.before = vhost_user_test_setup_connect_fail; - qos_add_test("vhost-user/connect-fail", "virtio-net", - test_vhost_user_started, &opts); + opts.before = vhost_user_test_setup_connect_fail; + qos_add_test("vhost-user/connect-fail", "virtio-net", + test_vhost_user_started, &opts); - opts.before = vhost_user_test_setup_flags_mismatch; - qos_add_test("vhost-user/flags-mismatch", "virtio-net", - test_vhost_user_started, &opts); - } + opts.before = vhost_user_test_setup_flags_mismatch; + qos_add_test("vhost-user/flags-mismatch", "virtio-net", + test_vhost_user_started, &opts); opts.before = vhost_user_test_setup_multiqueue; opts.edge.extra_device_opts = "mq=on";