| Message ID | 20200922210101.4081073-13-jsnow@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qapi: static typing conversion, pt1 | expand |
On Tue, Sep 22, 2020 at 05:00:35PM -0400, John Snow wrote: > Remove qapi/common.py from the pylintrc ignore list. > > Signed-off-by: John Snow <jsnow@redhat.com> No pylint warnings detected. Tested-by: Eduardo Habkost <ehabkost@redhat.com>
On Tue, Sep 22, 2020 at 05:00:35PM -0400, John Snow wrote: > Remove qapi/common.py from the pylintrc ignore list. > > Signed-off-by: John Snow <jsnow@redhat.com> $ pylint scripts/qapi/ --rcfile=scripts/qapi/pylintrc -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) I still think we should record (and maybe I'm missing it) the pylint version used though. Anyway: Reviewed-by: Cleber Rosa <crosa@redhat.com> Tested-by: Cleber Rosa <crosa@redhat.com>
On 9/23/20 12:18 PM, Cleber Rosa wrote: > I still think we should record (and maybe I'm missing it) the pylint > version used though. Anyway: Cover letter for all six parts mentions pylint 2.6.0! In the future this will be pinned in the CI mechanisms. --js
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index 02dd22c863..6151427a51 100644 --- a/scripts/qapi/pylintrc +++ b/scripts/qapi/pylintrc @@ -2,8 +2,7 @@ # Add files or directories matching the regex patterns to the ignore list. # The regex matches against base names, not paths. -ignore-patterns=common.py, - doc.py, +ignore-patterns=doc.py, error.py, expr.py, gen.py,
Remove qapi/common.py from the pylintrc ignore list. Signed-off-by: John Snow <jsnow@redhat.com> --- scripts/qapi/pylintrc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)