diff mbox series

[PULL,2/9] plugins: Fix two resource leaks in setup_socket()

Message ID 20201116122417.28346-3-alex.bennee@linaro.org
State New
Headers show
Series various fixes (CI, Xen, warnings) | expand

Commit Message

Alex Bennée Nov. 16, 2020, 12:24 p.m. UTC 
From: Alex Chen <alex.chen@huawei.com>


Either accept() fails or exits normally, we need to close the fd.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20201109082829.87496-3-alex.chen@huawei.com>
Message-Id: <20201110192316.26397-3-alex.bennee@linaro.org>

-- 
2.20.1
diff mbox series

Patch

diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44b83..5aad50869d 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -268,11 +268,13 @@  static bool setup_socket(const char *path)
     socket_fd = accept(fd, NULL, NULL);
     if (socket_fd < 0 && errno != EINTR) {
         perror("accept socket");
+        close(fd);
         return false;
     }
 
     qemu_plugin_outs("setup_socket::ready\n");
 
+    close(fd);
     return true;
 }