[02/27] tcg/aarch64: Fix I3617_CMLE0

Message ID	20210302175741.1079851-3-richard.henderson@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PATCH 02/27] tcg/aarch64: Fix I3617_CMLE0 Date: Tue, 2 Mar 2021 09:57:16 -0800 Message-Id: <20210302175741.1079851-3-richard.henderson@linaro.org> In-Reply-To: <20210302175741.1079851-1-richard.henderson@linaro.org> References: <20210302175741.1079851-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	tcg patch queue \| expand [00/27] tcg patch queue [01/27] tcg/aarch64: Fix constant subtraction in tcg_out_addsub2 [02/27] tcg/aarch64: Fix I3617_CMLE0 [03/27] tcg/aarch64: Fix generation of "scalar" vector operations [04/27] tcg/tci: Use exec/cpu_ldst.h interfaces [05/27] tcg: Split out tcg_raise_tb_overflow [06/27] tcg: Manage splitwx in tc_ptr_to_region_tree by hand [07/27] tcg/tci: Merge identical cases in generation (arithmetic opcodes) [08/27] tcg/tci: Merge identical cases in generation (exchange opcodes) [09/27] tcg/tci: Merge identical cases in generation (deposit opcode) [10/27] tcg/tci: Merge identical cases in generation (conditional opcodes) [11/27] tcg/tci: Merge identical cases in generation (load/store opcodes) [12/27] tcg/tci: Remove tci_read_r8 [13/27] tcg/tci: Remove tci_read_r8s [14/27] tcg/tci: Remove tci_read_r16 [15/27] tcg/tci: Remove tci_read_r16s [16/27] tcg/tci: Remove tci_read_r32 [17/27] tcg/tci: Remove tci_read_r32s [18/27] tcg/tci: Reduce use of tci_read_r64 [19/27] tcg/tci: Merge basic arithmetic operations [20/27] tcg/tci: Merge extension operations [21/27] tcg/tci: Merge bswap operations [22/27] tcg/tci: Merge mov, not and neg operations [23/27] accel/tcg: rename tb_lookup__cpu_state and hoist state extraction [24/27] accel/tcg: move CF_CLUSTER calculation to curr_cflags [25/27] accel/tcg: drop the use of CF_HASH_MASK and rename params [26/27] include/exec: lightly re-arrange TranslationBlock [27/27] accel/tcg: Precompute curr_cflags into cpu->tcg_cflags

Message ID

20210302175741.1079851-3-richard.henderson@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	209.51.188.17 as permitted sender) client-ip=209.51.188.17; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 02/27] tcg/aarch64: Fix I3617_CMLE0
Date: Tue,  2 Mar 2021 09:57:16 -0800
Message-Id: <20210302175741.1079851-3-richard.henderson@linaro.org>
In-Reply-To: <20210302175741.1079851-1-richard.henderson@linaro.org>
References: <20210302175741.1079851-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::530;
	envelope-from=richard.henderson@linaro.org;
	helo=mail-pg1-x530.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
	DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
	RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
	SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: alex.bennee@linaro.org
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

tcg patch queue | expand

Commit Message

Richard Henderson March 2, 2021, 5:57 p.m. UTC

Fix a typo in the encodeing of the cmle (zero) instruction.

Fixes: 14e4c1e2355 ("tcg/aarch64: Add vector operations")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 tcg/aarch64/tcg-target.c.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.25.1

Comments

Peter Maydell March 5, 2021, 2:17 p.m. UTC | #1

On Tue, 2 Mar 2021 at 18:05, Richard Henderson
<richard.henderson@linaro.org> wrote:
>

> Fix a typo in the encodeing of the cmle (zero) instruction.

>

> Fixes: 14e4c1e2355 ("tcg/aarch64: Add vector operations")

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  tcg/aarch64/tcg-target.c.inc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc

> index ec0a86d9d8..c8e41dd638 100644

> --- a/tcg/aarch64/tcg-target.c.inc

> +++ b/tcg/aarch64/tcg-target.c.inc

> @@ -561,7 +561,7 @@ typedef enum {

>      I3617_CMEQ0     = 0x0e209800,

>      I3617_CMLT0     = 0x0e20a800,

>      I3617_CMGE0     = 0x2e208800,

> -    I3617_CMLE0     = 0x2e20a800,

> +    I3617_CMLE0     = 0x2e209800,

>      I3617_NOT       = 0x2e205800,

>      I3617_ABS       = 0x0e20b800,

>      I3617_NEG       = 0x2e20b800,

> --


Reviewed-by: Peter Maydell <peter.maydell@linaro.org>


thanks
-- PMM

diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
index ec0a86d9d8..c8e41dd638 100644
--- a/tcg/aarch64/tcg-target.c.inc
+++ b/tcg/aarch64/tcg-target.c.inc
@@ -561,7 +561,7 @@  typedef enum {
     I3617_CMEQ0     = 0x0e209800,
     I3617_CMLT0     = 0x0e20a800,
     I3617_CMGE0     = 0x2e208800,
-    I3617_CMLE0     = 0x2e20a800,
+    I3617_CMLE0     = 0x2e209800,
     I3617_NOT       = 0x2e205800,
     I3617_ABS       = 0x0e20b800,
     I3617_NEG       = 0x2e20b800,

[02/27] tcg/aarch64: Fix I3617_CMLE0

Commit Message

Comments

Patch