From patchwork Tue Apr 6 15:00:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 415925 Delivered-To: patch@linaro.org Received: by 2002:a17:906:5290:0:0:0:0 with SMTP id c16csp4414533ejm; Tue, 6 Apr 2021 08:13:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/TI90+uT1YEQDfSy+4Rn4FpA0B/oeqXato0OWWVMfWSABaRPWYtsMHmdQ3PbskSSxaQeq X-Received: by 2002:a92:c608:: with SMTP id p8mr24269244ilm.288.1617721999545; Tue, 06 Apr 2021 08:13:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617721999; cv=none; d=google.com; s=arc-20160816; b=NUuGuf6sj8FFs5pBcE8tY3d6P9VpftZHd0sB/slWZ3veuJdZreil+BZ/II6/xrVkyf kt2pWt2y1FezckXvk0MmZ0eE+LINJzYjA3XWPtePraPxGZOGAYnM6r1kKXhpADLNuJdd wBA9Rfyp8oLq1fmCn40SCGq25Q3sc1w3JFRebXQ/bXXNRaQ9qLlS4fUgeJx1HfIY1zyd ofsf/vGtO2H40Z5DLbB3p5pWG3SJUuBXVWWYpJvFA1gweFF0y0ZqVoBnMqF78rquAgxN 4xw/KDqApBipQx7VpawE772mrqXIhIilVrsL28Id4AefQzpI1w5aGX62ObEJthSvFGkk UTVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1ZWLMlQokbn+ytm36tLs/g7l/rfbZT4dElLqTmVGEvY=; b=pai4XSIiEuih39+N2KH9YleKiFe19ztQC/JPVFs8BVzjBohW9yaeIKjXwVMObpytZP Nq4SFCsrNEkXYmUiEcHQSCrnvTTa9fg/WcXoKXVOSCpXGltfNJ73sPHZRFUhCXlMoPvl 8eFAygpAMvNbj1+Vi1EuOPt/0Xmn0gS2zz4AaKNhhTy3lFQ4pIZ6VItoW/98oiABIoeL SOpFw0iSGooHPrkbnIl+nV3RgNc4r1BmFQ8YsecogpT+lJ9C3/Th0p3K7VBLgzYxgSlr NV2Olg0Fq+f5D14KXUPupUNIieNKp+MhFfmFcNW6CKmFGZIfFH5+Amx71W/2znrYuljS Qy3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=t5CMIakZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x11si18406482iog.76.2021.04.06.08.13.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Apr 2021 08:13:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=t5CMIakZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTnOI-0002K1-TE for patch@linaro.org; Tue, 06 Apr 2021 11:13:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTnCZ-0006hY-C4 for qemu-devel@nongnu.org; Tue, 06 Apr 2021 11:01:11 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:51731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTnCX-0005Hi-J2 for qemu-devel@nongnu.org; Tue, 06 Apr 2021 11:01:11 -0400 Received: by mail-wm1-x333.google.com with SMTP id p19so7540311wmq.1 for ; Tue, 06 Apr 2021 08:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1ZWLMlQokbn+ytm36tLs/g7l/rfbZT4dElLqTmVGEvY=; b=t5CMIakZ15gFy9GFcx/hZRKyfa6ytzlvJUCeJJXCU+idYrAJIODyCKWGz96fSxQ9hO YZK4FXJ+SWbdKthuqWlT70vV7oONCu3TZorR/hUSv7Ezgkb6l4VwcyZ29i6KaXkYvMtR K0nYG+EudOYRpd2NTUF5wlFBqA8QZEStcKvtCxRL7I1SaJyGgFw3zfiwwQclUrfNFsp4 jaPLWrvll+nRdqwEZh83JtEH8pGRox0jpk5AkM5A+pPk2PevZWHrGPzDnMDH5dWxe1+k 5zEyFP9TWF1zWbf7VbjRWaSL/mZhtr5RBmwV9hpQ5m6CznEuQAq07Dc2vrPgKjIzup1O v5cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1ZWLMlQokbn+ytm36tLs/g7l/rfbZT4dElLqTmVGEvY=; b=mpSolGfqyn+s5mC2rwXRjxHB81r5o1eOZmbVm2KM8NwOk1GMJdoQ8b68y3BmaSe30d J83ZnHYX+71ezYSvnwhsW/1Smikjs97Txs1XZuY8RqigwcB4x7mJEDj7rnaZqeoNlLdz zYERF7V6JhX1d8uT10mj3zwdrdz23w2VpTILoGjwATksli0M/2uajV3yIr2jQ0uZnY5+ xCbf08ov1icud2iDEvQfkxosaDUTarWSIzmgCw6MZRnhlcRitot+YpKMaeQqgaKoUXcG ouvAwculmocnOk6CteAWqWV74mkU3wQTr6gH5AJUqWBoIbEThpRaX4K+q4D4/ddzQa2Q vxDw== X-Gm-Message-State: AOAM533UmJfAP+nui2kDrVzegnvVG69zwBVIrx/aXhI/imfwYEcwEySG XMN0gYuAI5Xa/7U9FdQaMf+uxA== X-Received: by 2002:a7b:c188:: with SMTP id y8mr4507569wmi.76.1617721268174; Tue, 06 Apr 2021 08:01:08 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u19sm3028804wml.28.2021.04.06.08.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 08:00:50 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A98F11FF93; Tue, 6 Apr 2021 16:00:42 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 07/11] tests/tcg: relax the next step precision of the gdb sha1 test Date: Tue, 6 Apr 2021 16:00:37 +0100 Message-Id: <20210406150041.28753-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210406150041.28753-1-alex.bennee@linaro.org> References: <20210406150041.28753-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , qemu-devel@nongnu.org, =?utf-8?q?Philippe_Ma?= =?utf-8?q?thieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Depending on the version of gdb we may not execute the first line of SHA1Init when executing the first "next" command - instead just stepping over the preamble. As we don't actually care about the position of the PC after the steps and want to be sure the context->state[] has been loaded before we inspect it do a double next at the start. Signed-off-by: Alex Bennée Tested-by: Richard Henderson Message-Id: <20210401102530.12030-8-alex.bennee@linaro.org> -- 2.20.1 diff --git a/tests/tcg/multiarch/gdbstub/sha1.py b/tests/tcg/multiarch/gdbstub/sha1.py index 2bfde49633..423b720e6d 100644 --- a/tests/tcg/multiarch/gdbstub/sha1.py +++ b/tests/tcg/multiarch/gdbstub/sha1.py @@ -40,7 +40,10 @@ def run_test(): check_break("SHA1Init") - # check step and inspect values + # Check step and inspect values. We do a double next after the + # breakpoint as depending on the version of gdb we may step the + # preamble and not the first actual line of source. + gdb.execute("next") gdb.execute("next") val_ctx = gdb.parse_and_eval("context->state[0]") exp_ctx = 0x67452301