From patchwork Fri May 14 12:15:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 438904 Delivered-To: patch@linaro.org Received: by 2002:a02:b78d:0:0:0:0:0 with SMTP id f13csp299967jam; Fri, 14 May 2021 05:35:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxNNT2icn1iL7I7q74pZWZ1imxsN9cgVbhsHMfmqjxSMJ7fOB1gnJJe3XsiLzzK5TLVIwi X-Received: by 2002:aa7:db94:: with SMTP id u20mr34334760edt.381.1620995735539; Fri, 14 May 2021 05:35:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620995735; cv=none; d=google.com; s=arc-20160816; b=h5MCn6JouwP6yLGCONIvUQYXRc9lkmYWTqR27NB7so+vwq5d3b3pdHGPa8B9UMKi/c C5dUXPqnLzGyrsJ/e53aCtStSENvMHOMnlhNofJC8y8ASyKaAo1q+e0rOCZruBGMFMPG JaNXa8L9cEAlrJkc/SWOGRjk00x9FiemAnjAH5D4VG4hxqkeKBVAYanTfmVf8as2znbL me4Qzlsj/eSsnNqOdjZuxZ3/tFx3qT48sc6J7eKK5yNlyTtaWnjJCU4Dad+VclV4xkB/ pC96iUWluBz3/6VjceJHlfhjhuFxUbdXGSbn0QxVd/drr19G51/HvuyHnozAZGAPQo2q GPpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=SUBqIr3WvhNROSfqC7gDwf0PYwulCayH7dwWB5D5wqw=; b=eu5js5cVAL6358JRyONohQQ5R4vrVPvgE2xEOcl/Y2d0s+tzOVEOSdS0bsgTUJkL6s m+NDts1M8+BRlRcHAdajAFXRFp9IXRo9V60AIiHsMzO8yULGvxmY8yT8T+yYnH8zATL+ r9IuRQndAac0HwVHz2yS3b+sLzpMB0G4yUgmQEtgIOcjkkdpLoNFZs8Ki7QfuzWZkzBG ipDV6Bj4H0i7q2uAv//YcGcNWEQdrV6KgZF9HzZkqNhztXQdIIxYPXmFLXaT9O3LtTM9 twIjiJ+WwLRcmQ0yt7sgkIfShvmCuMXf8TCypjOaYCtLb7wh8XCo68uIkJPYQ4M9XgY4 5QIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="K/D7HctS"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v11si5818573edt.160.2021.05.14.05.35.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 May 2021 05:35:35 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="K/D7HctS"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:55324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhX2U-0006rh-Im for patch@linaro.org; Fri, 14 May 2021 08:35:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhWjy-0001Cp-JQ for qemu-devel@nongnu.org; Fri, 14 May 2021 08:16:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhWjs-0005Gu-9q for qemu-devel@nongnu.org; Fri, 14 May 2021 08:16:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620994579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SUBqIr3WvhNROSfqC7gDwf0PYwulCayH7dwWB5D5wqw=; b=K/D7HctSPk97uQqc3vbvlNwW88bT6JpF0i+/WJuwy6EcUGjdtaDRdnpZkbf3MMIoOhXkBx UaDFZ9vyE7h+1yy/R/nuLEhL6s8KKK7RJSkGv4WdlkJj+VqKDmBs3a+CgIDzfXoIQ8fGfv KYp9vrZ2Rmu4K2KH4JMO8zg0ywXR+4w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-pUHFTsNeNYmDIg_vBsg23w-1; Fri, 14 May 2021 08:16:05 -0400 X-MC-Unique: pUHFTsNeNYmDIg_vBsg23w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4479106BB40; Fri, 14 May 2021 12:16:04 +0000 (UTC) Received: from thuth.com (ovpn-112-191.ams2.redhat.com [10.36.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7619C6060F; Fri, 14 May 2021 12:16:03 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 12/20] tests/qtest/tpm-util.c: Free memory with correct free function Date: Fri, 14 May 2021 14:15:10 +0200 Message-Id: <20210514121518.832729-13-thuth@redhat.com> In-Reply-To: <20210514121518.832729-1-thuth@redhat.com> References: <20210514121518.832729-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Stefan Berger Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell tpm_util_migration_start_qemu() allocates memory with g_strdup_printf() but frees it with free() rather than g_free(), which provokes Coverity complaints (CID 1432379, 1432350). Use the correct free function. Fixes: Coverity CID 1432379, CID 1432350 Signed-off-by: Peter Maydell Reviewed-by: Stefan Berger Reviewed-by: Alex Bennée Message-Id: <20210503165525.26221-2-peter.maydell@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/tpm-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0 diff --git a/tests/qtest/tpm-util.c b/tests/qtest/tpm-util.c index b70cc32d60..3a40ff3f96 100644 --- a/tests/qtest/tpm-util.c +++ b/tests/qtest/tpm-util.c @@ -289,6 +289,6 @@ void tpm_util_migration_start_qemu(QTestState **src_qemu, *dst_qemu = qtest_init(dst_qemu_args); - free(src_qemu_args); - free(dst_qemu_args); + g_free(src_qemu_args); + g_free(dst_qemu_args); }