From patchwork Wed May 19 12:51:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 442413 Delivered-To: patch@linaro.org Received: by 2002:a02:7a1b:0:0:0:0:0 with SMTP id a27csp1312988jac; Wed, 19 May 2021 06:17:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNCZQLXlu8zxg1DZgPh2p7dkStXVnwWgw5lO96KW8b9dwp0yCitJMGs+zrr+HdqwGQbS4U X-Received: by 2002:a02:660e:: with SMTP id k14mr13058641jac.9.1621430270049; Wed, 19 May 2021 06:17:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621430270; cv=none; d=google.com; s=arc-20160816; b=wQwjK1heLhnUWSydSQR2B9IGV73hvteHUSce7YJHJkXoFuqncTR2zHKqSgiSDdvfvJ A6kGbDVFi56KDc0pSzTOZaZOGTWJLcZFzRRCHynDLUi+h5Kph/7TZnm2MBdF2+4lHR8u q/iKisDDHEJfRmvEfbhD79l75YDiLZIrY1YC2ZvV7oU5RZR3gXMW9oKfNNnmMWM+2ajF DTMKANvwsnmRqcIzGi1AXA/9ydbH1Ww+ZMlmXAVdFqySs8iCOA/4o+xR0hkvOfIFPXxD pRRwKlLE8ozkILKrLYJbid3CNWGhA0DN+YWNz9CGlDZ6xy91JbiwakPESFotKu3BPFR/ s3jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=xbVgONUdilvxkhqLb6q02thsJB0UMn4KPcik9Z6dO3k=; b=wR2w9ALK1R44VwYVpWJVmOpJAeiNrRgE8t8wJz3a75ElydS0MaTum4JkGEEDjn53Rt gRIQ/XzF0CkKKMJU1Kr7HDxuizZz7ZT+bebD/FQ04Zh5FracP87SE8Wg7VwgimCleyoB SSPSOnMDyNJrJ8+M9W7P2lwG1+xZ2yf73h3HvKc6+oQ5KlgeeFmsmFZ+ZmH1/suttXXQ I3t1cxdmSYOuAhb3NllGPGbQ/OIFa7+C+9vtYPU78NzkuHRVfT0mbXZnvJewKISIqSCo heGrSA2kD/yXuhQx7kCzDwcQxtkHfOot6teua9HH0A1takXY7ufXDQFhmEL3i9eeFu4D G7HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gibson.dropbear.id.au header.s=201602 header.b=VFUvbgYM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x11si16402030ilp.53.2021.05.19.06.17.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 May 2021 06:17:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gibson.dropbear.id.au header.s=201602 header.b=VFUvbgYM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:42198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljM57-0007zw-GA for patch@linaro.org; Wed, 19 May 2021 09:17:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljLh7-0001K6-M8; Wed, 19 May 2021 08:53:02 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:34641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljLgz-0001MS-5J; Wed, 19 May 2021 08:52:54 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4FlXnk4TYPz9t2b; Wed, 19 May 2021 22:52:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1621428730; bh=zpsVKsxnnsx7gNVqFu7VaZXETBUW1ZEzg+RP1HiSQ60=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VFUvbgYMwi077GBmHek974H6xexwWteRL5gbHtKL2ld0r/QiLtVTxx6XWo2eHrXSE RuQAvtzPRiy3SIJ7f/nIjfUwO8xIMoTEEGZwuNSrINB/XFJ3gGb37yAvrh6fmgx7oq yGN5Q1d07qXjLnTxQO00DdcGvHP0ykPhakFhdd+g= From: David Gibson To: peter.maydell@linaro.org, groug@kaod.org Subject: [PULL 30/48] target/ppc: Tidy exception vs exit_tb Date: Wed, 19 May 2021 22:51:30 +1000 Message-Id: <20210519125148.27720-31-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210519125148.27720-1-david@gibson.dropbear.id.au> References: <20210519125148.27720-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard.henderson@linaro.org, David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Matheus Ferst Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson We do not need to emit an exit_tb after an exception, as the latter will exit via longjmp. Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst Message-Id: <20210517205025.3777947-7-matheus.ferst@eldorado.org.br> Signed-off-by: David Gibson --- target/ppc/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.31.1 diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 05e3c0417a..e68152810e 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -4648,8 +4648,9 @@ static void gen_lookup_and_goto_ptr(DisasContext *ctx) } else if (sse & (CPU_SINGLE_STEP | CPU_BRANCH_STEP)) { uint32_t excp = gen_prep_dbgex(ctx); gen_exception(ctx, excp); + } else { + tcg_gen_exit_tb(NULL, 0); } - tcg_gen_exit_tb(NULL, 0); } else { tcg_gen_lookup_and_goto_ptr(); }