diff mbox series

[v16,12/99] qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore

Message ID 20210604155312.15902-13-alex.bennee@linaro.org
State New
Headers show
Series arm tcg/kvm refactor and split with kvm only support | expand

Commit Message

Alex Bennée June 4, 2021, 3:51 p.m. UTC
From: Philippe Mathieu-Daudé <philmd@redhat.com>


Since commit 82bf7ae84ce ("target/arm: Remove KVM support for
32-bit Arm hosts") we can remove the comment / check added in
commit ab6b6a77774 and directly run the bios-tables-test.

Reviewed-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Tested-by: Alex Bennée <alex.bennee@linaro.org>

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20210505125806.1263441-13-philmd@redhat.com>
---
 tests/qtest/meson.build | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.20.1

Comments

Richard Henderson June 4, 2021, 9:15 p.m. UTC | #1
On 6/4/21 8:51 AM, Alex Bennée wrote:
> From: Philippe Mathieu-Daudé<philmd@redhat.com>

> 

> Since commit 82bf7ae84ce ("target/arm: Remove KVM support for

> 32-bit Arm hosts") we can remove the comment / check added in

> commit ab6b6a77774 and directly run the bios-tables-test.

> 

> Reviewed-by: Eric Blake<eblake@redhat.com>

> Reviewed-by: Alex Bennée<alex.bennee@linaro.org>

> Tested-by: Alex Bennée<alex.bennee@linaro.org>

> Signed-off-by: Philippe Mathieu-Daudé<philmd@redhat.com>

> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>

> Message-Id:<20210505125806.1263441-13-philmd@redhat.com>

> ---

>   tests/qtest/meson.build | 3 +--

>   1 file changed, 1 insertion(+), 2 deletions(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~
Thomas Huth June 7, 2021, 1:48 p.m. UTC | #2
On 04/06/2021 17.51, Alex Bennée wrote:
> From: Philippe Mathieu-Daudé <philmd@redhat.com>

> 

> Since commit 82bf7ae84ce ("target/arm: Remove KVM support for

> 32-bit Arm hosts") we can remove the comment / check added in

> commit ab6b6a77774 and directly run the bios-tables-test.

> 

> Reviewed-by: Eric Blake <eblake@redhat.com>

> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> Tested-by: Alex Bennée <alex.bennee@linaro.org>

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> Message-Id: <20210505125806.1263441-13-philmd@redhat.com>

> ---

>   tests/qtest/meson.build | 3 +--

>   1 file changed, 1 insertion(+), 2 deletions(-)

> 

> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build

> index c3a223a83d..2c7415d616 100644

> --- a/tests/qtest/meson.build

> +++ b/tests/qtest/meson.build

> @@ -176,14 +176,13 @@ qtests_arm = \

>      'boot-serial-test',

>      'hexloader-test']

>   

> -# TODO: once aarch64 TCG is fixed on ARM 32 bit host, make bios-tables-test unconditional

>   qtests_aarch64 = \

> -  (cpu != 'arm' ? ['bios-tables-test'] : []) +                                                  \

>     (config_all_devices.has_key('CONFIG_TPM_TIS_SYSBUS') ? ['tpm-tis-device-test'] : []) +        \

>     (config_all_devices.has_key('CONFIG_TPM_TIS_SYSBUS') ? ['tpm-tis-device-swtpm-test'] : []) +  \

>     ['arm-cpu-features',

>      'numa-test',

>      'boot-serial-test',

> +   'bios-tables-test',

>      'xlnx-can-test',

>      'migration-test']

>   

> 


Acked-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index c3a223a83d..2c7415d616 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -176,14 +176,13 @@  qtests_arm = \
    'boot-serial-test',
    'hexloader-test']
 
-# TODO: once aarch64 TCG is fixed on ARM 32 bit host, make bios-tables-test unconditional
 qtests_aarch64 = \
-  (cpu != 'arm' ? ['bios-tables-test'] : []) +                                                  \
   (config_all_devices.has_key('CONFIG_TPM_TIS_SYSBUS') ? ['tpm-tis-device-test'] : []) +        \
   (config_all_devices.has_key('CONFIG_TPM_TIS_SYSBUS') ? ['tpm-tis-device-swtpm-test'] : []) +  \
   ['arm-cpu-features',
    'numa-test',
    'boot-serial-test',
+   'bios-tables-test',
    'xlnx-can-test',
    'migration-test']